diff options
| author | LOLi <[email protected]> | 2018-09-21 18:42:42 +0200 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2018-09-21 09:42:42 -0700 |
| commit | dda5500853c736aca9ad8c14f7d22cd9d9f9fb36 (patch) | |
| tree | 6d83723dc6d3befaeb2c676d6170311c5cf4aef3 | |
| parent | 9d489ab3a8bc866f3658c332230aee02b1b2012d (diff) | |
vdev_disk_error() prints ASCII SOH to debug log
Currently vdev_disk_error() prepends its messages sent to the internal
ZFS debug log with KERN_WARNING, which is currently defined as follows:
#define KERN_SOH "\001"
#define KERN_WARNING KERN_SOH "4"
Since "\001" (ASCII Start Of Header) is not printable this results in
weird characters displayed when inspecting the debug log. This commit
simply removes this superfluous prefix passed to zfs_dbgmsg().
Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Richard Laager <[email protected]>
Signed-off-by: loli10K <[email protected]>
Closes #7936
| -rw-r--r-- | module/zfs/vdev_disk.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/module/zfs/vdev_disk.c b/module/zfs/vdev_disk.c index 78741af7f..a4109543d 100644 --- a/module/zfs/vdev_disk.c +++ b/module/zfs/vdev_disk.c @@ -139,10 +139,9 @@ bdev_max_capacity(struct block_device *bdev, uint64_t wholedisk) static void vdev_disk_error(zio_t *zio) { - zfs_dbgmsg(KERN_WARNING "zio error=%d type=%d offset=%llu size=%llu " - "flags=%x\n", zio->io_error, zio->io_type, - (u_longlong_t)zio->io_offset, (u_longlong_t)zio->io_size, - zio->io_flags); + zfs_dbgmsg("zio error=%d type=%d offset=%llu size=%llu flags=%x\n", + zio->io_error, zio->io_type, (u_longlong_t)zio->io_offset, + (u_longlong_t)zio->io_size, zio->io_flags); } /* |