diff options
| author | Richard Yao <[email protected]> | 2022-09-12 15:54:43 -0400 |
|---|---|---|
| committer | GitHub <[email protected]> | 2022-09-12 12:54:43 -0700 |
| commit | 710fd1ded68491a164d85aedc69ffd4675ec5c59 (patch) | |
| tree | f805c4d7a304b4760dfe014c2d2e4bebdeb7823a | |
| parent | e5327e7f9790ed7e884a7f8d9fa412632506b826 (diff) | |
zpool_load_compat() should create strings of length ZFS_MAXPROPLEN
Otherwise, `strlcat()` can overflow them.
Coverity found this.
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes #13866
| -rw-r--r-- | lib/libzfs/libzfs_pool.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/libzfs/libzfs_pool.c b/lib/libzfs/libzfs_pool.c index 928f8b428..eea388cf3 100644 --- a/lib/libzfs/libzfs_pool.c +++ b/lib/libzfs/libzfs_pool.c @@ -4684,8 +4684,8 @@ zpool_load_compat(const char *compat, boolean_t *features, char *report, for (uint_t i = 0; i < SPA_FEATURES; i++) features[i] = B_TRUE; - char err_badfile[1024] = ""; - char err_badtoken[1024] = ""; + char err_badfile[ZFS_MAXPROPLEN] = ""; + char err_badtoken[ZFS_MAXPROPLEN] = ""; /* * We ignore errors from the directory open() |