aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorнаб <[email protected]>2022-04-07 22:49:22 +0200
committerBrian Behlendorf <[email protected]>2022-05-10 10:18:06 -0700
commit6fc34371e1df4d74dee6e50ffd9d9fae234b55ba (patch)
tree06e77015f473598789556b2a9b8afa380173a032
parentbe91239efaec7729d4eac334f94395aeb4699092 (diff)
libzfs: pool: fix false-positives -Wmaybe-uninitialised
As noted by gcc (Debian 10.2.1-6) 10.2.1 20210110 Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #13316
-rw-r--r--lib/libzfs/libzfs_pool.c4
-rw-r--r--module/icp/algs/edonr/edonr.c5
2 files changed, 3 insertions, 6 deletions
diff --git a/lib/libzfs/libzfs_pool.c b/lib/libzfs/libzfs_pool.c
index cd7062a88..83fab0433 100644
--- a/lib/libzfs/libzfs_pool.c
+++ b/lib/libzfs/libzfs_pool.c
@@ -5184,7 +5184,7 @@ zpool_get_vdev_prop(zpool_handle_t *zhp, const char *vdevname, vdev_prop_t prop,
{
nvlist_t *reqnvl, *reqprops;
nvlist_t *retprops = NULL;
- uint64_t vdev_guid;
+ uint64_t vdev_guid = 0;
int ret;
if ((ret = zpool_vdev_guid(zhp, vdevname, &vdev_guid)) != 0)
@@ -5243,7 +5243,7 @@ zpool_get_all_vdev_props(zpool_handle_t *zhp, const char *vdevname,
nvlist_t **outnvl)
{
nvlist_t *nvl = NULL;
- uint64_t vdev_guid;
+ uint64_t vdev_guid = 0;
int ret;
if ((ret = zpool_vdev_guid(zhp, vdevname, &vdev_guid)) != 0)
diff --git a/module/icp/algs/edonr/edonr.c b/module/icp/algs/edonr/edonr.c
index 6f3a43e26..9388a6f6b 100644
--- a/module/icp/algs/edonr/edonr.c
+++ b/module/icp/algs/edonr/edonr.c
@@ -47,10 +47,7 @@
#define hashState384(x) ((x)->pipe->p512)
#define hashState512(x) ((x)->pipe->p512)
-/* shift and rotate shortcuts */
-#define shl(x, n) ((x) << n)
-#define shr(x, n) ((x) >> n)
-
+/* rotate shortcuts */
#define rotl32(x, n) (((x) << (n)) | ((x) >> (32 - (n))))
#define rotr32(x, n) (((x) >> (n)) | ((x) << (32 - (n))))