diff options
author | Neal Gompa (ニール・ゴンパ) <[email protected]> | 2019-01-08 12:23:05 -0500 |
---|---|---|
committer | Brian Behlendorf <[email protected]> | 2019-01-08 09:23:05 -0800 |
commit | 4efb48eecb43717f70817bfb152bf86f7ed28b5b (patch) | |
tree | 5bcbcc41d7868045a7d5e6193be5e665b35e7c1b | |
parent | 22448f08942457ab34579cb7d7edbcf635fa25a6 (diff) |
Bump commit subject length to 72 characters
There's not really a reason to keep the subject length so short,
since the reason to make it this short was for making nice renders
of a summary list of the git log. With 72 characters, this still
works out fine, so let's just raise it to that so that it's easier
to give slightly more descriptive change summaries.
Reviewed by: Matt Ahrens <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Neal Gompa <[email protected]>
Closes #8250
-rw-r--r-- | .github/CONTRIBUTING.md | 2 | ||||
-rwxr-xr-x | scripts/commitcheck.sh | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 32be3d410..1bd17bd93 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -164,7 +164,7 @@ coding convention. ### Commit Message Formats #### New Changes Commit messages for new changes must meet the following guidelines: -* In 50 characters or less, provide a summary of the change as the +* In 72 characters or less, provide a summary of the change as the first line in the commit message. * A body which provides a description of the change. If necessary, please summarize important information such as why the proposed diff --git a/scripts/commitcheck.sh b/scripts/commitcheck.sh index f377bb912..2954b0fd7 100755 --- a/scripts/commitcheck.sh +++ b/scripts/commitcheck.sh @@ -69,10 +69,10 @@ function new_change_commit() { error=0 - # subject is not longer than 50 characters - long_subject=$(git log -n 1 --pretty=%s "$REF" | grep -E -m 1 '.{51}') + # subject is not longer than 72 characters + long_subject=$(git log -n 1 --pretty=%s "$REF" | grep -E -m 1 '.{73}') if [ -n "$long_subject" ]; then - echo "error: commit subject over 50 characters" + echo "error: commit subject over 72 characters" error=1 fi |