summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrian Behlendorf <[email protected]>2010-07-30 22:20:58 -0700
committerBrian Behlendorf <[email protected]>2010-07-30 22:20:58 -0700
commit41f84a8d56c00f3c95a4bf0b6027bedd7abb5b15 (patch)
treed537ddf811dcd38cb4f313f16674ef3a25d7ed11
parent099dc9c2d275b4475f130f3d03bab88516101b36 (diff)
Strfree() should call kfree() not kmem_free()
Using kmem_free() results in deducting X bytes from the memory accounting when --enable-debug is set. Unfortunately, currently the counterpart kmem_asprintf() and friends do not properly account for memory allocated, so we must do the same on free. If we don't then we end up with a negative number of lost bytes reported when the module is unloaded. A better long term fix would be to add the accounting in to the allocation side but that's a project for another day.
-rw-r--r--module/spl/spl-kmem.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/module/spl/spl-kmem.c b/module/spl/spl-kmem.c
index ec1ccb4ce..53aefee14 100644
--- a/module/spl/spl-kmem.c
+++ b/module/spl/spl-kmem.c
@@ -295,7 +295,7 @@ EXPORT_SYMBOL(strdup);
void
strfree(char *str)
{
- kmem_free(str, strlen(str) + 1);
+ kfree(str);
}
EXPORT_SYMBOL(strfree);