summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrian Behlendorf <[email protected]>2011-02-17 09:48:06 -0800
committerBrian Behlendorf <[email protected]>2011-02-17 09:48:06 -0800
commit5095000169f695ea6b65d74da917c3f465d05aab (patch)
tree147ca67015591359597862f11a44ab4c20124afc
parentf03e41e8da6d184039ea3b03ba4937f4786a3f22 (diff)
Use -zfs_readlink() error
The zfs_readlink() function returns a Solaris positive error value and that needs to be converted to a Linux negative error value. While in this case nothing would actually go wrong, it's still incorrect and should be fixed if for no other reason than clarity.
-rw-r--r--module/zfs/zpl_inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/module/zfs/zpl_inode.c b/module/zfs/zpl_inode.c
index 75d299b47..888dc17cc 100644
--- a/module/zfs/zpl_inode.c
+++ b/module/zfs/zpl_inode.c
@@ -262,7 +262,7 @@ zpl_follow_link(struct dentry *dentry, struct nameidata *nd)
uio.uio_resid = (MAXPATHLEN - 1);
uio.uio_segflg = UIO_SYSSPACE;
- error = zfs_readlink(ip, &uio, cr);
+ error = -zfs_readlink(ip, &uio, cr);
if (error) {
kmem_free(link, MAXPATHLEN);
nd_set_link(nd, ERR_PTR(error));