diff options
| author | Brian Behlendorf <[email protected]> | 2011-04-18 16:44:22 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2011-04-19 09:04:51 -0700 |
| commit | 03514b01109e0a6ef4eee4914ba7442c380fa6b4 (patch) | |
| tree | 02d0d6014c47ebd0dc9ca5100d6faa649a573c9e | |
| parent | 0fe3d820f5be0cc5733f08aa4a57093c7b8febe6 (diff) | |
Fix gcc compiler warning, parse_option()
When compiling ZFS in user space gcc-4.6.0 correctly identifies
the variable 'value' as being set but never used. This generates a
warning and a build failure when using --enable-debug. Once again
this is correct but I'm reluctant to remove 'value' because we are
breaking the string in to name/value pairs. While it is not used
now there's a good chance it will be soon and I'd rather not have
to reinvent this. To suppress the warning with just as a VERIFY().
This was observed under Fedora 15.
cmd/mount_zfs/mount_zfs.c: In function ‘parse_option’:
cmd/mount_zfs/mount_zfs.c:112:21: error: variable ‘value’ set but not
used [-Werror=unused-but-set-variable]
| -rw-r--r-- | cmd/mount_zfs/mount_zfs.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/cmd/mount_zfs/mount_zfs.c b/cmd/mount_zfs/mount_zfs.c index aff9e1003..c38ba51c3 100644 --- a/cmd/mount_zfs/mount_zfs.c +++ b/cmd/mount_zfs/mount_zfs.c @@ -120,6 +120,7 @@ parse_option(char *mntopt, unsigned long *mntflags, if (*ptr == '=') { *ptr = '\0'; value = ptr+1; + VERIFY3P(value, !=, NULL); break; } } |