diff options
| author | Tony Hutter <[email protected]> | 2018-04-06 16:32:58 -0700 |
|---|---|---|
| committer | Tony Hutter <[email protected]> | 2018-05-07 17:19:57 -0700 |
| commit | d296b094566a981984e29b5b87d8e5aa9dbda703 (patch) | |
| tree | d4d0f114294e4b24b6f6e642a9925559154de2ff | |
| parent | 5ac017fc04c339235ac05a20a23990ee4ff12cd2 (diff) | |
Exclude python scripts from RPM shebang check
The newest Fedora packaging rules print warnings for scripts using the
/usr/bin/python shebang:
*** WARNING: mangling shebang in /usr/bin/arc_summary.py from
#!/usr/bin/python to #!/usr/bin/python2. This will become an ERROR,
fix it manually!
Fedora wants all cross compatible scripts to pick python3. Since we
don't want our users to have to pick a specific version of python, we
exclude our scripts from the RPM build check.
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Giuseppe Di Natale <[email protected]>
Signed-off-by: Tony Hutter <[email protected]>
Closes #7360
Closes #7399
| -rw-r--r-- | rpm/generic/zfs.spec.in | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/rpm/generic/zfs.spec.in b/rpm/generic/zfs.spec.in index 0a5d1c543..3a46c127e 100644 --- a/rpm/generic/zfs.spec.in +++ b/rpm/generic/zfs.spec.in @@ -36,6 +36,16 @@ %bcond_with debug %bcond_with systemd +# Python permits the !/usr/bin/python shebang for scripts that are cross +# compatible between python2 and python3, but Fedora 28 does not. Fedora +# wants us to choose python3 for cross-compatible scripts. Since we want +# to support python2 and python3 users, exclude our scripts from Fedora 28's +# RPM build check, so that we don't get a bunch of build warnings. +# +# Details: https://github.com/zfsonlinux/zfs/issues/7360 +# +%global __brp_mangle_shebangs_exclude_from arc_summary.py|arcstat.py|dbufstat.py|test-runner.py + # Generic enable switch for systemd %if %{with systemd} %define _systemd 1 |