diff options
| author | behlendo <behlendo@7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c> | 2008-11-04 23:38:29 +0000 |
|---|---|---|
| committer | behlendo <behlendo@7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c> | 2008-11-04 23:38:29 +0000 |
| commit | ac569b72a10d5676a5a572a8aa44bfab9b29cbac (patch) | |
| tree | 515ba92f2611f3afaf49895316ca55ac6906e1a8 | |
| parent | 12018327f5a42304971b816d64756a47cb1bed9f (diff) | |
Fix a small corner case in the test infrastructure where
we might end up with a non-NULL terminated buffer if the
test name or desc is too long. Only copy N-1 bytes.
git-svn-id: https://outreach.scidac.gov/svn/spl/trunk@173 7e1ea52c-4ff2-0310-8f11-9dd32ca42a1c
| -rw-r--r-- | modules/splat/splat-internal.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/splat/splat-internal.h b/modules/splat/splat-internal.h index bda56f1bc..c98201dfd 100644 --- a/modules/splat/splat-internal.h +++ b/modules/splat/splat-internal.h @@ -110,8 +110,8 @@ printk(KERN_ERR "splat: Error initializing: " n "/" #tid" \n");\ } else { \ memset(_test_, 0, sizeof(*_test_)); \ - strncpy(_test_->desc.name, n, SPLAT_NAME_SIZE); \ - strncpy(_test_->desc.desc, d, SPLAT_DESC_SIZE); \ + strncpy(_test_->desc.name, n, SPLAT_NAME_SIZE-1); \ + strncpy(_test_->desc.desc, d, SPLAT_DESC_SIZE-1); \ _test_->desc.id = tid; \ _test_->test = func; \ INIT_LIST_HEAD(&(_test_->test_list)); \ |