diff options
| author | Richard Yao <[email protected]> | 2022-10-18 15:42:14 -0400 |
|---|---|---|
| committer | Tony Hutter <[email protected]> | 2022-12-01 12:39:41 -0800 |
| commit | 4351d18fb0bf4e75de1d1ddecaa412ca8b1893ae (patch) | |
| tree | 2f28901d98ff7b7ca5a109a177a1344a6d16ab38 | |
| parent | 2453f9035007e69ab63e0b2268f42bbefb3c90f3 (diff) | |
ZED: Fix uninitialized value reads
Coverity complained about a couple of uninitialized value reads in ZED.
* zfs_deliver_dle() can pass an uninitialized string to zed_log_msg()
* An uninitialized sev.sigev_signo is passed to timer_create()
The former would log garbage while the latter is not a real issue, but
we might as well suppress it by initializing the field to 0 for
consistency's sake.
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes #14047
| -rw-r--r-- | cmd/zed/agents/fmd_api.c | 1 | ||||
| -rw-r--r-- | cmd/zed/agents/zfs_mod.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/cmd/zed/agents/fmd_api.c b/cmd/zed/agents/fmd_api.c index 607b387ca..f6cb7635f 100644 --- a/cmd/zed/agents/fmd_api.c +++ b/cmd/zed/agents/fmd_api.c @@ -599,6 +599,7 @@ fmd_timer_install(fmd_hdl_t *hdl, void *arg, fmd_event_t *ep, hrtime_t delta) sev.sigev_notify_function = _timer_notify; sev.sigev_notify_attributes = NULL; sev.sigev_value.sival_ptr = ftp; + sev.sigev_signo = 0; timer_create(CLOCK_REALTIME, &sev, &ftp->ft_tid); timer_settime(ftp->ft_tid, 0, &its, NULL); diff --git a/cmd/zed/agents/zfs_mod.c b/cmd/zed/agents/zfs_mod.c index d4d7a9980..22447100b 100644 --- a/cmd/zed/agents/zfs_mod.c +++ b/cmd/zed/agents/zfs_mod.c @@ -1122,6 +1122,7 @@ zfs_deliver_dle(nvlist_t *nvl) strlcpy(name, devname, MAXPATHLEN); zfs_append_partition(name, MAXPATHLEN); } else { + sprintf(name, "unknown"); zed_log_msg(LOG_INFO, "zfs_deliver_dle: no guid or physpath"); } |