diff options
| author | Rich Ercolani <[email protected]> | 2021-06-01 14:58:08 -0400 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-06-01 11:58:08 -0700 |
| commit | 3f81aba7668143c6ca6fc44983d4c880606dea8f (patch) | |
| tree | 4ae480f349476c956a4097670e9c2e47ddadf1d7 | |
| parent | f7d7ee0583819f3c380866affb31fd6f828cb50d (diff) | |
Remove iov_iter_advance() for iter_write
The additional iter advance is incorrect, as copy_from_iter() has
already done the right thing. This will result in the following
warning being printed to the console as of the 5.12 kernel.
Attempted to advance past end of bvec iter
This change should have been included with #11378 when a
similar change was made on the read side.
Suggested-by: @siebenmann
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Issue #11378
Closes #12041
Closes #12155
| -rw-r--r-- | module/os/linux/zfs/zpl_file.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/module/os/linux/zfs/zpl_file.c b/module/os/linux/zfs/zpl_file.c index 421aebefe..524c43dcd 100644 --- a/module/os/linux/zfs/zpl_file.c +++ b/module/os/linux/zfs/zpl_file.c @@ -342,9 +342,6 @@ zpl_iter_write(struct kiocb *kiocb, struct iov_iter *from) ssize_t wrote = count - uio.uio_resid; kiocb->ki_pos += wrote; - if (wrote > 0) - iov_iter_advance(from, wrote); - return (wrote); } |