diff options
| author | tuxoko <[email protected]> | 2016-10-24 16:41:56 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2016-10-24 16:41:56 -0700 |
| commit | 9fa4db44b76716352b994abd7668bc9565466f7f (patch) | |
| tree | 77c816f01457064914e90357f83c7134dd117e0c | |
| parent | 66392d81f5ba103fc89cd7bb3b99bea76a650d45 (diff) | |
Fix cred leak in zpl_fallocate_common
This is caught by kmemleak when running compress_004_pos
Reviewed-by: Tim Chase <[email protected]>
Reviewed by: Brian Behlendorf <[email protected]>
Signed-off-by: Chunwei Chen <[email protected]>
Closes #5244
Closes #5330
| -rw-r--r-- | module/zfs/zpl_file.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/module/zfs/zpl_file.c b/module/zfs/zpl_file.c index c8ac7f8a3..2c84d700d 100644 --- a/module/zfs/zpl_file.c +++ b/module/zfs/zpl_file.c @@ -650,8 +650,6 @@ zpl_fallocate_common(struct inode *ip, int mode, loff_t offset, loff_t len) if (mode != (FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE)) return (error); - crhold(cr); - if (offset < 0 || len <= 0) return (-EINVAL); @@ -670,6 +668,7 @@ zpl_fallocate_common(struct inode *ip, int mode, loff_t offset, loff_t len) bf.l_len = len; bf.l_pid = 0; + crhold(cr); cookie = spl_fstrans_mark(); error = -zfs_space(ip, F_FREESP, &bf, FWRITE, offset, cr); spl_fstrans_unmark(cookie); |