diff options
| author | George Melikov <[email protected]> | 2017-01-12 22:25:27 +0300 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2017-01-12 11:25:27 -0800 |
| commit | 5727b00e06a4208a7040489d582f13bc3c183384 (patch) | |
| tree | dc09e086112964dee8b1b305fb7eef357781e2e5 | |
| parent | e9aa730c49b91694b146e0cd28192f1aaf843d0e (diff) | |
OpenZFS 6637 - replacing "dontclose" with "should_close"
Authored by: David Schwartz <[email protected]>
Reviewed by: Matthew Ahrens <[email protected]>
Reviewed by: Prakash Surya <[email protected]>
Approved by: Robert Mustacchi <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Giuseppe Di Natale <[email protected]>
Ported-by: George Melikov <[email protected]>
I find that this is a lot easier to read. "not don't close" is somewhat tough on the eyes.
OpenZFS-issue: https://www.illumos.org/issues/6637
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/d189620
Closes #5572
| -rw-r--r-- | cmd/zfs/zfs_iter.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/cmd/zfs/zfs_iter.c b/cmd/zfs/zfs_iter.c index e7f162290..aeb98ab64 100644 --- a/cmd/zfs/zfs_iter.c +++ b/cmd/zfs/zfs_iter.c @@ -92,7 +92,7 @@ static int zfs_callback(zfs_handle_t *zhp, void *data) { callback_data_t *cb = data; - boolean_t dontclose = B_FALSE; + boolean_t should_close = B_TRUE; boolean_t include_snaps = zfs_include_snapshots(zhp, cb); boolean_t include_bmarks = (cb->cb_types & ZFS_TYPE_BOOKMARK); @@ -120,7 +120,7 @@ zfs_callback(zfs_handle_t *zhp, void *data) } } uu_avl_insert(cb->cb_avl, node, idx); - dontclose = B_TRUE; + should_close = B_FALSE; } else { free(node); } @@ -146,7 +146,7 @@ zfs_callback(zfs_handle_t *zhp, void *data) cb->cb_depth--; } - if (!dontclose) + if (should_close) zfs_close(zhp); return (0); |