diff options
author | Damian Szuberski <[email protected]> | 2022-02-03 23:35:38 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2022-02-03 14:35:38 -0800 |
commit | 63652e154643cfe596fe077c13de0e7be34dd863 (patch) | |
tree | a357fcff504f2b8fbdce59b236788435556b45f8 /.github | |
parent | aa9905d89b3559e1cd280d018615d392f57a18d0 (diff) |
Add `--enable-asan` and `--enable-ubsan` switches
`configure` now accepts `--enable-asan` and `--enable-ubsan` switches
which results in passing `-fsanitize=address`
and `-fsanitize=undefined`, respectively, to the compiler. Those
flags are enabled in GitHub workflows for ZTS and zloop. Errors
reported by both instrumentations are corrected, except for:
- Memory leak reporting is (temporarily) suppressed. The cost of
fixing them is relatively high compared to the gains.
- Checksum computing functions in `module/zcommon/zfs_fletcher*`
have UBSan errors suppressed. It is completely impractical
to enforce 64-byte payload alignment there due to performance
impact.
- There's no ASan heap poisoning in `module/zstd/lib/zstd.c`. A custom
memory allocator is used there rendering that measure
unfeasible.
- Memory leaks detection has to be suppressed for `cmd/zvol_id`.
`zvol_id` is run by udev with the help of `ptrace(2)`. Tracing is
incompatible with memory leaks detection.
Reviewed-by: Ahelenia ZiemiaĆska <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes #12928
Diffstat (limited to '.github')
-rw-r--r-- | .github/workflows/zfs-tests-functional.yml | 2 | ||||
-rw-r--r-- | .github/workflows/zfs-tests-sanity.yml | 2 | ||||
-rw-r--r-- | .github/workflows/zloop.yml | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/.github/workflows/zfs-tests-functional.yml b/.github/workflows/zfs-tests-functional.yml index 40d03d25d..ba3b2e11c 100644 --- a/.github/workflows/zfs-tests-functional.yml +++ b/.github/workflows/zfs-tests-functional.yml @@ -32,7 +32,7 @@ jobs: sh autogen.sh - name: Configure run: | - ./configure --enable-debug --enable-debuginfo + ./configure --enable-debug --enable-debuginfo --enable-asan --enable-ubsan - name: Make run: | make --no-print-directory -s pkg-utils pkg-kmod diff --git a/.github/workflows/zfs-tests-sanity.yml b/.github/workflows/zfs-tests-sanity.yml index d1dc0e88c..abe7974dd 100644 --- a/.github/workflows/zfs-tests-sanity.yml +++ b/.github/workflows/zfs-tests-sanity.yml @@ -28,7 +28,7 @@ jobs: sh autogen.sh - name: Configure run: | - ./configure --enable-debug --enable-debuginfo + ./configure --enable-debug --enable-debuginfo --enable-asan --enable-ubsan - name: Make run: | make --no-print-directory -s pkg-utils pkg-kmod diff --git a/.github/workflows/zloop.yml b/.github/workflows/zloop.yml index 5c1b9bd1c..0638bbe58 100644 --- a/.github/workflows/zloop.yml +++ b/.github/workflows/zloop.yml @@ -28,7 +28,7 @@ jobs: sh autogen.sh - name: Configure run: | - ./configure --enable-debug --enable-debuginfo + ./configure --enable-debug --enable-debuginfo --enable-asan --enable-ubsan - name: Make run: | make --no-print-directory -s pkg-utils pkg-kmod |