diff options
author | Alexander Motin <[email protected]> | 2021-07-13 11:41:59 -0400 |
---|---|---|
committer | Tony Hutter <[email protected]> | 2021-09-14 12:38:05 -0700 |
commit | 45305a067ff42da0591e221e89e55f6adda406c7 (patch) | |
tree | be2db58dedcdfd161f0b57486515392a7e12e6eb /.github | |
parent | a5e68f047899b31b3f4a99b930731fd655f45db2 (diff) |
Fix ARC ghost states eviction accounting
arc_evict_hdr() returns number of evicted bytes in scope of specific
state. For ghost states it does not mean the amount of really freed
memory, but the logical buffer size. It is correct for the eviction
process, but not for waking up threads waiting for ARC size reduction,
as added in "Revise ARC shrinker algorithm" commit, causing premature
wakeups while ARC is still overflowed, allowing even bigger overflow,
plus processing overhead when next allocation will also get blocked,
probably also for too short time.
To fix that make arc_evict_hdr() also return the amount of really
freed memory, which for the ghost states is only the header, and use
it to update arc_evict_count instead. Originally I was thinking to
not return it at all, since arc_get_data_impl() does not account for
the headers, but decided that some slow allocation progress is better
than long waits, reaching on my tests up to 100ms.
To reduce negative latency effects of long time periods when reclaim
thread can free little real memory, start reclamation process earlier,
before we actually reached the overflow threshold, when we have to
throttle new allocations. We can also do it without taking global
arc_evict_lock, reducing the contention.
Reviewed-by: George Wilson <[email protected]>
Reviewed-by: Allan Jude <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Closes #12279
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions