diff options
| author | Kjeld Schouten-Lebbing <[email protected]> | 2019-12-30 18:24:41 +0100 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2019-12-30 09:24:41 -0800 |
| commit | 82e996c2616af6254002065398de7cfb6929c4fd (patch) | |
| tree | 89979d0463fe4d5140bde4b6883f49aa23bbe7a2 /.github/PULL_REQUEST_TEMPLATE.md | |
| parent | 8b3438e5034c192c652eafe3180464a57a839174 (diff) | |
Improve Pull Request guidelines
- Splits PR advice into two sections.
- Add "co-authored-by" instructions.
- Add description of draft PR and when using it is appropriate.
- Reword ZFS Test Suite checklist question.
- Link to zfs-tests.sh and zloop.sh.
Reviewed-By: Marcel Schilling <[email protected]>
Reviewed-By: Brian Behlendorf <[email protected]>
Reviewed-By: Richard Laager <[email protected]>
Co-Authored-By: Marcel Schilling <[email protected]>
Co-Authored-By: Brian Behlendorf <[email protected]>
Co-Authored-By: Richard Laager <[email protected]>
Signed-off-by: Kjeld Schouten-Lebbing <[email protected]>
Closes #9753
Diffstat (limited to '.github/PULL_REQUEST_TEMPLATE.md')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 699ca9078..9b75a48f0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -19,6 +19,7 @@ https://github.com/zfsonlinux/zfs/wiki/Buildbot-Options <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> <!--- If your change is a performance enhancement, please provide benchmarks here. --> +<!--- Please think about using the draft PR feature if appropriate --> ### Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> @@ -36,5 +37,5 @@ https://github.com/zfsonlinux/zfs/wiki/Buildbot-Options - [ ] I have updated the documentation accordingly. - [ ] I have read the [**contributing** document](https://github.com/zfsonlinux/zfs/blob/master/.github/CONTRIBUTING.md). - [ ] I have added [tests](https://github.com/zfsonlinux/zfs/tree/master/tests) to cover my changes. -- [ ] All new and existing tests passed. +- [ ] I have run the ZFS Test Suite with this change applied. - [ ] All commit messages are properly formatted and contain [`Signed-off-by`](https://github.com/zfsonlinux/zfs/blob/master/.github/CONTRIBUTING.md#signed-off-by). |