aboutsummaryrefslogtreecommitdiffstats
path: root/.github/PULL_REQUEST_TEMPLATE.md
diff options
context:
space:
mode:
authorĐoàn Trần Công Danh <[email protected]>2020-11-29 02:02:08 +0700
committerGitHub <[email protected]>2020-11-28 11:02:08 -0800
commit16692e6ba0bc3b0b6e7d64a68e91ded9f2d0959e (patch)
tree9f06b307d2ffb072e17f66cb56b12a072bf07fae /.github/PULL_REQUEST_TEMPLATE.md
parent04a82e043d067181a8b352921ef6a3c3ac875b59 (diff)
dracut: use /bin/sh instead of bash as the intepreter
Despite that dracut has a hard dependency on bash, its modules doesn't, dracut only has a hard dependency on bash for module-setup (on a fully usable machine). Inside initramfs, dracut allows users choose from a list of handful other shells, e.g. bash, busybox, dash, mkfsh. In fact, my local machine's initramfs is being built with dash, and it's functional for a very long time. Before 64025fa3a (Silence 'make checkbashisms', 2020-08-20), we also allows our users to have that right, too. Let's fix the problem 'make checkbashisms' reported and allows our users to have that right, again. For 'plymouth' case, let's simply run the command inside the if instead of checking for the existence of command before running it, because the status is also failture if plymouth is unavailable. While we're at it, let's remove an unnecessary fork for grep in zfs-generator.sh.in and its following complicated 'if elif fi' with a simple 'case ... esac'. To support this change, also exclude 90zfs from "make checkbashisms" because the current CI infrastructure ships an old version of "checkbashisms", which complains about "command -v", while the current latest "checkbashisms" thinks it's fine. In the near future, we can revert that change to "Makefile.am" when CI infrastructure is updated. Reviewed-by: Gabriel A. Devenyi <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Đoàn Trần Công Danh <[email protected]> Closes #11244
Diffstat (limited to '.github/PULL_REQUEST_TEMPLATE.md')
0 files changed, 0 insertions, 0 deletions