From 9168e7a65deefae7bb8a40c583c205c408cbecab Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Tue, 11 Feb 2020 15:58:18 -0500 Subject: pan/midgard: Improve barrier disassembly Just move some state from unknowns to actual keywords. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/midgard/midgard.h | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) (limited to 'src/panfrost/midgard/midgard.h') diff --git a/src/panfrost/midgard/midgard.h b/src/panfrost/midgard/midgard.h index 0f6ec698d8a..c022d47aabe 100644 --- a/src/panfrost/midgard/midgard.h +++ b/src/panfrost/midgard/midgard.h @@ -693,9 +693,14 @@ __attribute__((__packed__)) midgard_outmod_float outmod : 2; unsigned swizzle : 8; - unsigned unknown4 : 8; - unsigned unknownA : 4; + /* For barriers, control barriers are implied regardless, but these + * bits also enable memory barriers of various types. For regular + * textures, these bits are not yet understood. */ + unsigned barrier_buffer : 1; + unsigned barrier_shared : 1; + + unsigned unknown4 : 10; /* In immediate mode, each offset field is an immediate range [0, 7]. * @@ -765,8 +770,9 @@ __attribute__((__packed__)) unsigned zero2 : 14; unsigned zero3 : 24; - unsigned unknown4 : 1; - unsigned zero4 : 7; + unsigned buffer : 1; + unsigned shared : 1; + unsigned zero4 : 6; uint64_t zero5; } midgard_texture_barrier_word; -- cgit v1.2.3