From cfc7ed75eb8baab69308ed520f97a3efd75fb548 Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Thu, 28 Sep 2017 19:04:31 -0700 Subject: i965: Store image_param in brw_context instead of prog_data This burns an extra 10k of memory or so in the case where you don't have any images. However, if you have several shaders which use images, this should be much less memory. It also gets rid of a part of prog_data that really has nothing to do with the compiler. Reviewed-by: Jordan Justen Reviewed-by: Kenneth Graunke --- src/intel/vulkan/anv_pipeline_cache.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/intel/vulkan/anv_pipeline_cache.c') diff --git a/src/intel/vulkan/anv_pipeline_cache.c b/src/intel/vulkan/anv_pipeline_cache.c index f782d04fbe6..ad9c810f1f4 100644 --- a/src/intel/vulkan/anv_pipeline_cache.c +++ b/src/intel/vulkan/anv_pipeline_cache.c @@ -37,7 +37,7 @@ anv_shader_bin_create(struct anv_device *device, struct anv_shader_bin *shader; struct anv_shader_bin_key *key; struct brw_stage_prog_data *prog_data; - const union gl_constant_value **prog_data_param; + uint32_t *prog_data_param; struct anv_pipeline_binding *surface_to_descriptor, *sampler_to_descriptor; ANV_MULTIALLOC(ma); @@ -169,9 +169,7 @@ anv_shader_bin_create_from_blob(struct anv_device *device, * * - Review prog_data struct for size and cacheability: struct * brw_stage_prog_data has binding_table which uses a lot of uint32_t for 8 - * bit quantities etc; param, pull_param, and image_params are pointers, we - * just need the compation map. use bit fields for all bools, eg - * dual_src_blend. + * bit quantities etc; use bit fields for all bools, eg dual_src_blend. */ static uint32_t -- cgit v1.2.3