From 378025ca8b82c5f2068e202f1016450d97820d99 Mon Sep 17 00:00:00 2001 From: Daniel Stone Date: Thu, 23 Mar 2017 15:09:49 +0000 Subject: gbm: Use unsigned for BO offset getter The actual offset returned is uint32_t, however int64_t was used as the return type from gbm_bo_get_offset to allow negative returns to signal errors to the caller. In case of an error getting the offset, the user will also be unable to get the handle/FD, and thus have nothing to offset into. This means that returning 0 as an error value is harmless, allowing us to change the return type to uint32_t in order to avoid signed/unsigned confusion in callers. Signed-off-by: Daniel Stone Cc: Ben Widawsky Cc: Jason Ekstrand --- src/gbm/main/gbmint.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/gbm/main/gbmint.h') diff --git a/src/gbm/main/gbmint.h b/src/gbm/main/gbmint.h index 5ad85cc80ff..c27a7a560ae 100644 --- a/src/gbm/main/gbmint.h +++ b/src/gbm/main/gbmint.h @@ -81,7 +81,7 @@ struct gbm_device { int (*bo_get_planes)(struct gbm_bo *bo); union gbm_bo_handle (*bo_get_handle)(struct gbm_bo *bo, int plane); uint32_t (*bo_get_stride)(struct gbm_bo *bo, int plane); - int64_t (*bo_get_offset)(struct gbm_bo *bo, int plane); + uint32_t (*bo_get_offset)(struct gbm_bo *bo, int plane); uint64_t (*bo_get_modifier)(struct gbm_bo *bo); void (*bo_destroy)(struct gbm_bo *bo); -- cgit v1.2.3