From e7cdcefbee6c8bffdc421f38d97578180e7991b5 Mon Sep 17 00:00:00 2001 From: Jakob Bornecrantz Date: Sun, 20 Feb 2011 13:58:11 +0100 Subject: i915g: TODO about untested code hidden behind caps Should be fairly easy to test and fix since you can look at the code in the classic driver. --- src/gallium/drivers/i915/TODO | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/gallium/drivers/i915/TODO') diff --git a/src/gallium/drivers/i915/TODO b/src/gallium/drivers/i915/TODO index 94c428bebf8..0becf31d9bc 100644 --- a/src/gallium/drivers/i915/TODO +++ b/src/gallium/drivers/i915/TODO @@ -1,5 +1,8 @@ Random list of problems with i915g: +- Check if PIPE_CAP_BLEND_EQUATION_SEPARATE and PIPE_CAP_TEXTURE_MIRROR_REPEAT + work, the code is there. If not fix it! A simple task, good for beginners. + - Dies with BadDrawable on GLXFBconfig changes/destruction. Makes piglit totally unusable :( Upgrading xserver helped here, it doesn't crash anymore. Still broken, it doesn't update the viewport/get new buffers. -- cgit v1.2.3 From a64176657602e9acc1b6c9a49ab26586f3a5c254 Mon Sep 17 00:00:00 2001 From: Jakob Bornecrantz Date: Sun, 20 Feb 2011 14:00:03 +0100 Subject: i915g: TODO about point sprites --- src/gallium/drivers/i915/TODO | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/gallium/drivers/i915/TODO') diff --git a/src/gallium/drivers/i915/TODO b/src/gallium/drivers/i915/TODO index 0becf31d9bc..eda5838a854 100644 --- a/src/gallium/drivers/i915/TODO +++ b/src/gallium/drivers/i915/TODO @@ -3,6 +3,9 @@ Random list of problems with i915g: - Check if PIPE_CAP_BLEND_EQUATION_SEPARATE and PIPE_CAP_TEXTURE_MIRROR_REPEAT work, the code is there. If not fix it! A simple task, good for beginners. +- Add support for PIPE_CAP_POINT_SPRITE either via the draw module or directly + via the hardware, look at the classic driver, more advanced. + - Dies with BadDrawable on GLXFBconfig changes/destruction. Makes piglit totally unusable :( Upgrading xserver helped here, it doesn't crash anymore. Still broken, it doesn't update the viewport/get new buffers. -- cgit v1.2.3 From fc77dee0bd6499177418be347bac875b12277053 Mon Sep 17 00:00:00 2001 From: Jakob Bornecrantz Date: Wed, 23 Feb 2011 00:11:09 +0000 Subject: i915g: Enable mirror repeat wrap mode --- src/gallium/drivers/i915/TODO | 4 ++-- src/gallium/drivers/i915/i915_screen.c | 2 +- src/gallium/drivers/i915/i915_state.c | 4 +--- 3 files changed, 4 insertions(+), 6 deletions(-) (limited to 'src/gallium/drivers/i915/TODO') diff --git a/src/gallium/drivers/i915/TODO b/src/gallium/drivers/i915/TODO index eda5838a854..fc644fe7f93 100644 --- a/src/gallium/drivers/i915/TODO +++ b/src/gallium/drivers/i915/TODO @@ -1,7 +1,7 @@ Random list of problems with i915g: -- Check if PIPE_CAP_BLEND_EQUATION_SEPARATE and PIPE_CAP_TEXTURE_MIRROR_REPEAT - work, the code is there. If not fix it! A simple task, good for beginners. +- Check if PIPE_CAP_BLEND_EQUATION_SEPARATE work, the code is there. + If not fix it! A simple task, good for beginners. - Add support for PIPE_CAP_POINT_SPRITE either via the draw module or directly via the hardware, look at the classic driver, more advanced. diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c index d929eb25bdc..77febbf5012 100644 --- a/src/gallium/drivers/i915/i915_screen.c +++ b/src/gallium/drivers/i915/i915_screen.c @@ -107,6 +107,7 @@ i915_get_param(struct pipe_screen *screen, enum pipe_cap cap) case PIPE_CAP_ANISOTROPIC_FILTER: case PIPE_CAP_NPOT_TEXTURES: case PIPE_CAP_PRIMITIVE_RESTART: /* draw module */ + case PIPE_CAP_TEXTURE_MIRROR_REPEAT: case PIPE_CAP_TEXTURE_SHADOW_MAP: case PIPE_CAP_TWO_SIDED_STENCIL: return 1; @@ -114,7 +115,6 @@ i915_get_param(struct pipe_screen *screen, enum pipe_cap cap) /* Features that should be supported (boolean caps). */ /* XXX: Just test the code */ case PIPE_CAP_BLEND_EQUATION_SEPARATE: - case PIPE_CAP_TEXTURE_MIRROR_REPEAT: return 0; /* Unsupported features (boolean caps). */ diff --git a/src/gallium/drivers/i915/i915_state.c b/src/gallium/drivers/i915/i915_state.c index f380708847b..58bbbd1de2c 100644 --- a/src/gallium/drivers/i915/i915_state.c +++ b/src/gallium/drivers/i915/i915_state.c @@ -58,10 +58,8 @@ translate_wrap_mode(unsigned wrap) return TEXCOORDMODE_CLAMP_EDGE; case PIPE_TEX_WRAP_CLAMP_TO_BORDER: return TEXCOORDMODE_CLAMP_BORDER; - /* - case PIPE_TEX_WRAP_MIRRORED_REPEAT: + case PIPE_TEX_WRAP_MIRROR_REPEAT: return TEXCOORDMODE_MIRROR; - */ default: return TEXCOORDMODE_WRAP; } -- cgit v1.2.3 From 69cfc16cb670804b272e88abac5ed3856bb70fa8 Mon Sep 17 00:00:00 2001 From: Jakob Bornecrantz Date: Tue, 22 Feb 2011 22:07:03 +0000 Subject: i915g: Disable LIS7 state updates for now --- src/gallium/drivers/i915/TODO | 2 ++ src/gallium/drivers/i915/i915_state_immediate.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) (limited to 'src/gallium/drivers/i915/TODO') diff --git a/src/gallium/drivers/i915/TODO b/src/gallium/drivers/i915/TODO index fc644fe7f93..f4e1423fa59 100644 --- a/src/gallium/drivers/i915/TODO +++ b/src/gallium/drivers/i915/TODO @@ -6,6 +6,8 @@ Random list of problems with i915g: - Add support for PIPE_CAP_POINT_SPRITE either via the draw module or directly via the hardware, look at the classic driver, more advanced. +- What does this button do? Figure out LIS7 with regards to depth offset. + - Dies with BadDrawable on GLXFBconfig changes/destruction. Makes piglit totally unusable :( Upgrading xserver helped here, it doesn't crash anymore. Still broken, it doesn't update the viewport/get new buffers. diff --git a/src/gallium/drivers/i915/i915_state_immediate.c b/src/gallium/drivers/i915/i915_state_immediate.c index 00dcf9cb2d0..3dd227f6045 100644 --- a/src/gallium/drivers/i915/i915_state_immediate.c +++ b/src/gallium/drivers/i915/i915_state_immediate.c @@ -130,7 +130,7 @@ static void upload_S5(struct i915_context *i915) #if 0 /* I915_NEW_RASTERIZER */ - if (i915->state.Polygon->OffsetFill) { + if (i915->rasterizer->LIS7) { LIS5 |= S5_GLOBAL_DEPTH_OFFSET_ENABLE; } #endif @@ -192,10 +192,12 @@ static void upload_S7(struct i915_context *i915) */ LIS7 = i915->rasterizer->LIS7; +#if 0 if (LIS7 != i915->current.immediate[I915_IMMEDIATE_S7]) { i915->current.immediate[I915_IMMEDIATE_S7] = LIS7; i915->hardware_dirty |= I915_HW_IMMEDIATE; } +#endif } const struct i915_tracked_state i915_upload_S7 = { -- cgit v1.2.3