From 1ffe77e7bb2486ea74cda077ed2a9622b758395c Mon Sep 17 00:00:00 2001 From: Marek Olšák Date: Sat, 16 Jul 2016 21:19:48 +0200 Subject: gallium: split transfer_inline_write into buffer and texture callbacks MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit to reduce the call indirections with u_resource_vtbl. The worst call tree you could get was: - u_transfer_inline_write_vtbl - u_default_transfer_inline_write - u_transfer_map_vtbl - driver_transfer_map - u_transfer_unmap_vtbl - driver_transfer_unmap That's 6 indirect calls. Some drivers only had 5. The goal is to have 1 indirect call for drivers that care. The resource type can be determined statically at most call sites. The new interface is: pipe_context::buffer_subdata(ctx, resource, usage, offset, size, data) pipe_context::texture_subdata(ctx, resource, level, usage, box, data, stride, layer_stride) v2: fix whitespace, correct ilo's behavior Reviewed-by: Nicolai Hähnle Acked-by: Roland Scheidegger --- src/gallium/docs/source/context.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/gallium/docs/source/context.rst') diff --git a/src/gallium/docs/source/context.rst b/src/gallium/docs/source/context.rst index 8fb621bcac3..e646ea02f78 100644 --- a/src/gallium/docs/source/context.rst +++ b/src/gallium/docs/source/context.rst @@ -538,8 +538,9 @@ to the transfer object remains unchanged (i.e. it can be non-NULL). the transfer object. The pointer into the resource should be considered invalid and discarded. -``transfer_inline_write`` performs a simplified transfer for simple writes. -Basically transfer_map, data write, and transfer_unmap all in one. +``texture_subdata`` and ``buffer_subdata`` perform a simplified +transfer for simple writes. Basically transfer_map, data write, and +transfer_unmap all in one. The box parameter to some of these functions defines a 1D, 2D or 3D -- cgit v1.2.3