From cca1e9606c1fa05dafb994d2d1d92a9b2a35c5c2 Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Thu, 13 Dec 2018 13:50:50 -0500 Subject: freedreno/ir3: don't remove unused input components Fixes: 0d240c22141 freedreno/ir3: don't fetch unused tex components Signed-off-by: Rob Clark --- src/freedreno/ir3/ir3_depth.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'src/freedreno/ir3/ir3_depth.c') diff --git a/src/freedreno/ir3/ir3_depth.c b/src/freedreno/ir3/ir3_depth.c index 4e377fa4ee5..e0500b43161 100644 --- a/src/freedreno/ir3/ir3_depth.c +++ b/src/freedreno/ir3/ir3_depth.c @@ -176,7 +176,13 @@ remove_unused_by_block(struct ir3_block *block) if (instr->flags & IR3_INSTR_UNUSED) { if (instr->opc == OPC_META_FO) { struct ir3_instruction *src = ssa(instr->regs[1]); - if (src->regs[0]->wrmask > 1) { + /* leave inputs alone.. we can't optimize out components of + * an input, since the hw is still going to be writing all + * of the components, and we could end up in a situation + * where multiple inputs overlap. + */ + if ((src->opc != OPC_META_INPUT) && + (src->regs[0]->wrmask > 1)) { src->regs[0]->wrmask &= ~(1 << instr->fo.off); /* prune no-longer needed right-neighbors. We could -- cgit v1.2.3