From e99df398f1ee5aee12a8fc1bc52199df1d0f260a Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Fri, 10 Feb 2017 20:56:38 -0800 Subject: glsl: Update a comment about link errors for TCS && !TES. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit OpenGL ES actually has spec text to prohibit this. It's just OpenGL that's confusing. Signed-off-by: Kenneth Graunke Reviewed-by: Alejandro Piñeiro --- src/compiler/glsl/linker.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'src/compiler') diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 720c22baee0..4c7bf282ce1 100644 --- a/src/compiler/glsl/linker.cpp +++ b/src/compiler/glsl/linker.cpp @@ -4721,7 +4721,15 @@ link_shaders(struct gl_context *ctx, struct gl_shader_program *prog) goto done; } - /* The spec is self-contradictory here. It allows linking without a tess + /* Section 7.3 of the OpenGL ES 3.2 specification says: + * + * "Linking can fail for [...] any of the following reasons: + * + * * program contains an object to form a tessellation control + * shader [...] and [...] the program is not separable and + * contains no object to form a tessellation evaluation shader" + * + * The OpenGL spec is contradictory. It allows linking without a tess * eval shader, but that can only be used with transform feedback and * rasterization disabled. However, transform feedback isn't allowed * with GL_PATCHES, so it can't be used. -- cgit v1.2.3