From f2dc0f28728af63e1a79756dab06a7035fecb590 Mon Sep 17 00:00:00 2001 From: Jason Ekstrand <jason@jlekstrand.net> Date: Mon, 6 May 2019 11:45:46 -0500 Subject: nir: Drop imov/fmov in favor of one mov instruction The difference between imov and fmov has been a constant source of confusion in NIR for years. No one really knows why we have two or when to use one vs. the other. The real reason is that they do different things in the presence of source and destination modifiers. However, without modifiers (which many back-ends don't have), they are identical. Now that we've reworked nir_lower_to_source_mods to leave one abs/neg instruction in place rather than replacing them with imov or fmov instructions, we don't need two different instructions at all anymore. Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com> Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com> Acked-by: Rob Clark <robdclark@chromium.org> --- src/compiler/spirv/vtn_alu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/compiler/spirv/vtn_alu.c') diff --git a/src/compiler/spirv/vtn_alu.c b/src/compiler/spirv/vtn_alu.c index 8f53a7c03e4..f7fb82774bd 100644 --- a/src/compiler/spirv/vtn_alu.c +++ b/src/compiler/spirv/vtn_alu.c @@ -410,7 +410,7 @@ vtn_handle_alu(struct vtn_builder *b, SpvOp opcode, switch (opcode) { case SpvOpAny: if (src[0]->num_components == 1) { - val->ssa->def = nir_imov(&b->nb, src[0]); + val->ssa->def = nir_mov(&b->nb, src[0]); } else { nir_op op; switch (src[0]->num_components) { @@ -427,7 +427,7 @@ vtn_handle_alu(struct vtn_builder *b, SpvOp opcode, case SpvOpAll: if (src[0]->num_components == 1) { - val->ssa->def = nir_imov(&b->nb, src[0]); + val->ssa->def = nir_mov(&b->nb, src[0]); } else { nir_op op; switch (src[0]->num_components) { -- cgit v1.2.3