From a0add0446ca9dce6d4a96014c42ba6cf3a73a44a Mon Sep 17 00:00:00 2001 From: José Fonseca Date: Sun, 17 Oct 2010 09:58:04 -0700 Subject: llvmpipe: Fix bad refactoring. 'i' and 'chan' have random values here, which could cause a buffer overflow in debug builds, if chan > 4. --- src/gallium/drivers/llvmpipe/lp_state_fs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c b/src/gallium/drivers/llvmpipe/lp_state_fs.c index c070b55d3d1..7acbe7e86c3 100644 --- a/src/gallium/drivers/llvmpipe/lp_state_fs.c +++ b/src/gallium/drivers/llvmpipe/lp_state_fs.c @@ -365,8 +365,7 @@ generate_fs(struct llvmpipe_context *lp, 0); if (pos0 != -1 && outputs[pos0][2]) { - z = LLVMBuildLoad(builder, outputs[pos0][2], "z"); - lp_build_name(z, "output%u.%u.%c", i, pos0, "xyzw"[chan]); + z = LLVMBuildLoad(builder, outputs[pos0][2], "output.z"); } lp_build_depth_stencil_test(builder, -- cgit v1.2.3