summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* iris: Assert about blits with color maskingKenneth Graunke2019-02-211-0/+4
| | | | | st/mesa never asks for this today, but in theory someone might, and we don't support it.
* iris: Don't enable smooth points when point sprites are enabledKenneth Graunke2019-02-211-4/+3
| | | | dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_*.primitives.points
* iris: Allow sample mask of 0Kenneth Graunke2019-02-211-1/+1
| | | | | | | | I think this was an attempt to work around various sample mask bugs I had early on. It's not correct. A sample mask of 0 is legal and means to disable all samples. Fixes dEQP-GLES31.functional.texture.multisample.*.*sample_mask*
* iris: fail to create screen for older unsupported HWKenneth Graunke2019-02-211-0/+3
| | | | loader shouldn't try, but let's be paranoid
* iris: Switch to the new PIPELINE_STATISTICS_QUERY_SINGLE capabilityKenneth Graunke2019-02-212-44/+6
| | | | | | | I had a hack in place earlier to pass the query type as q->index for the regular statistics query, but we ended up adjusting the interface and adding a new query type. Use that instead, fixing pipeline statistics queries since the rebase.
* iris: Use new PIPE_STAT_QUERY enums rather than hardcoded numbers.Kenneth Graunke2019-02-211-2/+5
|
* iris: Fix Broadwell WaDividePSInvocationCountBy4Kenneth Graunke2019-02-211-7/+7
| | | | | | | | | | We were dividing by 4 in calculate_result_on_gpu(), and also in iris_get_query_result(). We should stop doing the latter, and instead divide by 4 in calculate_result_on_cpu() as well. Otherwise, if snapshots were available, and you hit the calculate_result_on_cpu() path, but requested it be written to a QBO, you'd fail to get a divide.
* iris: Delete genx->bound_vertex_buffersKenneth Graunke2019-02-211-3/+0
| | | | This is actually stored in ice->state, as it isn't gen-specific
* iris: Drop a dead commentKenneth Graunke2019-02-211-2/+0
|
* iris: Don't check other batches for our batch BOKenneth Graunke2019-02-211-25/+27
| | | | | | | | | | This is an awkward corner case. We create batches in order, each of which creates and pins a BO. The other batches may not be set up yet, so it may not be safe to ask whether they reference a BO. Just avoid this for now. We could avoid it for other context-local BOs too, but we currently don't have a flag for that (and I'm not certain whether it's worth it).
* iris: Handle PIPE_TRANSFER_DISCARD_WHOLE_RESOURCE somewhatKenneth Graunke2019-02-211-3/+6
| | | | | | | | | | | | Various places in the transfer code need to know whether they must read the existing resource's values. Rather than checking both flags everywhere, just make PIPE_TRANSFER_DISCARD_WHOLE_RESOURCE also flag PIPE_TRANSFER_DISCARD_RANGE - if we can discard everything, we can discard a subrange, too. Obviously, we can do better for PIPE_TRANSFER_DISCARD_WHOLE_RESOURCE, but eventually u_threaded_context should handle swapping out buffers for new idle buffers, anyway. In the meantime, this is at least better.
* iris: Flush the render cache in flush_and_dirty_for_historyKenneth Graunke2019-02-211-0/+7
| | | | | | | BLORP uses the render engine to write to buffers, and we need to flush that data out to the actual surface (finishing the write). Then, the rest of this function invalidates any caches that might have stale data which needs to be refetched.
* iris: Implement multi-slice copy_regionKenneth Graunke2019-02-211-11/+9
| | | | | | I don't know if this is required - surprisingly, I haven't seen it matter - but I'd like to use it for multi-slice transfer maps. We may as well do the right thing.
* iris: Leave a comment about why Broadwell images are brokenKenneth Graunke2019-02-211-0/+4
| | | | | | There are a variety of ways to fix this, many of which are simple, but I could use some advice on which ones other people prefer, and so we'll punt until after the holidays.
* iris: Fix surface states for Gen8 lowered-to-untype imagesKenneth Graunke2019-02-211-7/+26
| | | | We have to use SURFTYPE_BUFFER and ISL_FORMAT_RAW for these.
* iris: Fill out brw_image_params for storage images on BroadwellKenneth Graunke2019-02-213-9/+138
|
* iris: Don't make duplicate system valuesKenneth Graunke2019-02-212-7/+23
| | | | | | | We were relying on CSE/GVN/etc to coalesce all intrinsics that load the same value, but that's a bad idea. We might have a couple intrinsics that reload the same value. If so, we only want to set up the uniform on the first one we see.
* iris: Don't enable push constants just because there are system valuesKenneth Graunke2019-02-211-2/+1
| | | | | | | | | | | | System values are built-in uniforms. We set them up as UBO values, and might pull or push them. UBO push analysis will take care of that. We only want to enable push constants if there's an actual range being pushed. Otherwise, we might get into a scenario where 3DSTATE_PS enables push constants but 3DSTATE_CONSTANT_PS isn't pushing anything. This fixes GPU hangs in Broadwell image load store tests which have unused image param system values but no other uniforms. (We shouldn't be making those anyway, but that's a separate fix...)
* iris: Fix framebuffer layer countKenneth Graunke2019-02-211-1/+3
| | | | | | | | | | cso_fb->layers is only valid for no-attachment framebuffers. Use the helper function to get the real value, then stash it so we don't have to call the helper function on the old value for comparison, or at draw time for Force Zero RTA Index setting. This fixes Force Zero RTA Index being set even when attempting layered rendering.
* iris: handle qbo fragment shader invocation workaroundDave Airlie2019-02-211-0/+52
|
* iris: add fs invocations query workaround for broadwellDave Airlie2019-02-211-0/+6
|
* iris: setup gen8 capsDave Airlie2019-02-211-4/+4
|
* iris: limit gen8 to 8 samplesDave Airlie2019-02-211-1/+2
|
* iris/WIP: add broadwell supportDave Airlie2019-02-215-11/+58
| | | | This adds all the state changes, MOCS changes,
* iris: Delete bogus comment about cube array counting.Kenneth Graunke2019-02-211-5/+1
| | | | | | | | | Both 'z' and 'depth' are counted in slices, according to the Gallium docs (context.rst). In our temporary memory, we allocate `box.depth` slices, so we need to rebase the starting slice (box.z) down to 0, and back again when writing on unmap. There's nothing strange about cubes here.
* iris: Fix compute scratch pinningKenneth Graunke2019-02-211-2/+1
| | | | Thanks to Eero Tamminen for helping catch this.
* iris: Add a more long term TODO about timebase scalingKenneth Graunke2019-02-211-0/+6
|
* iris: Only resolve inputs for actual shader stagesKenneth Graunke2019-02-213-12/+11
| | | | | We don't need to consider compute at render time, and don't need to consider disabled stages. 4% on drawoverhead.
* iris: Fix assertion in iris_resource_from_handle() tiling usageRhys Kidd2019-02-211-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Assertion error: iris_resource_from_handle: Assertion `res->bo->tiling_mode == isl_tiling_to_i915_tiling(res->surf.tiling)' failed. This patch fixes 16 piglit tests on KBL: glx/glx-multithread-texture glx/glx-query-drawable-glx_fbconfig_id-glxpbuffer glx/glx-query-drawable-glx_fbconfig_id-glxpixmap glx/glx-query-drawable-glx_preserved_contents glx/glx-query-drawable-glxpbuffer-glx_height glx/glx-query-drawable-glxpbuffer-glx_width glx/glx-query-drawable-glxpixmap-glx_height glx/glx-query-drawable-glxpixmap-glx_width glx/glx-swap-pixmap glx/glx-swap-pixmap-bad glx/glx-tfp glx/glx-visuals-depth -pixmap glx/glx-visuals-stencil -pixmap spec/egl 1.4/eglcreatepbuffersurface and then glclear spec/egl 1.4/largest possible eglcreatepbuffersurface and then glclear spec/egl_nok_texture_from_pixmap/basic Cc: Kenneth Graunke <[email protected]> Cc: Jason Ekstrand <[email protected]> Signed-off-by: Rhys Kidd <[email protected]>
* iris: Fix scratch space allocation on Icelake.Kenneth Graunke2019-02-211-4/+8
| | | | | | | | | Gen9-10 have fewer than 4 subslices per slice, so they need this to be rounded up. Gen11 isn't documented as needing this hack, and it can also have more than 4 subslices, so the hack actually can break things. Fixes tests/spec/arb_enhanced_layouts/execution/component-layout/ sso-vs-gs-fs-array-interleave
* iris: better MOCSKenneth Graunke2019-02-212-26/+30
|
* iris: fix gpu calcs for timestamp queriesDave Airlie2019-02-211-1/+31
|
* iris: only mark depth/stencil as writable if writes are actually enabledKenneth Graunke2019-02-211-10/+17
|
* iris: more dead commentsKenneth Graunke2019-02-212-12/+0
|
* iris: pin and re-pin the scratch BOKenneth Graunke2019-02-213-14/+29
|
* iris: delete finished commentsKenneth Graunke2019-02-211-2/+0
|
* iris: always pin the binder...in the compute context, too.Kenneth Graunke2019-02-211-0/+7
| | | | not sure why this hasn't tripped things up
* iris: Track blend enables, save outbound for resolve codeKenneth Graunke2019-02-212-1/+17
|
* iris: whitespace fixesKenneth Graunke2019-02-212-7/+7
|
* iris: Make a alloc_surface_state helperKenneth Graunke2019-02-211-18/+22
| | | | This does the gtt_offset addition for us
* iris: Use a surface state fill helperKenneth Graunke2019-02-211-18/+19
| | | | This will check aux_usage eventually
* iris: don't print the pointer in INTEL_DEBUG=submitKenneth Graunke2019-02-211-4/+3
| | | | | lots of noise in diff, hope was it would be useful for gdb, but the the GEM handle is good enough
* iris: Fix the prototype for iris_bo_alloc_tiledKenneth Graunke2019-02-211-2/+2
| | | | | This now matches the actual function in iris_bufmgr.c, as well as the equivalent brw_bufmgr.c function...
* iris: Fix for PIPE_CAP_SIGNED_VERTEX_BUFFER_OFFSETKenneth Graunke2019-02-211-1/+1
| | | | | | This fixes ext_transform_feedback-builtin-varyings gl_Position after the combination of my transform feedback reworks and my vertex buffer reworks (?)
* iris: drop unnecessary genx->streamout fieldKenneth Graunke2019-02-211-1/+0
|
* iris: Implement DrawTransformFeedback()Kenneth Graunke2019-02-215-20/+60
| | | | We get the count by dividing the offset by the stride.
* iris: Copy anv's MI_MATH helpers for multiplication and divisionJason Ekstrand2019-02-212-0/+152
| | | | | (import done by Ken but with author set to Jason because it's his code that's being imported, so he deserves the credit)
* iris: only get space for one offset in stream output targetsKenneth Graunke2019-02-211-2/+2
| | | | | Target corresponds to a buffer, buffer only records one offset, not multiple.
* iris: Move iris_stream_output_target def to iris_context.hKenneth Graunke2019-02-212-10/+10
| | | | now that it doesn't have genxml
* iris: Don't bother packing 3DSTATE_SO_BUFFER at create timeKenneth Graunke2019-02-211-27/+16
| | | | | We have to do half the packet late anyway, we may as well just do it all at set time. This also lets us move the struct def out of genxml
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-28 14:23:56 +0000