| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Add current_pipe_control_dw1 and deferred_pipe_control_dw1 to track what have
been done since lsat 3DPRIMITIVE and what need to be done before next
3DPRIMITIVE. Based on them, we can emit WAs more smartly.
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was used to set has_gen6_wa_pipe_control to false when the batch buffer
changed. When called from emit_flush() and others, it also unset
ILO_3D_PIPELINE_INVALIDATE_BATCH_BO so that the following emit_draw() will not
set has_gen6_wa_pipe_control to false again. It sounded error-prone and was
just ugly.
We should be able to achieve the same goal by reset has_gen6_wa_pipe_control
in ilo_3d_pipeline_invalidate(). With handle_invalid_batch_bo() gone, the
emit functions can also be inlined.
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
|
|
|
| |
We do not need to call it from GEN7 pipeline anymore since software
PIPE_QUERY_PRIMITIVES_EMITTED is gone.
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
|
|
|
| |
We should be able to draw with the index buffer mapped. That simplifies
things a lot.
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
|
|
| |
Conditional rendering is not limited to draw_vbo(). Move the support to
ilo_context, and replace ilo_3d_pass_render_condition() by
ilo_skip_rendering().
|
|
|
|
| |
The pipeline needs just the builder to build commands. It does not need CP.
|
|
|
|
|
| |
They can be done outside of the pipeline. Move them and let the pipeline
focus on building commands.
|
|
|
|
|
|
|
| |
SOL_RESET happens before bo execution. It should not be observed by the
commands that are already in the bo.
Move the code out of the pipeline now that it submits.
|
|
|
|
| |
It can be done outside of the pipeline. Let's move it.
|
|
|
|
|
|
|
|
| |
We used different lists for different types of queries because we wanted to
update software queries quickly. Now that there is no software queries, we
are fine with a single list.
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
|
|
|
|
| |
Read PIPE_QUERY_PRIMITIVES_GENERATED and PIPE_QUERY_PRIMITIVES_EMITTED from
hardware registers. Because all queries now have a bo, remove unnecessary
checks for q->bo.
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
|
|
|
| |
Add support for PIPE_QUERY_PRIMITIVES_GENERATED and
PIPE_QUERY_PRIMITIVES_EMITTED in ilo_3d_pipeline_emit_query().
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
|
|
|
|
|
|
| |
It replaces
ilo_3d_pipeline_emit_write_timestamp(),
ilo_3d_pipeline_emit_write_depth_count(), and
ilo_3d_pipeline_emit_write_statistics().
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
|
|
|
| |
This fixes some corner cases, but more importantly, the new code should be
easier to reason about.
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
|
|
|
| |
Make it own()'s responsibility to make room for release() and itself. To be
able to do that, allow ilo_cp_submit() in own().
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
| |
It saves quite some typings.
|
|
|
|
| |
Add ilo_3d_draw_rectlist() for use by RECTLIST blitter.
|
|
|
|
|
| |
We need ilo_builder for command building and ilo_cp for size check.
ilo_context is not used.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Move pipe states in ilo_context to the new ilo_state_vector. The motivation
is that ilo_context consists of several loosely related things. When we need
an ilo_context somewhere, we usually need only one or two of the things in it.
This change makes ilo_state_vector one such thing.
An immediate result is that we no longer need ilo_context in 3D pipelines,
something we have planned for since early days.
|
|
|
|
|
| |
Move the #define's and struct's to ilo_state.h. Move the inline functions and
function declarations to ilo_state_gen.h.
|
|
|
|
| |
Rename them to ilo_state_gen*.[ch].
|
|
|
|
| |
It is manipulated only in ilo_screen.c.
|
|
|
|
|
|
| |
It has been a bad name since we added the builder. Rename it to
ILO_DEBUG=batch to match i965, and call ilo_builder_decode() from
ilo_cp_submit_internal().
|
|
|
|
|
|
| |
"Flush" is used for too many things already: pipe resource flush, pipe context
flush, pipe transfer region flush, and hardware pipeline flush. Rename it to
ilo_cp_submit(). As such, ILO_DEBUG=flush is renamed to ILO_DEBUG=submit.
|
|
|
|
| |
Call ilo_builder_batch_used() directly.
|
|
|
|
|
|
| |
The simplification allows us to get rid of ilo_cp_set_ring() and
ilo_cp_implicit_flush(). The 3D query code is refactored for the
simplification.
|
|
|
|
| |
Mostly style changes to set dw[0] directly.
|
|
|
|
| |
There was a typo introduced by 90f4b131fccae3a950864ed9ba15eea8edce915f.
|
|
|
|
|
|
|
|
|
|
|
| |
We might run into ve->count == 0 and last_velement_edgeflag == true in
gen6_3DSTATE_VERTEX_ELEMENTS() when the state tracker sets an invalid
combination of VS and VE (does not seem to happen with st/mesa). Do not
assume ve->count is positive when last_velement_edgeflag is true.
Reported by Coverity.
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
|
|
| |
Always initialize the operand array to point to src0, src1, and src2.
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
|
|
| |
One less switch statement to maintain.
Signed-off-by: Chia-I Wu <[email protected]>
|
|
|
|
| |
Add ILO_PRIM_RECTANGLES to replace the rectlist bool.
|
|
|
|
|
|
| |
Rename ilo_builder_batch_state_base_address() to gen6_state_base_address() for
consistency and remove unused gen6_STATE_BASE_ADDRESS(). Reorder the code in
gen6_PIPE_CONTROL() a bit. Finally, some mostly cosmetic changes.
|
|
|
|
|
|
| |
Move functions for the 3D pipeline to the new headers. We artificially split
the functions into top (vertex processing) and bottom (pixel processing), to
keep the headers at reasonable sizes.
|
|
|
|
| |
Move functions for the media pipeline to the new header.
|
|
|
|
| |
Move 3D/media common functions to the new header.
|
|
|
|
|
|
|
|
|
| |
In buf_clear_region() and buf_copy_region(), max_cmd_size was set to 0. If
either of the functions is called and there is not enough space in the
builder, the next ilo_cp_flush() will fail silently in a release build.
Replace magic numbers by size defines in tex_clear_region()/tex_copy_region()
for consistency and readability.
|
|
|
|
|
| |
Intruduce gen6_blt_bo and gen6_blt_xy_bo to describe BOs. In the extreme case
of gen6_XY_SRC_COPY_BLT(), the number of parameters goes down from 18 to 8.
|
|
|
|
| |
Follow the changes for MI functions, but for BLT this time.
|
|
|
|
|
| |
With ilo_builder in place, some conventions we had to build commands are no
longer needed.
|
|
|
|
| |
Follow the changes for MI functions, but for BLT this time.
|
|
|
|
|
| |
Have a centralized place for MI functions, and remove the duplicated
gen6_MI_LOAD_REGISTER_IMM().
|
|
|
|
| |
It replaces ILO_GPE_VALID_GEN().
|
|
|
|
|
| |
It should enable us to do specialized builds by making the accessor return a
constant.
|
|
|
|
| |
They replace READ() and SET_FIELD() that we have been using.
|
|
|
|
| |
The last user has gone away.
|
|
|
|
| |
We cannot pass 0 as the width or height to ilo_gpe_init_view_surface_null().
|
|
|
|
|
|
|
|
|
|
| |
This allows a sampler view to have a different texture target than the
underlying resource. This will be used to implement the type casting
between 2d arrays and cube maps as specified in ARB_texture_view.
Signed-off-by: Ilia Mirkin <[email protected]>
Reviewed-by: Roland Scheidegger <[email protected]>
Reviewed-by: Marek Olšák <[email protected]>
|
|
|
|
| |
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83777
|