summaryrefslogtreecommitdiffstats
path: root/docs/submittingpatches.html
Commit message (Collapse)AuthorAgeFilesLines
* docs: simplify `Fixes:` git commandEric Engestrom2019-07-191-1/+3
| | | | | Reviewed-by: Eric Anholt <[email protected]> Signed-off-by: Eric Engestrom <[email protected]>
* docs: Tell people how to easily generate the Fixes lines.Eric Anholt2019-07-151-0/+1
| | | | | | | | | v2: Include '-s' to suppress the diff. v3: use the git config command (Ken), use &lt; (Eric) Reviewed-by: Matt Turner <[email protected]> (v1) Acked-by: Eric Engestrom <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]>
* docs: use pre-block for showing commit-noteErik Faye-Lund2019-06-051-3/+3
| | | | | | | | | Having a single-item list for this seems odd. Let's just use a pre-block in stead. Signed-off-by: Erik Faye-Lund <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Reviewed-by: Eric Engestrom <[email protected]>
* docs: remove stray whitespaceErik Faye-Lund2019-06-051-3/+3
| | | | | | | | | There's some stray whitespace in these files that doesn't do anything useful. Let's get rid of if. Signed-off-by: Erik Faye-Lund <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Reviewed-by: Eric Engestrom <[email protected]>
* docs: do not use br-tag for non-significant breaksErik Faye-Lund2019-06-051-5/+10
| | | | | | | | | | | | | | | According to the W3C, we shouldn't use the br-tag unless the line-break is part of the content: https://www.w3.org/TR/2011/WD-html5-author-20110809/the-br-element.html All of these instances are for non-content usage, and is as such technically out-of-spec. So let's either remove them, or split paragraphs, based on how related the content are. Signed-off-by: Erik Faye-Lund <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Reviewed-by: Eric Engestrom <[email protected]>
* docs: advice to resolve discussion on gitlab MR docAlejandro Piñeiro2019-05-161-0/+3
| | | | | | | | | | | | | | For newcomers to gitlab, it is not evident that it is better to press the "Resolve Discussion" button when you update your branch handling feedback. v2: * Fix several grammar nits, reorder, use new corrected text (Connor Abbot) * Use "reviewers", instead of reviewer (Eric Engestrom) Reviewed-by: Connor Abbott <[email protected]> Reviewed-by: Eric Engestrom <[email protected]>
* docs: drop h1 in headerErik Faye-Lund2019-05-081-1/+1
| | | | | | | | | | | It's generally frowned upon to have more than one H1 per document in HTML4. So let's put the text directly inside the header. This means we can drop the flex-based centering, which makes things a bit easier. We also need to change the padding to rem instead of em, because the em has now changed. Signed-off-by: Erik Faye-Lund <[email protected]> Reviewed-by: Eric Engestrom <[email protected]>
* docs: harmonize headings and titlesErik Faye-Lund2019-05-081-2/+2
| | | | | | | | | | | | | We're pretty insonsistent in what the headings and titles are, especially compared to what the articles are listed as in the sidebar. Let's harmonize this. There's a notable exception for meson.html, where the sidebar uses a short-hand form that makes sense in the sidebar, but not in the article due to the visible context being different. Signed-off-by: Erik Faye-Lund <[email protected]> Reviewed-by: Eric Engestrom <[email protected]>
* docs: close paragraphs before preformatted textErik Faye-Lund2019-05-021-1/+1
| | | | | | | | | | | It's illegal to nest block-level elements such as <pre> inside <p> in HTML. This means that when the paragraphs gets closed after a <pre>-tag, we end up closing a non-existent tag, so the browser inserts a dummy <p>-tag. This is entirely pointless, so let's just close these tags before the <pre>-tag instead. Signed-off-by: Erik Faye-Lund <[email protected]> Reviewed-by: Eric Engestrom <[email protected]>
* docs: close paragraphs before listsErik Faye-Lund2019-05-021-18/+18
| | | | | | | | | paragraphs can't contain lists, and attempting to close them after the list just cause an extra, empty paragraph to be created. We don't want that, so let's close the paragraphs before the list intead. Signed-off-by: Erik Faye-Lund <[email protected]> Reviewed-by: Eric Engestrom <[email protected]>
* docs: replace autotools intructions with meson equivalentEric Engestrom2019-04-301-4/+4
| | | | | Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Dylan Baker <[email protected]>
* docs: mention "Allow commits from members who can merge..."Emil Velikov2019-02-261-0/+5
| | | | | | | | | | Mention the tick-box otherwise only the MR author can rebase the series. Cc: Jordan Justen <[email protected]> Cc: Dylan Baker <[email protected]> Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Eric Engestrom <[email protected]> Reivewed-by: Erik Faye-Lund <[email protected]>
* docs: add note about sending merge-requests from forksErik Faye-Lund2019-01-231-0/+2
| | | | | | | | | | | | Sending MRs from the main Mesa repository increase clutter in the repository, and decrease visibility of project-wide branches. So it's better if MRs are sent from forks instead. Let's add a note about this, in case its not obvious to everyone. Signed-off-by: Erik Faye-Lund <[email protected]> Reviewed-by: Eric Engestrom <[email protected]> Reviewed-by: Emil Velikov <[email protected]>
* docs: add note about using backticks for rbs in gitlabDylan Baker2018-12-211-0/+11
| | | | | | | | So that gitlab will render the < and > correctly allowing the tag to be copy-n-pasted without additional formatting. Reviewed-by: Eric Anholt <[email protected]> Reviewed-by: Jordan Justen <[email protected]>
* docs: Add an encouraging note about providing reviews and acks.Eric Anholt2018-12-191-0/+8
| | | | | | | | | | Across several projects I've seen new contributors say "I wasn't sure if I should provide a review tag since I'm not really an expert in this area." Everyone I know already applies some implicit weighting to reviews from different people, so encourage participation. Reviewed-by: Dylan Baker <[email protected]> Reviewed-by: Ian Romanick <[email protected]>
* docs: Add a note that MRs should still include any r-b or a-b tags.Eric Anholt2018-12-191-0/+4
| | | | | | | v2: Mention "Tested-by" too Reviewed-by: Dylan Baker <[email protected]> (v1) Reviewed-by: Ian Romanick <[email protected]>
* docs: Document GitLab merge request process (email alternative)Jordan Justen2018-12-121-5/+71
| | | | | | | | | | | | | | | | | | | | | | | | | This documents a process for using GitLab Merge Requests as an second way to submit code changes for Mesa. Only one of the two methods is allowed for each patch series. We will *not* require all patches to be emailed. Some code changes may be reviewed and merged without any discussion on the mesa-dev email list. v2: * No longer require email. Allow submitter to choose email or a GitLab merge request. * Various feedback from Brian, Daniel, Dylan, Eric, Erik, Jason, Matt, Michel and Rob. Signed-off-by: Jordan Justen <[email protected]> Acked-by: Jason Ekstrand <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Acked-by: Dylan Baker <[email protected]> Reviewed-by: Erik Faye-Lund <[email protected]> Reviewed-by: Eric Engestrom <[email protected]> Acked-by: Bas Nieuwenhuizen <[email protected]> Acked-by: Rob Clark <[email protected]>
* docs: document the staging branch and add reference to itEmil Velikov2018-11-151-0/+3
| | | | | | | | | | | | A while back we agreed that having a live/staging branch is beneficial. Sadly we forgot to document that, so here is my first attempt. Document the caveat that the branch history is not stable. CC: Andres Gomez <[email protected]> CC: Dylan Baker <[email protected]> Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Juan A. Suarez <[email protected]>
* docs/submittingpatches.html: correctly handle the <p> tagEmil Velikov2018-11-151-0/+2
| | | | | | | As pointed out by the w3c validator. Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Juan A. Suarez <[email protected]>
* docs: correct typo in the submitting patches instructionsAndres Gomez2018-07-241-1/+1
| | | | | | | Cc: Emil Velikov <[email protected]> Cc: Eric Engestrom <[email protected]> Signed-off-by: Andres Gomez <[email protected]> Reviewed-by: Emil Velikov <[email protected]>
* docs: fix `<` & `>` used in html codeEric Engestrom2018-05-231-3/+3
| | | | | Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Ian Romanick <[email protected]>
* docs: ask for backport nominations to cc: the authorEric Engestrom2018-01-231-0/+4
| | | | | Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]>
* docs/submittingpatches: add 'test each commit' instructionsEric Engestrom2017-09-171-0/+12
| | | | | Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Thomas Helland <[email protected]>
* docs: Document interaction Fixes tag and stable branches.Bas Nieuwenhuizen2017-04-151-0/+4
| | | | | | | For the next time I forget. Signed-off-by: Bas Nieuwenhuizen <[email protected]> Reviewed-by: Emil Velikov <[email protected]>
* docs/submittingpatches: add mention about legal disclaimersEric Engestrom2017-03-231-0/+10
| | | | | Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Nicolai Hähnle <[email protected]>
* docs: fix a few typosEric Engestrom2017-02-271-1/+1
| | | | | | | Noticed a couple, found the rest using vimspell. Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Emil Velikov <[email protected]>
* docs/submittingpatches.html: document the Fixes tagEmil Velikov2017-02-201-0/+5
| | | | | | | Provide information and an example. Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Nicolai Hähnle <[email protected]>
* docs/submittingpatches.html: remove version tag for nominationsEmil Velikov2017-02-201-8/+2
| | | | | | | | | | | The version tag used to nominate has bitten even experienced mesa developers. Not to mention that it deviates from the one used in the kernel leading to further confusion. Simplify things and omit it all together. Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Nicolai Hähnle <[email protected]>
* docs/submittingpatches.html: add #backports sectionEmil Velikov2017-02-201-3/+14
| | | | | | | | Provide information about merge conflicts resolution and sending backports. Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Nicolai Hähnle <[email protected]>
* docs/submittingpatches.html: rework the #criteria sectionEmil Velikov2017-02-201-74/+46
| | | | | | | | Reword the section to focus on what is allowed, using a more brief, yet descriptive wording. Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Nicolai Hähnle <[email protected]>
* docs/submittingpatches: assorted grammar fixesEmil Velikov2017-02-161-5/+5
| | | | | | | Cc: Ben Crocker <[email protected]> Suggested-by: Ben Crocker <[email protected]> Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Nicolai Hähnle <[email protected]>
* docs: https all the links \o/Eric Engestrom2017-02-091-1/+1
| | | | | | | | | Most of them already redirected to https anyway, so we might as well avoid the redirection and the security implications by linking directly to the right protocol. Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Brian Paul <[email protected]>
* docs: document how to (self-) reject stable patchesEmil Velikov2016-12-091-0/+7
| | | | | | | | | Document what has been the unofficial way to self-reject stable patches. Namely: drop the mesa-stable tag and push the commit. Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Nanley Chery <[email protected]>
* docs: fix small typoEric Engestrom2016-11-291-1/+1
| | | | | | Fixes: ba28f2136febca32fe56 ("docs: add note about r-b/other tags when resending") Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Emil Velikov <[email protected]>
* docs: add git tips how to do commit fixups and squash themEmil Velikov2016-11-281-0/+7
| | | | Signed-off-by: Emil Velikov <[email protected]>
* docs: add note about r-b/other tags when resendingGeorge Kyriazis2016-11-281-0/+3
| | | | | [Emil Velikov: split from the typos fixes] Signed-off-by: Emil Velikov <[email protected]>
* docs: fix small typos in the submit patches pageAndres Gomez2016-11-281-4/+4
| | | | | Signed-off-by: Andres Gomez <[email protected]> Reviewed-by: Emil Velikov <[email protected]>
* docs/submitting patches: mention get_reviewers.plEmil Velikov2016-11-221-0/+18
| | | | | | | | Mention the script - why/how to use alongside a useful trick to make it work interactively (thanks Rob!). Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Elie Tournier <[email protected]>
* docs/submitting patches: add git tipsTimothy Arceri2016-11-221-0/+20
| | | | | | | | | | | | | | v2: [Emil Velikov] - Add the shorthand git send-email -vX - Move to submittingpatches.html - Add to the TOC. v3: [Emil Velikov] - Use @~8 instead of HEAD~8 (Nicolai) Cc: Timothy Arceri <[email protected]> Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Brian Paul <[email protected]> (v1)
* docs/submittingpatches: fix tags mis/abuseEmil Velikov2016-11-211-1/+5
| | | | | | | Fix the odd tag so that we're HTML 4.01 Traditional compliant Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Brian Paul <[email protected]>
* docs/submittingpatches: flesh out "how to nominate" methodsEmil Velikov2016-11-211-10/+20
| | | | | | | | | | | Currently they are buried within the text, making it hard to find. Move them to the top and be clear what is _not_ a good idea. v2: Minor commit polish, use only "resending" as suggested by Matt. Reviewed-by: Marek Olšák <[email protected]> Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Brian Paul <[email protected]>
* docs: split Submitting Patches into separate documentEmil Velikov2016-11-211-0/+309
Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Brian Paul <[email protected]>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-20 10:15:20 +0000