aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* pan/mdg: Add pack_unorm_4x8 via 8-bitAlyssa Rosenzweig2020-06-013-0/+10
| | | | | | | More efficient than the 32-bit version in NIR. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5265>
* pan/mdg: Handle un/pack opcodes as movesAlyssa Rosenzweig2020-06-011-0/+20
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5265>
* iris: Fixup copy'n'paste mistake in Makefile.sourcesChris Wilson2020-05-311-2/+2
| | | | | | | | | In changing iris_seqno.[ch] to iris_fine_fence.[ch] and moving the lines earlier, the newline escape was forgotten. Fixes: 034329128b703f8c2e8a ("iris: Rename iris_seqno to iris_fine_fence") Reviewed-by: Eric Engestrom <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5264>
* intel/dev: Don't consider all TGL SKUs as GT1 onlySatyeshwar Singh2020-05-301-1/+1
| | | | | | | | | | | We should be passing _gt instead of 1 to GEN12_FEATURES or else all TGL SKUs will be considered as gt1 only. Fixes: 54996ad4927 ("intel/dev: Split .num_subslices out of GEN12_FEATURES macro") Signed-off-by: Satyeshwar Singh <[email protected]> Reviewed-by: Eric Engestrom <[email protected]> Reviewed-by: Jordan Justen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5261>
* r300g: Remove extra printf format specifiers.Vinson Lee2020-05-301-2/+2
| | | | | | | | | | | | Fix warning reported by Coverity Scan. Missing argument to printf format specifier (PRINTF_ARGS) missing_argument: No argument for format specifier %s. Fixes: 04c1536bf7ab ("r300g: rasterizer debug logging") Fixes: 85efb2fff0d4 ("r300g: try to use color varyings for texcoords if max texcoord limit is exceeded") Signed-off-by: Vinson Lee <[email protected]> Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5274>
* nouveau: allow invalidating coherent/persistent buffer backingsIlia Mirkin2020-05-301-5/+0
| | | | | | | | | | | | This is needed to support the core's usage of coherent buffers for glVertex-style input. The reason why this was disallowed is that any mappings will be invalidated. Let the state tracker worry about that, and just reallocate when we're told. Signed-off-by: Ilia Mirkin <[email protected]> Reviewed-by: Karol Herbst <[email protected]> Cc: [email protected] Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5276>
* intel/fs: Emit HALT for discard on Gen4-5Jason Ekstrand2020-05-306-30/+107
| | | | | | | | | | | | | | | | | | Using HALT to immediately jump to the end of the shader is required to implement GL_EXT_gpu_shader4 and OpenGL 3.0. However, vanilla OpenGL 1.2 doesn't forbid it and it likely makes something somewhere faster. We should be consistent and implement the same discard behavior on all hardware if we can. The rules for HALT on Gen4-5 are a bit different from Gen6+. On the older hardware, there is no stack for HALT; instead it's up to software to save and restore mask registers. However, there's no real saving needed since we only use HALT to jump to the end of the program where we're about about to do our FB writes. All we need to do is reset AMask to DMask, the value it was initialized to at the start of the thread. Reviewed-by: Kenneth Graunke <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5244>
* intel/fs: Fix unused texture coordinate zeroing on Gen4-5Jason Ekstrand2020-05-301-1/+2
| | | | | | | | | | We were inserting the right number of MOVs but, thanks to the way we advanced msg_end earlier in the function, were often writing the zeros past the end of where we actually read in the register file. Cc: [email protected] Reviewed-by: Kenneth Graunke <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5243>
* intel/vec4: Stomp the return type of RESINFO to UINT32Jason Ekstrand2020-05-301-0/+11
| | | | | | | | | We already do this in the FS back-end; we just weren't doing it in vec4 so RESINFO messages weren't returning the right data. Cc: [email protected] Reviewed-by: Kenneth Graunke <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5243>
* radv: fix regression with builtin cacheTimothy Arceri2020-05-301-1/+1
| | | | | | | | | | | If the ~/.cache dir already exists continue on without failing. Fixes: cd61f5234d2c ("radv: Handle failing to create .cache dir.") Tested-by: Dieter Nützel <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5249>
* gallium/dri: Remove lowered_yuv tracking for plane mapping.Bas Nieuwenhuizen2020-05-302-12/+5
| | | | | | | | Just heard that etnaviv is also compatible with it even in the non-lowered cases, so let us enable it for everyone. Reviewed-by: Lucas Stach <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5253>
* panfrost: Fix printf format specifier.Vinson Lee2020-05-301-1/+1
| | | | | | | | | | | | | | | bifrost_sampler_descriptor.zero1 is of type uint8_t. Fix warning reported by Coverity. Invalid type in argument to printf format specifier (PRINTF_ARGS) invalid_type: Argument s->zero1 to format specifier %lx was expected to have type unsigned long but has type unsigned char. Fixes: 6148d1be4bb5 ("panfrost: Fix size of bifrost sampler descriptor") Signed-off-by: Vinson Lee <[email protected]> Reviewed-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5248>
* glthread: don't upload for glDraw inside a display list and always syncMarek Olšák2020-05-303-19/+58
| | | | | | | | | | | | | Let the vbo module handle it, not glthread. This handles functions set in vbo_initialize_save_dispatch. Fixes: 2840bc3065b ("glthread: upload non-VBO vertices and indices for non-Indirect non-IBM draws") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3001 Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]> Tested-by: Dieter Nützel <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5246>
* util/format: Add more multi-planar formats.Bas Nieuwenhuizen2020-05-306-0/+339
| | | | | | | | These don't have a fourcc code as far as I can tell, but we want them for internal Vulkan use. Reviewed-by: Eric Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5195>
* util/format: Use correct pipe format for VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM.Bas Nieuwenhuizen2020-05-301-1/+1
| | | | | | | | | | | | | | NV12 is UVUVUV (https://wiki.videolan.org/YUV#NV12) and in Vulkan is VK_FORMAT_G8_B8R8_2PLANE_420_UNORM. So U=B and V=R. So plane order in VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM is YUV, which is PIPE_FORMAT_IYUV. Further confirmation: https://fourcc.org/yuv.php U=Cb V=Cr. From the nir ycbcr conversion, B=Cb and R=Cr. Fixes: 75d7ee80291 "util/format: translate 422_UNORM and 420_UNORM vulkan formats" Reviewed-by: Eric Anholt <[email protected]> Reviewed-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5195>
* util/format: Add VK_FORMAT_D16_UNORM_S8_UINT.Bas Nieuwenhuizen2020-05-305-1/+74
| | | | | | | | Not participating in packing/unpacking/stencil-only/depth-only, because it doesn't mix well in a single plane. Reviewed-by: Eric Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5195>
* etnaviv: Fix memory leak on error path.Vinson Lee2020-05-301-4/+5
| | | | | | | | | | | | | | Fix warning reported by Coverity Scan. Resource leak (RESOURCE_LEAK) leaked_storage: Variable pq going out of scope leaks the storage it points to. Suggested-by: Christian Gmeiner <[email protected]> Fixes: eed5a009897a ("etnaviv: convert perfmon queries to acc queries") Signed-off-by: Vinson Lee <[email protected]> Reviewed-by: Christian Gmeiner <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5220>
* panfrost: Probe G31/G52 if PAN_MESA_DEBUG=bifrostAlyssa Rosenzweig2020-05-292-0/+8
| | | | | | | | | | | | We're not *quite* ready to open the flood gates on Bifrost (a major blocker is CI, which is itself blocked on the lockdowns - expected to be resolved in the coming months..) Nevertheless, let's add a debug option to probe on compatible Bifrost devices to avoid keeping out-of-tree patches around. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5272>
* panfrost: Add GPU IDs for G31/G52Alyssa Rosenzweig2020-05-291-0/+2
| | | | | | | Dvalin/Gondul respectively. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5272>
* panfrost: Disable QUAD_STRIP/POLYGON on BifrostAlyssa Rosenzweig2020-05-291-2/+10
| | | | | | | | Support was dropped and now raises a DATA_INVALID_FAULT on G31. Unknown if retained on other devices. GL_QUADS is still ok. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Passthrough deps of the branch targetAlyssa Rosenzweig2020-05-291-2/+16
| | | | | | | Now that we have the infrastructure, follow the branch. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Allow two successors in header packingAlyssa Rosenzweig2020-05-291-7/+14
| | | | | | | We need to take the union of the dependencies. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Measure backwards branches as wellAlyssa Rosenzweig2020-05-291-1/+26
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Add bi_foreach_block_from_rev helperAlyssa Rosenzweig2020-05-291-0/+3
| | | | | | | Needed for next commit. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Defer block naming until after emitAlyssa Rosenzweig2020-05-292-3/+7
| | | | | | | This ensures names are meaningful. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Pack unconditional branchAlyssa Rosenzweig2020-05-291-1/+30
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Set branch conditional bitAlyssa Rosenzweig2020-05-291-1/+4
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Set back-to-back bit more accuratelyAlyssa Rosenzweig2020-05-291-1/+35
| | | | | | | | See Connor's ISA notes. Basically set unless it's a branch (explicit or fallthrough). Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Set branch_conditional if b2b is setAlyssa Rosenzweig2020-05-291-1/+1
| | | | | | | Match the blob. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Pack proper clause offsetsAlyssa Rosenzweig2020-05-291-0/+20
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Measure distance between blocksAlyssa Rosenzweig2020-05-292-0/+47
| | | | | | | For branch offset calculation. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Add bi_foreach_clause_in_block_from{_rev} helpersAlyssa Rosenzweig2020-05-291-0/+6
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Link clauses back to their blocksAlyssa Rosenzweig2020-05-292-0/+6
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Preliminary branch packingAlyssa Rosenzweig2020-05-292-1/+37
| | | | | | | Simple == 0 branch packing. Offset is still to-do. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Assign constant port for branch offsetsAlyssa Rosenzweig2020-05-291-0/+18
| | | | | | | By convention. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Set branch_constant if there is a branchAlyssa Rosenzweig2020-05-291-0/+4
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Pack branch offset constantsAlyssa Rosenzweig2020-05-291-1/+22
| | | | | | | | This is not fully generic but for a single constant it will do. Extensions left for future work. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Add branch constant field to IRAlyssa Rosenzweig2020-05-292-0/+9
| | | | | | | | | The offsets used for branches need some extra bits twiddled, so add a field to the clause to indicate this is happening. This is not ambiguous since a clause can only have a single branch. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Passthrough ZERO in branch packingAlyssa Rosenzweig2020-05-291-0/+1
| | | | | | | There's a special mode for it. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Fix branch condition typesizeAlyssa Rosenzweig2020-05-291-1/+2
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Fix CONVERT component countingAlyssa Rosenzweig2020-05-291-1/+10
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Only rewrite COMBINE dest if not SSAAlyssa Rosenzweig2020-05-291-2/+4
| | | | | | | | | | | | | | If it's already a register, there's no point in rewriting and it will disturb the existing register, i.e. for if (..) { r0 = vecN .. } else { r0 = vecN .. } Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Fix emit_if successor assignmentAlyssa Rosenzweig2020-05-291-4/+2
| | | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Fixes: 9a00cf3d1ef ("pan/bi: Add support for if-else blocks") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Allow printing branches without targetsAlyssa Rosenzweig2020-05-291-2/+5
| | | | | | | Useful for debugging codegen. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Remove schedule_barrierAlyssa Rosenzweig2020-05-291-15/+0
| | | | | | | Legacy from Midgard. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Add helper to measure clause sizeAlyssa Rosenzweig2020-05-292-0/+41
| | | | | | | Useful for branching. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Add bi_layout.c for clause layout helpersAlyssa Rosenzweig2020-05-294-0/+57
| | | | | | | | | Figuring out what "shapes" of clauses are kosher happens during scheduling, not packing, but shouldn't distract the scheduler. So let's add a new file for these sorts of questions. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Remove more artefacts of 2-pass schedulingAlyssa Rosenzweig2020-05-292-20/+4
| | | | | | | A clause is, by definition, already scheduled. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Add MUL.i32 to disasmAlyssa Rosenzweig2020-05-291-0/+1
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>
* pan/bi: Disassemble pos=0xeAlyssa Rosenzweig2020-05-291-0/+3
| | | | | Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>