aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* gitlab-ci: Merge ccache and libxml2-utils into main apt-get installMichel Dänzer2020-02-051-6/+6
| | | | | | | | | | | | The motivation for this is that we want to make use of the meson cross files in this script, which have the ccache compiler paths. We need to remove the ccache directory at the end, it would just waste space in the image for no benefit. Reviewed-by: Adam Jackson <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3643>
* gitlab-ci: Pass -j4 to makeMichel Dänzer2020-02-051-7/+7
| | | | | | | | Might speed up x86_build docker image build a little. Reviewed-by: Adam Jackson <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3643>
* gitlab-ci: Update to latest ci-templates HEADMichel Dänzer2020-02-051-2/+1
| | | | | | | | | | | | | Among other things, this increases robustness when copying a docker image from the main Mesa project to a forked project, avoiding spurious image rebuilds from scratch. Also drop the comment about .gitlab-ci/lava-gitlab-ci.yml, it doesn't include the templates anymore. Reviewed-by: Adam Jackson <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3643>
* radeonsi/ngg: add VGT_FLUSH when enabling fast launchPierre-Eric Pelloux-Prayer2020-02-051-0/+5
| | | | | | | | Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2418 Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2426 Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2434 Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3675> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3675>
* util/disk_cache: check for write() failure in the zstd pathEric Engestrom2020-02-051-1/+5
| | | | | | | | | CoverityID: 1458074 Fixes: a8d941091f72923561a6 ("util: Use ZSTD for shader cache if possible") Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Dylan Baker <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3672> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3672>
* dri: delete gen-symbol-redefs.pyEric Engestrom2020-02-051-68/+0
| | | | | | | | | | | Introduced in ba10d79cca8d93c9f366 but it looks like it was never wired into anything. Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Kristian H. Kristensen <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3669> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3669>
* anv: implement gen12 post sync pipe control workaroundLionel Landwerlin2020-02-051-1/+5
| | | | | | | | | | | Same as Skylake. v2: Restrict to A0 Signed-off-by: Lionel Landwerlin <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3405> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3405>
* anv: implement gen9 post sync pipe control workaroundLionel Landwerlin2020-02-053-0/+39
| | | | | | | | | | | | | | We've been missing this workaround for a while and since it's required for Gen12, let's implement it for Gen9 first. v2: Update comment for Gen9. v3: Fix clearing of bits... (Lionel) Signed-off-by: Lionel Landwerlin <[email protected]> Cc: <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3405>
* iris: implement gen12 post sync pipe control workaroundLionel Landwerlin2020-02-051-1/+4
| | | | | | | | | | | Like Skylake, Gen12 requires a workaround for PIPE_CONTROLs using a post-sync operation. v2: Restrict to A0 Signed-off-by: Lionel Landwerlin <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3405>
* freedreno: allow ctx->batch to be NULLRob Clark2020-02-044-30/+2
| | | | | | | | | | | | | | This was mostly true already, now that we use `fd_context_batch()` for first access to batch in draw/clear/grid paths. So we can drop the old code in `batch_flush()` that tried to prevent `ctx->batch` from being NULL. Fixes a crash with a large number of tabs in chromium. Cc: "20.0" [email protected] Signed-off-by: Rob Clark <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3700> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3700>
* freedreno: Allow UBWC on textures with multiple mipmap levels.Eric Anholt2020-02-0412-98/+51
| | | | | | | | | | | | This is a backport of Jonathan Marek's UBWC work on turnip to GL. Performance highlights from our trace set (320 frames sampled) traces/glmark2/texture-texture-filter=mipmap.rdc: +9.1% +/- 2.2% traces/android/trex.rdc: +8.7% +/- 0.4% traces/glmark2/desktop-effect=shadow:windows=4.rdc: +4.2% +/- 2.5% Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3059> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3059>
* freedreno: Disable UBWC on Z24S8 if not TEXTURE_2D.Eric Anholt2020-02-041-3/+11
| | | | | | | Fixes two of our three remaining GLES CTS failures, and avoids more regressions once we enable UBWC mipmaps. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3059>
* freedreno: Blit all array levels when uncompressing UBWC.Eric Anholt2020-02-041-1/+4
| | | | | | | Fixes regressions in GLES CTS's format_reintepret once we enable UBWC with mipmaps. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3059>
* freedreno: Swap the whole resource layout in shadowing.Eric Anholt2020-02-041-5/+1
| | | | | | | Let's not have to worry about whether this unusual code path gets updated whenever we adjust what is in the layout struct. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3059>
* freedreno/a6xx: Disable the core layer-size setup.Eric Anholt2020-02-042-6/+3
| | | | | | This was getting in the way of UBWC mipmap handling. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3059>
* freedreno: Rename the UBWC layer size field and store it as bytes.Eric Anholt2020-02-0411-26/+25
| | | | | | | This makes the field description match its usage in the code, matches tu's usage of the field, and avoids storing values in surprising units. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3059>
* freedreno: Include the layer size in layout debug.Eric Anholt2020-02-041-1/+2
| | | | | | It's been many of my bugs so far. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3059>
* freedreno: Move the layout debug under FD_MESA_DEBUG=layout.Eric Anholt2020-02-047-31/+39
| | | | | | | I keep wanting to turn this on while debugging layout stuff, and I suspect krh and robclark could use it too. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3059>
* radv: Do not set SX DISABLE bits for RB+ with unused surfaces.Bas Nieuwenhuizen2020-02-041-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The extra bits in CB_SHADER_MASK break dual source blending in SkQP on a Stoney device. However: - As far as I can tell, some other dual source blend tests are passing before and after the change. - A hacked around skqp passes on my Vega desktop and Raven laptop - Getting Skqp to give any useful info or to run it outside of Android on ChromeOS is proving difficult. I have confirmed 3 strategies that seem to work: - The old radv behavior of setting CB_SHADER_MASK to 0xF - AMDVLK: CB_SHADER_MASK = 0xFF, and the 3 RB+ regs are 0. - radeonsi: CB_SHADER_MASK = 0xFF, but does not set DISABLE bits in SX_BLEND_OPT_CONTROL for CB 1-7. Let us use the radeonsi solution as that solution also seems like the correct thing to do for holes. I have tested on my Raven laptop that setting the high surfaces to not disabled and downconvert to 32_R does not imply a performance penalty. Fixes: e9316fdfd48 "radv: fix setting CB_SHADER_MASK for dual source blending" Reviewed-by: Samuel Pitoiset <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3670> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3670>
* mesa: implement missing display list functions while switching to the templateMarek Olšák2020-02-041-86/+718
| | | | | | | | The vbo_init_tmp.h template tells us which functions are unimplemented. Reviewed-by: Kristian H. Kristensen <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3611> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3611>
* vbo: move reusable code from vbo_attrib_tmp.h into vbo_util.hMarek Olšák2020-02-044-98/+135
| | | | | Reviewed-by: Kristian H. Kristensen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3611>
* vbo: use the template for save GLvertexformat initializationMarek Olšák2020-02-041-151/+6
| | | | | Reviewed-by: Kristian H. Kristensen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3611>
* vbo: use the template for noop GLvertexformat initializationMarek Olšák2020-02-044-332/+27
| | | | | Reviewed-by: Kristian H. Kristensen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3611>
* vbo: move GLvertexformat initialization into a template header file for reuseMarek Olšák2020-02-044-172/+205
| | | | | Reviewed-by: Kristian H. Kristensen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3611>
* freedreno/perfcntrs: fix fd leakEric Engestrom2020-02-041-1/+5
| | | | | | | | CoverityID: 1110568, 1458071 Fixes: 5a13507164a26fc796f0 ("freedreno/perfcntrs: add fdperf") Signed-off-by: Eric Engestrom <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3671> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3671>
* util: Drop unpacking from int signed to unsigned and vice versa.Eric Anholt2020-02-042-4/+2
| | | | | | | | | | After all the previous cleanups, it's clear that the callers only ever ask for SINT->SINT or UINT->UINT. Cuts 20k of compiled text from gallium drivers. Reviewed-by: Marek Olšák <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744>
* gallium: Refactor some single-pixel util_format_read/writes.Eric Anholt2020-02-043-11/+9
| | | | | | | We can use the new row helpers to cut down on the noise. Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744>
* gallium: Add and use a helper for packing uc from a color_union.Eric Anholt2020-02-047-59/+15
| | | | | | | | The same pattern kept coming up, and we don't need to hit util_format_write_4* to do it when we have util_format_pack_rgba(). Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744>
* softpipe: Refactor pipe_get/put_tile_rgba_* paths.Eric Anholt2020-02-047-397/+136
| | | | | | | | | We always want the same behavior of choosing which unpack to do to generate our 4x32-bit RGBA values, so just sink that choice down below the pipe_get/put_tile API. Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744>
* softpipe: Drop the raw_to* part of the tile cache interface.Eric Anholt2020-02-042-21/+3
| | | | | | | Nothing else uses it, so make it static. Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744>
* gallium/util: Remove pipe_get_tile_z/put_tile_z.Eric Anholt2020-02-042-264/+0
| | | | | | | | | | The previous caller wasn't using it as tiled, just row-at-a-time, and didn't want the clipping (since copytexsubimage comes in clipped). If someone wanted these functions again in the future, they should be rewritten on u_format_pack/unpack. Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744>
* mesa/st: Use direct util_format_pack/unpack instead of u_tile.Eric Anholt2020-02-041-8/+7
| | | | | | | We're doing a row at a time, and don't need u_tile's clipping. Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744>
* util: Make helper functions for pack/unpacking pixel rows.Eric Anholt2020-02-0411-63/+124
| | | | | | | | | Almost all users of the unpack functions don't have strides to plug in (and many are only doing one pixel!), and this will help simplify them. Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744>
* clover: add trivial clCreateCommandQueueWithProperties implementationKarol Herbst2020-02-042-1/+22
| | | | | | | | | | | | | | | It's not adding 2.0 features, but it's enough to run the 2.0 CTS on top of clover and probably most CL applications using it. We just fail if we hit unknown properties and that's probably good enough until we implement the other bits properly. Signed-off-by: Karol Herbst <[email protected]> Acked-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Pierre Moreau <[email protected]> Reviewed-by: Francisco Jerez <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2370> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2370>
* gallium/osmesa: Try to fix the test for big-endian.Eric Anholt2020-02-041-0/+21
| | | | | | | | | Our packed expected values will be byte-swapped for the (mostly) array formats we're testing. Reviewed-by: Danylo Piliaiev <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3216> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3216>
* gallium/osmesa: Fill out other format tests.Eric Anholt2020-02-041-42/+68
| | | | | | | | Move expected values/bpp into the test params, add more formats now that we've fixed context setup so that they work. Reviewed-by: Danylo Piliaiev <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3216>
* gallium/osmesa: Fix MakeCurrent of non-8888 contexts.Eric Anholt2020-02-041-1/+1
| | | | | | | | | | OSMesa is weird and you only get the type (byte/ubyte/565/etc.) at MakeCurrent time, having only a channel order at CreateContext time. The code was setting up a visual at CreateContext time, and then at MakeCurrent it would fail to validate against the visual. Reviewed-by: Danylo Piliaiev <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3216>
* gallium/osmesa: Fix a typo in the unit test's test names.Eric Anholt2020-02-041-1/+1
| | | | | Reviewed-by: Danylo Piliaiev <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3216>
* osmesa/tests: Cover OSMESA_RGB GL_UNSIGNED_BYTE caseDanylo Piliaiev2020-02-041-5/+21
| | | | | | Signed-off-by: Danylo Piliaiev <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3216>
* st/mesa: Handle the rest renderbuffer formats from OSMesaDanylo Piliaiev2020-02-041-0/+5
| | | | | | | | | | Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2189 Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/989 Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2036 CC: <[email protected]> Signed-off-by: Danylo Piliaiev <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3216>
* util/os_socket: fix header unavailable on windowsEric Engestrom2020-02-041-1/+2
| | | | | | | Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2464 Fixes: e62c3cf350a8b169e640 ("util/os_socket: Include unistd.h to fix build error") Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Krzysztof Raszkowski <[email protected]>
* i965: Do not set front_buffer_dirty if there is no front bufferDanylo Piliaiev2020-02-041-1/+3
| | | | | | | | | | | | | | | | | | Otherwise there will be a warning: "libEGL warning: FIXME: egl/x11 doesn't support front buffer rendering." Happens with EGL_KHR_surfaceless_context: eglMakeCurrent(egl_display, EGL_NO_SURFACE, EGL_NO_SURFACE, egl_context) eglMakeCurrent(egl_display, egl_surface, egl_surface, egl_context) glFlush() // Here will be a warning Cc: <[email protected]> Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1525 Signed-off-by: Danylo Piliaiev <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3628> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3628>
* gitlab-ci: Switch kernel for LAVA jobs to 5.5Tomeu Vizoso2020-02-042-2/+2
| | | | | | | | | All fixes we were carrying in our branch have been merged already. Signed-off-by: Tomeu Vizoso <[email protected]> Reviewed-by: Alyssa Rosenzweig <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3692> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3692>
* panfrost: Use size0 when calculating the offset to a depth levelAlyssa Rosenzweig2020-02-042-7/+12
| | | | | | | | | | Previously, we were using cubemap_stride and sometimes overwriting other BOs such as shaders. Signed-off-by: Alyssa Rosenzweig <[email protected]> Signed-off-by: Tomeu Vizoso <[email protected]> Reviewed-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3692>
* panfrost: Only clamp the LOD to disable mipmapping when neededTomeu Vizoso2020-02-041-6/+7
| | | | | | | | | Otherwise, we may be incrementing max_lod over the limit, causing a DATA_INVALID_FAULT. Signed-off-by: Tomeu Vizoso <[email protected]> Reviewed-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3692>
* panfrost: Fix decoding of tiled 3D texturesTomeu Vizoso2020-02-041-2/+2
| | | | | | | | | | From decoding cmd streams generated by the blob, the pointers in the payload don't seem to include those that refer to different depth levels when the texture is in tiled format. Signed-off-by: Tomeu Vizoso <[email protected]> Reviewed-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3692>
* st/mesa: use uint-result for sampling stencil buffersErik Faye-Lund2020-02-041-4/+5
| | | | | | | | | | Otherwise, we end up mismatching the result-type and the sampler-type. Fixes: 642125edd97 ("st/mesa: use uint-samplers for sampling stencil buffers") Reviewed-by: Marek Olšák <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3680> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3680>
* pan/midgard: Remove unused variableAlyssa Rosenzweig2020-02-041-2/+0
| | | | | | | | | | | ../src/panfrost/midgard/mir.c: In function ‘mir_bytemask_of_read_components_index’: ../src/panfrost/midgard/mir.c:471:18: warning: unused variable ‘mask’ [-Wunused-variable] 471 | uint16_t mask = 0; Signed-off-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Tomeu Vizoso <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3684> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3684>
* pan/midgard: Check for null constsAlyssa Rosenzweig2020-02-041-0/+2
| | | | | | | | | | | | | | Valid shaders shouldn't hit this, but Coverity doesn't know that. CID 1458029: (FORWARD_NULL) Passing null pointer "consts" to "print_scalar_field", which dereferences it. Tomeu: Fix name of variable Signed-off-by: Alyssa Rosenzweig <[email protected]> Signed-off-by: Tomeu Vizoso <[email protected]> Reviewed-by: Tomeu Vizoso <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3684>
* panfrost: Avoid overlapping copyAlyssa Rosenzweig2020-02-041-1/+3
| | | | | | | | | | | | | CID 1457486: Memory - corruptions (OVERLAPPING_COPY) Assigning "(*attr).extra_flags = (*attr).size = 0U" to "(*attr).stride", which have overlapping memory +locations. Coverity. Signed-off-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Tomeu Vizoso <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3684>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-05 00:08:15 +0000