aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* replace all F_DUPFD_CLOEXEC with os_dupfd_cloexec()Eric Engestrom2020-06-1819-23/+47
| | | | | | | | | | | All squashed into a single commit because it shouldn't have any behaviour change, except that it might work now on platforms where it was broken because F_DUPFD_CLOEXEC is not supported but FD_CLOEXEC is. Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Kristian H. Kristensen <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5369>
* util: introduce os_dupfd_cloexec() helperEric Engestrom2020-06-182-0/+55
| | | | | | | | | | Adapted from wayland's wl_os_dupfd_cloexec(). Suggested-by: Kristian H. Kristensen <[email protected]> Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Kristian H. Kristensen <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5369>
* util/os_file: replace broken windows-detection code with detect_os.hEric Engestrom2020-06-181-3/+3
| | | | | | | | | | The meson-windows-vs2019 job was going down the `!defined(WIN32)` path, leading to a broken build once that path contained non-windows code. Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Kristian H. Kristensen <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5369>
* ci: disable the windows tests until the runner can be stabilized againEric Anholt2020-06-181-1/+1
| | | | | | | | | | | I've been getting a stream of errors from Marge today like: FAILED: src/gallium/drivers/llvmpipe/lp_test_conv.exe link @src/gallium/drivers/llvmpipe/lp_test_conv.exe.rsp LINK : fatal error LNK1102: out of memory [1080/1141] Compiling C object src/gallium/frontends/wgl/945cc3d@@wgl@sta/stw_getprocaddress.c.obj Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5534>
* docs: remove plain-text copy of versions.rstEric Engestrom2020-06-181-1514/+0
| | | | | | | | There's no need to keep both, so let's clean things up a bit. Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5178>
* khronos-update.py: add script to simplify update of Khronos headers & xml filesEric Engestrom2020-06-181-0/+202
| | | | | | | | | | | | | The idea is to have the canonical source of each of those files available without having to remember anything, and to be able to update all the Vulkan files by simply running `bin/khronos-update.py vulkan`. The script also handles the fact all the EGL/GL/GLES* headers depend on the KHR header, and the former should not be updated without updating the latter. Signed-off-by: Eric Engestrom <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5177>
* zink: enable xfb extension in screen creationMike Blumenkrantz2020-06-172-3/+27
| | | | | | | | | switch around the feature enabling as well since extensions need the related feature to also be enabled in order to function fixes mesa/mesa#2868 Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5163>
* zink: switch to passing VkPhysicalDeviceFeatures2 in VkDeviceCreateInfoMike Blumenkrantz2020-06-171-1/+4
| | | | | | | | extensions need to have their feature structs passed in pNext to be enabled, so switch to using the feature struct here in preparation for that Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5163>
* zink: set PIPE_CAP_VIEWPORT_TRANSFORM_LOWERED and remove POS special casingMike Blumenkrantz2020-06-172-16/+3
| | | | | | | | this cap creates a different varying output which remains constant to be emitted by xfb, allowing us to drop the special-casing code in ntv Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5163>
* zink: implement transform feedback support to finish off opengl 3.0Mike Blumenkrantz2020-06-1711-22/+349
| | | | | | | | | | | | this adds: * context hooks for gallium stream output methods * handling for xfb-related queries * barrier management for pausing and resuming xfb loosely based on patches originally written by Dave Airlie <[email protected]> Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5163>
* zink: implement streamout and xfb handling in ntvMike Blumenkrantz2020-06-175-8/+241
| | | | | | | | | | this translates streamout info into xfb decorations and adds some workaround handling for spurious gl_PointSize values partly based on patches originally written by Dave Airlie <[email protected]> Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5163>
* zink: add spirv_builder methods for OpVectorExtractDynamic and ↵Mike Blumenkrantz2020-06-172-1/+45
| | | | | | | | | OpVectorInsertDynamic based on spirv specs Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5163>
* zink: add spirv builder util functions for emitting xfb decorationsMike Blumenkrantz2020-06-172-0/+36
| | | | | | | based on patches originally written by Dave Airlie <[email protected]> Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5163>
* zink: use '2' variants for device props/feats, check features for ext enablingMike Blumenkrantz2020-06-171-3/+21
| | | | | | | | | technically both the extension and feature should be checked when enabling extensions, and some features cannot be properly enabled without using the more descriptive versions of these APIs Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5163>
* turnip: use u_format for packing gmem clear valuesJonathan Marek2020-06-171-212/+31
| | | | | Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5485>
* docs: fixup relnotes after rst-conversionErik Faye-Lund2020-06-1725-0/+2360
| | | | | Acked-by: Eric Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5468>
* radv/aco: enable FP16 features/extensions on GFX9+Samuel Pitoiset2020-06-174-4/+6
| | | | | | | | | This enables shaderFloat16, VK_AMD_gpu_shader_half_float and VK_AMD_gpu_shader_int16. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5347>
* aco: fix validation of opsel when set for the definitionRhys Perry2020-06-171-4/+4
| | | | | | Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5521>
* turnip: use draw states for input attachmentsJonathan Marek2020-06-173-22/+54
| | | | | Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5446>
* turnip: input attachment descriptor set reworkJonathan Marek2020-06-176-383/+211
| | | | | | | | | | | | Implement GMEM input attachments by using non-bindless texture state which is emitted at the start of every subpass. This achieves two things: * More vulkan-like CmdBindDescriptorSets * Fixing secondary command buffer input attachments with GMEM Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5446>
* turnip: refactor draw states and dynamic statesJonathan Marek2020-06-174-500/+381
| | | | | | | | | This reworks dynamic states to use draw states, and reworks draw states. This moves towards doing as little as possible in bind_draw_states. Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5446>
* turnip: delete dead dynamic state codeJonathan Marek2020-06-172-173/+0
| | | | | | | Remove unused code, split this out to reduce the diff in the next patch. Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5446>
* turnip: improve dirty bit handling a bitJonathan Marek2020-06-172-34/+22
| | | | | | | | | | | | | | This moves some logic out of bind_draw_states, moving towards the eventual goal of doing very little in bind_draw_states. Split this out as a separate patch to make the DIRTY_INPUT_ATTACHMENTS more visible: it can be safely removed because pipelines are subpass specific, so there will always be a pipeline change to go with the CmdBeginRenderPass and CmdNextSubpass (the CmdBindPipeline may not be in the subpass, but the draw that flushes the pipeline update will be). Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5446>
* turnip: move descriptor set BO tracking to CmdBindDescriptorSetsJonathan Marek2020-06-171-37/+16
| | | | | | | This avoids the duplicated code. Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5446>
* turnip: compute and graphics have completely separate stateJonathan Marek2020-06-171-11/+1
| | | | | | | | | The comment about fragment shader state overwriting compute shader state is wrong, if either path is overwriting the other's state then it is a mistake. Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5446>
* tu: Actually remove dead variables after io loweringConnor Abbott2020-06-171-3/+8
| | | | | | | I forgot that their derefs would still be lying around, so we need to eliminate them first. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5519>
* ir3: Don't calculate num_samp ourselvesConnor Abbott2020-06-171-9/+5
| | | | | | | In addition to duplicating what core NIR does better, this was wrong for Vulkan, where it should be 0 as there are no non-bindless samplers. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5519>
* tu: Set num_components to 0 when building bindless intrinsicsConnor Abbott2020-06-171-2/+2
| | | | | Fixes: 167fa288 (" nir/validate: validate intr->num_components") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5520>
* tu: Remove tu_shader_compile_optionsConnor Abbott2020-06-173-77/+54
| | | | | | | | | The only two fields were always true, and I don't think we'd ever have use for them. If we want to disable optimizations then we'd need a different approach, and I don't even know what include_binning_pass was for. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5500>
* tu: Use the ir3 shader APIConnor Abbott2020-06-173-225/+71
| | | | | | | | This will be necessary once we start compiling multiple variants due to different const size limits, and it will also be necessary for properly implementing the pipeline cache. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5500>
* tu: Remove num_samp hackConnor Abbott2020-06-171-3/+7
| | | | | | | Delete the variables so that ir3 thinks there are no samplers and images instead. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5500>
* ir3: Pass reserved_user_consts to ir3_shader_from_nir()Connor Abbott2020-06-173-4/+5
| | | | | | | | | | ir3_shader_from_nir() calls ir3_optimize_nir(), which currently sets up the const state. However, we need to know the number of user consts reserved by the driver before setting up the const state, which means that this information needs to be passed into ir3_shader_from_nir() somehow rather than being set in the shader. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5500>
* pan/mdg: Reassociate adds for multiply-by-twoAlyssa Rosenzweig2020-06-171-1/+4
| | | | | | | | | | | | Only a single shader-db change it looks like, and not even from scheduling, no fun. instructions helped: shader31 MESA_SHADER_FRAGMENT: 64 -> 63 (-1.56%) quadwords helped: shader31 MESA_SHADER_FRAGMENT: 66 -> 65 (-1.52%) registers HURT: shader31 MESA_SHADER_FRAGMENT: 2 -> 3 (50.00%) Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5475>
* pan/mdg: Canonicalize (x * 2.0) to (x + x)Alyssa Rosenzweig2020-06-171-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lets the previous commit kick in to schedule to either a multiply or an add. GLES2 shader-db: total instructions in shared programs: 50514 -> 50459 (-0.11%) instructions in affected programs: 7436 -> 7381 (-0.74%) helped: 14 HURT: 7 helped stats (abs) min: 2 max: 8 x̄: 5.00 x̃: 5 helped stats (rel) min: 0.95% max: 1.14% x̄: 1.07% x̃: 1.08% HURT stats (abs) min: 2 max: 3 x̄: 2.14 x̃: 2 HURT stats (rel) min: 0.85% max: 8.57% x̄: 2.73% x̃: 1.26% 95% mean confidence interval for instructions value: -4.37 -0.87 95% mean confidence interval for instructions %-change: -0.91% 1.31% Inconclusive result (%-change mean confidence interval includes 0). total bundles in shared programs: 25680 -> 25573 (-0.42%) bundles in affected programs: 6148 -> 6041 (-1.74%) helped: 37 HURT: 7 helped stats (abs) min: 1 max: 9 x̄: 3.14 x̃: 2 helped stats (rel) min: 0.63% max: 8.33% x̄: 2.02% x̃: 2.13% HURT stats (abs) min: 1 max: 2 x̄: 1.29 x̃: 1 HURT stats (rel) min: 0.88% max: 11.11% x̄: 3.92% x̃: 1.30% 95% mean confidence interval for bundles value: -3.32 -1.54 95% mean confidence interval for bundles %-change: -2.00% -0.14% Bundles are helped. total quadwords in shared programs: 40887 -> 40815 (-0.18%) quadwords in affected programs: 14203 -> 14131 (-0.51%) helped: 61 HURT: 2 helped stats (abs) min: 1 max: 4 x̄: 1.21 x̃: 1 helped stats (rel) min: 0.16% max: 11.11% x̄: 1.11% x̃: 0.57% HURT stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 HURT stats (rel) min: 2.86% max: 4.00% x̄: 3.43% x̃: 3.43% 95% mean confidence interval for quadwords value: -1.32 -0.96 95% mean confidence interval for quadwords %-change: -1.46% -0.48% Quadwords are helped. total registers in shared programs: 3916 -> 3913 (-0.08%) registers in affected programs: 46 -> 43 (-6.52%) helped: 5 HURT: 1 helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 helped stats (rel) min: 10.00% max: 33.33% x̄: 14.89% x̃: 10.00% HURT stats (abs) min: 2 max: 2 x̄: 2.00 x̃: 2 HURT stats (rel) min: 50.00% max: 50.00% x̄: 50.00% x̃: 50.00% 95% mean confidence interval for registers value: -1.79 0.79 95% mean confidence interval for registers %-change: -33.51% 25.37% Inconclusive result (value mean confidence interval includes 0). total threads in shared programs: 2455 -> 2454 (-0.04%) threads in affected programs: 5 -> 4 (-20.00%) helped: 1 HURT: 1 helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 helped stats (rel) min: 100.00% max: 100.00% x̄: 100.00% x̃: 100.00% HURT stats (abs) min: 2 max: 2 x̄: 2.00 x̃: 2 HURT stats (rel) min: 50.00% max: 50.00% x̄: 50.00% x̃: 50.00% total loops in shared programs: 6 -> 6 (0.00%) loops in affected programs: 0 -> 0 helped: 0 HURT: 0 total spills in shared programs: 168 -> 168 (0.00%) spills in affected programs: 0 -> 0 helped: 0 HURT: 0 total fills in shared programs: 186 -> 186 (0.00%) fills in affected programs: 0 -> 0 helped: 0 HURT: 0 Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5475>
* pan/mdg: Allow scheduling "x + x" to multipliersAlyssa Rosenzweig2020-06-171-0/+53
| | | | | | | | | | One of the neat things with Midgard's wacky VLIW... on VADD/SADD this is (x + x) literally, on VMUL/SMUL/VLUT this is (x * 2.0) where the 2.0 is exactly representable in FP16 so it fits nicely as an inline constant. So we don't need to restrict its scheduling. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5475>
* pan/mdg: Factor out unit checkAlyssa Rosenzweig2020-06-171-1/+10
| | | | | | | We'd like to do something a bit more complicated. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5475>
* aco: fix sub-dword opsel/sdwa checksRhys Perry2020-06-171-3/+3
| | | | | | | | | These should all check if the operand has a regclass. The opsel check should also be skipped post-RA. Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5504>
* aco: fix validation error from vgpr spill/restore codeRhys Perry2020-06-171-2/+2
| | | | | | Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5504>
* turnip: fix cubic filtering with CmdBlitImageJonathan Marek2020-06-173-19/+26
| | | | | | | | | | This fixes the newly added cubic blit_image tests for A650, by falling back to the 3D path and setting the filter correctly. Note: there are still failures with the texture filtering tests. Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5509>
* turnip: fix 3D path always being used for CmdBlitImageJonathan Marek2020-06-171-1/+1
| | | | | | | | | | This change accidentally made it into 72d7df40a5e5b50, and started causing blit_image flakes (because of the issue fixed in the previous patch) Fixes: 72d7df40a5e5b50 ("turnip: add layered 3D path clear for CmdClearAttachments") Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5509>
* turnip: set VFD_INDEX_OFFSET in 3D clear/blit pathJonathan Marek2020-06-172-6/+8
| | | | | | | | This was missing an causing flakes when used after a test that set it to a non-zero value. Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5509>
* spirv: do not set num_components for non-vectorized mbcnt_amd intrinsicSamuel Pitoiset2020-06-171-1/+2
| | | | | | | Fixes: 167fa2887f0 ("nir/validate: validate intr->num_components") Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Rob Clark <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5493>
* st_glsl_to_nir: fix potential use after freeTimothy Arceri2020-06-171-2/+14
| | | | | | | | | | | | | | | When updating the shader info used by GL for the API we must remember to make sure to restore the pointers to its own name and label strings. There are a number of ways in which the nir copy of these strings can be freed before GL is finished with them. Fixes: 36be8c2fcf94 ("st/glsl_to_nir: use nir_shader_gather_info()") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2875 Reviewed-by: Marek Olšák <[email protected]> Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5488>
* glsl: small optimisation fix for uniform array resizingTimothy Arceri2020-06-171-15/+10
| | | | | | | | | The fix in the previous patch removed an erronous attempt to skip resizing variable types in each stage. Now that has been removed iterating over each shader stage is no longer required here. Reviewed-by: Tapani Pälli <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5487>
* glsl: fix uniform array resizing in the nir linkerTimothy Arceri2020-06-171-44/+42
| | | | | | | | | | | | | | | | | | | | | | The initial support tried to match uniform variables from different shaders based on the variables pointer. This will obviously never work, instead here we use the variables name whcih also means we must disable this optimisation for spirv. Using the base variable name works because when collecting uniform references we never iterate past the first array dimension, and only support resizing 1D arrays (we also don't support resizing arrays inside structs). We also drop the resized bool as we can't skip processing the var just because is was resized in another shader, we must resize the var in all shaders. Fixes: a34cc97ca3e1 ("glsl: when NIR linker enable use it to resize uniform arrays") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3130 Reviewed-by: Tapani Pälli <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5487>
* anv: Add VK_EXT_custom_border_color to relnotesIván Briano2020-06-171-1/+1
| | | | | | Missed it on 5425968d2e46eb3311a75f4bf7bedb1d9dd59459 Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5136>
* anv: enable VK_EXT_pipeline_creation_cache_controlIván Briano2020-06-173-1/+9
| | | | | Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5136>
* anv: implement VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXTIván Briano2020-06-172-14/+41
| | | | | | | | | | | | | | | | v2: * Set pPipeline to NULL in the corresponding graphics/compute_create_pipeline function. * Keep current ANV behavior of bailing on the first real error. v3: * Don't return early if the pipeline succeeded. v:4(5?): * Simplify return conditions. Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5136>
* anv: support externally synchronized pipeline cachesIván Briano2020-06-172-13/+32
| | | | | | | | Implement the VK_PIPELINE_CACHE_CREATE_EXTERNALLY_SYNCHRONIZED_BIT_EXT bits of the VK_EXT_pipeline_creation_cache_control extension. Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5136>
* intel/compiler: Remove unnecessary optimization for MULSagar Ghuge2020-06-161-8/+0
| | | | | | | | | | | | 2 source instruction only support immediate for src1 operand, so no point in adding optimization condition for src0 oprand. v2: - Update commit message and don't remove ADD optimization (Matt Turner) Signed-off-by: Sagar Ghuge <[email protected]> Reviewed-by: Matt Turner <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5341>