summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* radv: Squelch possibly-undefined warningEric Anholt2020-02-181-1/+1
| | | | | | | | The same condition is used in the def as in the use, but gcc wasn't figuring it out. Reviewed-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3867>
* ci: Extend the a630 flake list to reduce spurious failures.Eric Anholt2020-02-181-1/+13
| | | | | | | | | | These are the tests I've seen flake twice while logged in to the IRC channel this year. Also include fragment_out.random.5 which fully spuriously failed recently. Closes: #2516 Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3862> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3862>
* mesa: fix immediate mode with tessellation and varying patch verticesMarek Olšák2020-02-181-0/+2
| | | | | | | Cc: 19.3 20.0 <[email protected]> Reviewed-by: Mathias Fröhlich <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3861> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3861>
* mesa: don't use memset in glDrawArraysMarek Olšák2020-02-181-1/+1
| | | | | Reviewed-by: Mathias Fröhlich <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3861>
* mesa: document _mesa_prim::begin/endMarek Olšák2020-02-181-0/+12
| | | | | Reviewed-by: Mathias Fröhlich <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3861>
* vbo: remove redundant code in vbo_exec_fixup_vertexMarek Olšák2020-02-181-7/+0
| | | | | | | Callers of this function also set FLUSH_STORED_VERTICES for attr == 0. Reviewed-by: Mathias Fröhlich <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3861>
* vbo: remove dead code in vbo_can_merge_primsMarek Olšák2020-02-181-4/+3
| | | | | | | This is only used by immediate mode and the values are immutable. Reviewed-by: Mathias Fröhlich <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3861>
* st/mesa: try to fix MSVC build failure due to ALWAYS_INLINEMarek Olšák2020-02-181-1/+4
| | | | | | Fixes: 11db8e0e00a72884ba9f ("st/mesa: optimize st_update_array with ALWAYSINLINE") Tested-by: Eric Engestrom <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3861>
* freedreno/registers: cleanup CP_SET_MARKERRob Clark2020-02-185-16/+27
| | | | | | | | | | | 1) Name RM6_COMPUTE, and rename RM6_ENDVIS (from RM6_BLIT) to better reflect what it actually does 2) Cleanup open-coded mode enum values 3) Removed unused 0x10 Signed-off-by: Rob Clark <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3833> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3833>
* freedreno: quiet INFO_MSGRob Clark2020-02-182-1/+13
| | | | | | | Probably not useful unless LIBGL_DEBUG is set to something. Signed-off-by: Rob Clark <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3833>
* freedreno/a6xx: few register updatesRob Clark2020-02-182-3/+66
| | | | | | | | | Nothing used by mesa, but crashdec tool uses a few of these. And since the practice is these days to sync mesa->envytools, adding these on the mesa side first. Signed-off-by: Rob Clark <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3833>
* freedreno/registers: teach gen_header.py about a3xx_regidRob Clark2020-02-182-6/+2
| | | | | | | | | | This is a builtin type (treated as uint, but with special type-aware decoding) in envytools/cffdump. Lets teach gen_header.py about it and drop the enum hack in the xml so I don't have to keep deleting the enum when I sync the xml back to the freedreno envytools tree. Signed-off-by: Rob Clark <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3833>
* meson: explicitly disallow unsupported build directory layoutEric Engestrom2020-02-181-0/+4
| | | | | | | | Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2512 Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Dylan Baker <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3832> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3832>
* intel/gen12: Take into account opcode when decoding SWSBCaio Marcelo de Oliveira Filho2020-02-182-3/+7
| | | | | | | | | | | | | | | | The interpretation of the fields is different depending whether the instruction is a SEND/MATH or not. This fixes the disassembly output for non-SEND/MATH instructions that have both in-order and out-of-order dependencies. Their dependencies were wrongly represented as `@A $B` when the correct would be `@A $B.dst`. Fixes: 6154cdf924f ("intel/eu/gen12: Add auxiliary type to represent SWSB information during codegen.") Fixes: 83612c01271 ("intel/disasm/gen12: Disassemble software scoreboard information.") Acked-by: Francisco Jerez <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3660> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3660>
* panfrost: Remove enum panfrost_memory_layoutAlyssa Rosenzweig2020-02-185-50/+28
| | | | | | | | | | It duplicates mali_texture_layout. Let's use the native hardware enum and spare a pointless translation. Signed-off-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3854> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3854>
* radv: Advertise VK_KHR_shader_non_semantic_infoCaio Marcelo de Oliveira Filho2020-02-182-1/+2
| | | | | | | Reviewed-by: Jason Ekstrand <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3856> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3856>
* anv: Advertise VK_KHR_shader_non_semantic_infoCaio Marcelo de Oliveira Filho2020-02-182-0/+2
| | | | | | Reviewed-by: Jason Ekstrand <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3856>
* vulkan: Update the XML and headers to 1.2.133Jason Ekstrand2020-02-182-11/+25
| | | | | Reviewed-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3856>
* panfrost: Debitfieldize mali_uniform_buffer_metaAlyssa Rosenzweig2020-02-183-28/+25
| | | | | | | | | | | It fits snugly in a u64, just give a macro for direct computation rather than fudging around with bitfields. Not sure if this actually matters with well-optimized compilers but it makes the code subjectively cleaner so it's worth it for that if nothing else. Signed-off-by: Alyssa Rosenzweig <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3838> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3838>
* panfrost: Avoid reading GPU memory when packing verticesAlyssa Rosenzweig2020-02-181-17/+18
| | | | | | | These occurred unintentionally as a byproduct of bitfields, etc. Whoops. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3838>
* panfrost: Cleanup transfer_mapAlyssa Rosenzweig2020-02-181-22/+1
| | | | | | | | | | A lot of these checks are obsolete since we've started tracking BO accesses correctly. Signed-off-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3849> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3849>
* panfrost: Update scoreboarding notesAlyssa Rosenzweig2020-02-181-10/+6
| | | | | | | | | | Our understanding of the set/write value jobs has evolved, so let's update the rules. Signed-off-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3836> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3836>
* panfrost: Rewrite scoreboarding routinesAlyssa Rosenzweig2020-02-187-494/+117
| | | | | | | | | | | | | | | | | | | | | | | Rather than manipulating job descriptor headers as fat pointers (slow) and using fancy manipulation functions for programatically building the tree in arbitrary orders (slow and complicated) and then having to do a topological sort at runtime every frame (slow) which requires traversing said headers in GPU memory (slow!)... we finally know enough about the hardware to just get things right the first time, or second for next_job linking. So rip out all that code and replace it with a much better routine to create, upload, and queue a job all in one (since now it's the same operation essentially - which is much better for memory access patterns, by the way) and most everything falls into place gracefully according to the rules we've set out. Even wallpapering isn't *so* terrible if you just... move that one little... giant... hack out of sight... ahem.... panfrost_scoreboard_link_batch is no longer a bottleneck, mostly because it no longer exists :-) Signed-off-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3836>
* panfrost: Print synced traces to stderrAlyssa Rosenzweig2020-02-183-4/+8
| | | | | | | | To match the existing behaviour. Signed-off-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3836>
* panfrost: Implement PAN_DBG_SYNC with pandecode/minimalAlyssa Rosenzweig2020-02-183-25/+8
| | | | | | | | This way we avoid duplicating job traversal logic. Signed-off-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3836>
* pan/decode: Cleanup pandecode_jcAlyssa Rosenzweig2020-02-182-23/+3
| | | | | | | | | Some of this code is, to put it mildly, impossibly ancient horsedropping crazy cruft. Signed-off-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3836>
* pan/decode: Add `minimal` modeAlyssa Rosenzweig2020-02-183-9/+16
| | | | | | | | | We would like a mode to skip decoding job payloads so we can just inspect for faults. Signed-off-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3836>
* st/nir: Unify inputs_read/outputs_written before serializing NIRDanylo Piliaiev2020-02-181-22/+19
| | | | | | | | | | | | | | | Otherwise input/output interfaces won't be unified when reading NIR from a cache. Fixes piglit test on iris: clip-distance-vs-gs-out.shader_test Fixes: 19ed12af Signed-off-by: Danylo Piliaiev <[email protected]> Reviewed-by: Timothy Arceri <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3787> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3787>
* zink: do not convert bools to/from uintErik Faye-Lund2020-02-171-48/+45
| | | | | | | | | | Since bools are the only 1-bit type, we always know if an SSA-def is a bool or not. So we don't need to marshal it to uint. So let's simplify the code a bit here. Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3763> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3763>
* zink/spirv: uint -> rawErik Faye-Lund2020-02-171-9/+13
| | | | | | | | Similarly to the previous commit, the important bit here is the rawness of these variables, not the uintness. So let's rename these to reflect this. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3763>
* zink/spirv: unit_value -> raw_valueErik Faye-Lund2020-02-171-5/+5
| | | | | | | The point here isn't that the value is uint, but that is't untreated. So raw seems more fitting as a description. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3763>
* zink/spirv: rename functions a bitErik Faye-Lund2020-02-171-26/+25
| | | | | | | | The code is about to change so the whole uint-story isn't as true as it used to be. So let's soften up the semantics a bit here; we only care about if we're doing a typed ot untyped store here, really. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3763>
* zink/spirv: prefer store_dest over store_dest_uintErik Faye-Lund2020-02-171-6/+6
| | | | Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3763>
* zink/spirv: do not reinvent store_destErik Faye-Lund2020-02-171-2/+1
| | | | Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3763>
* zink: confused compilation macro usage for zink in target helpers.luc2020-02-171-1/+1
| | | | | | | Fixes: 8d46e35d16e ("zink: introduce opengl over vulkan") Reviewed-by: Erik Faye-Lund <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3831> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3831>
* zink: do not report texture-samplers for unsupported stagesErik Faye-Lund2020-02-171-3/+9
| | | | | | | | This caused the max combined samplers to be reported as artificially high. Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3826> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3826>
* zink: fix binding-usageErik Faye-Lund2020-02-173-40/+57
| | | | | | | | | | | | | Rewriting the variable bindings is nasty and error-prone, and this code triggered an assert when trying to resolve API bindings into Vulkan bindings. This code still needs some tweaks, but this makes things much better, and fixes a few bugs where we incorrectly accounted for the array-indexes. Fixes: 1c3f4c07047 ("zink: fixup sampler-usage") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3826>
* radv: add a comment about VK_AMD_mixed_attachment_samples on GFX6-GFX7Samuel Pitoiset2020-02-171-0/+1
| | | | | | | | | There is some CTS failures. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3808> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3808>
* radv: enable VK_NV_compute_shader_derivatives on GFX6-GFX7Samuel Pitoiset2020-02-171-1/+1
| | | | | | | | All Crucible tests pass. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3808>
* radv: enable VK_EXT_sampler_filter_minmax on GFX6Samuel Pitoiset2020-02-172-2/+2
| | | | | | | | Works fine. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3808>
* radv: enable shaderStorageImageMultisample on GFX6-GFX7Samuel Pitoiset2020-02-171-2/+2
| | | | | | | | It was disabled because untested, but CTS is happy with it. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3808>
* egl: Implement getImage/putImage on pbuffer swrast.Mathias Fröhlich2020-02-174-5/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | This change adds getImage/putImage callbacks to the swrast pbuffer loader extension. This fixes a recent crash with Weston as well as a crashing test with classic swrast without an official gitlab issue. v2: Determine bytes per pixel differently and fix non X11 builds. v3: Plug memory leak and fix crash on out of bounds access. (Daniel Stone) v4: Follow the code structure of the wayland get/put image implementation - hopefully being more obvious. Handle 64 bits formats. Use BufferSize directly. (Emil Velikov) v5: Change pixel size computation. (Eric Engestrom) Reviewed-by: Daniel Stone <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2219 Fixes: d6edccee8da "egl: add EGL_platform_device support" Signed-off-by: Mathias Fröhlich <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3711> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3711>
* lima: rename lima_submit to lima_jobQiang Yu2020-02-1714-331/+331
| | | | | | | Reviewed-by: Vasily Khoruzhick <[email protected]> Signed-off-by: Qiang Yu <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3755> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3755>
* lima: move dump check to macro for lima_dump_command_stream_printQiang Yu2020-02-172-7/+10
| | | | | | | | | This can prevent the execution of some function like lima_ctx_buff_va which is passed in as parameter when no dump case. Reviewed-by: Vasily Khoruzhick <[email protected]> Signed-off-by: Qiang Yu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3755>
* lima: enable multi submit optimizationQiang Yu2020-02-173-2/+6
| | | | | | | | Also provide a debug option to disable it. Reviewed-by: Vasily Khoruzhick <[email protected]> Signed-off-by: Qiang Yu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3755>
* lima: optinal flush submit in lima_clearQiang Yu2020-02-173-3/+16
| | | | | | | | | flush current submit only when there is any draw pending instead of flush all submits. Reviewed-by: Vasily Khoruzhick <[email protected]> Signed-off-by: Qiang Yu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3755>
* lima: use per submit dump fileQiang Yu2020-02-177-93/+136
| | | | | | | | | | After multi lima_submit, commands for one lima_submit may not be flushed when change framebuffer. But we want to track command stream for one submit, so save dump file for each submit. Reviewed-by: Vasily Khoruzhick <[email protected]> Signed-off-by: Qiang Yu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3755>
* lima: move framebuffer info to lima_submitQiang Yu2020-02-174-80/+91
| | | | | | | | | | | draw code path does not use framebuffer info, only flush code path use it now. Use zsbuf/cbuf in submit instead of context. Reviewed-by: Vasily Khoruzhick <[email protected]> Signed-off-by: Qiang Yu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3755>
* lima: move clear into submit (v2)Qiang Yu2020-02-175-21/+17
| | | | | | | | | | | | | | | clear info is needed when submit flush and may be changed after framebuffer switch, so we need to move it into submit. This also fixes 5 dEQP tests as a side effect: clear info is per submit so clear value when one submit won't affect next submit. v2: remove fixed dEQP test from CI list. Reviewed-by: Vasily Khoruzhick <[email protected]> Signed-off-by: Qiang Yu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3755>
* lima: move damage_rect into lima_submitQiang Yu2020-02-175-27/+33
| | | | | | | | damage_rect is preserved across draws. Reviewed-by: Vasily Khoruzhick <[email protected]> Signed-off-by: Qiang Yu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3755>