summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* cherry-ignore: update for 19.2.3 cycleDylan Baker2019-11-041-0/+5
|
* anv/tests: Zero-initialize instancesJason Ekstrand2019-11-046-6/+14
| | | | | | | | | Some of the tests were actually relying on some of those uninitialized bits to be non-zero. In particular, a couple want use_softpin = true. Cc: [email protected] Reviewed-by: Lionel Landwerlin <[email protected]> (cherry picked from commit 9076e9f3751341063679eb227116060070549a37)
* anv: Fix a potential BO handle leakJason Ekstrand2019-11-041-1/+3
| | | | | | Fixes: 731c4adcf9b "anv/allocator: Add support for non-userptr" Reviewed-by: Lionel Landwerlin <[email protected]> (cherry picked from commit bb257e1852473e3bc49bb9e0fe014741894f7bd0)
* mesa: enable msaa in clear_with_quad if neededPierre-Eric Pelloux-Prayer2019-11-041-0/+1
| | | | | | | | | | | | If the DrawBuffer sample count is > 1 and msaa is enabled we must also enable msaa when clearing it. Fixes: ea5b7de138b ("radeonsi: make gl_SampleMaskIn = 0x1 when MSAA is disabled") Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1991 Reviewed-by: Marek Olšák <[email protected]> Tested-by: Witold Baryluk <[email protected]> (cherry picked from commit 8a723282e3f7a312ab0ca3aa9157e5b76ec182af)
* anv: Remove _mesa_locale_init/fini calls.Bas Nieuwenhuizen2019-11-041-3/+0
| | | | | | | | | | The resulting locale is not used for Vulkan, and it is not reference counted, giving issues when multiple instances are created. CC: 19.2 19.3 <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> (cherry picked from commit 3e86d553a470c484b6a2c60bc7866759ec21fea5)
* turnip: Remove _mesa_locale_init/fini calls.Bas Nieuwenhuizen2019-11-041-3/+0
| | | | | | | | | | The resulting locale is not used for Vulkan, and it is not reference counted, giving issues when multiple instances are created. CC: 19.2 19.3 <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> (cherry picked from commit 72f858fc07746eb1d7360b47636006202a075e84)
* radv: Remove _mesa_locale_init/fini calls.Bas Nieuwenhuizen2019-11-041-3/+0
| | | | | | | | | | The resulting locale is not used for Vulkan, and it is not reference counted, giving issues when multiple instances are created. CC: 19.2 19.3 <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> (cherry picked from commit 344ba56b0f36e77c3d4a935717854f1bf8000a2e)
* radv: Fix timeout handling in syncobj wait.Bas Nieuwenhuizen2019-11-041-1/+1
| | | | | | | | libdrm returns -errno instead of directly the ioctl ret of -1. Fixes: 1c3cda7d277 "radv: Add syncobj signal/reset/wait to winsys." Reviewed-by: Samuel Pitoiset <[email protected]> (cherry picked from commit ec770085c270cb167c02f299f6985744682933b1)
* nv50/ir: mark STORE destination inputs as usedIlia Mirkin2019-11-041-0/+6
| | | | | | | | | | | Observed an issue when looking at the code generatedy by the image-vertex-attrib-input-output piglit test. Even though the test itself worked fine (due to TIC 0 being used for the image), this needs to be fixed. Signed-off-by: Ilia Mirkin <[email protected]> Cc: [email protected] (cherry picked from commit 1b9d1e13d8e14c348f6d6c8fab5f31e8768a1371)
* etnaviv: fix depth biasJonathan Marek2019-10-312-1/+2
| | | | | | | | | | | Fixes remaining failures in these deqp tests (tested on GC3000/GC7000L): dEQP-GLES2.functional.polygon_offset.* Fixes: 6c3c05dc ("etnaviv: fix polygon offset") Signed-off-by: Jonathan Marek <[email protected]> Reviewed-by: Christian Gmeiner <[email protected]> (cherry picked from commit 7b524e1acbe7d704a9920302529a0e02e8ef9a55)
* intel/blorp: Assign correct view while clearing depth stencilSagar Ghuge2019-10-301-1/+1
| | | | | | | | | | | We never saw any failures regarding this typo but it's good to assign correct stencil view while constructing blorp_params. Fixes: 0cabf93b80d0 "intel/blorp: Add an entrypoint for clearing depth and stencil" Signed-off-by: Sagar Ghuge <[email protected]> Reviewed-by: Nanley Chery <[email protected]> (cherry picked from commit ce208be2d8793029c5abbde51c972ad1f4166701)
* anv: Fix output of INTEL_DEBUG=bat for chained batchesCaio Marcelo de Oliveira Filho2019-10-291-1/+1
| | | | | | | | | | | The anv_batch_bo contents are linked one to another, and when printing we have to start with the first of those. Since in `u_vector` new elements are added to the head, to get the first element we need the vector's tail. Fixes: 32ffd90002b ("anv: add support for INTEL_DEBUG=bat") Reviewed-by: Lionel Landwerlin <[email protected]> (cherry picked from commit e2155158e99e405313d6bc4d4478b92b4234dc4e)
* iris: Disallow incomplete resource creationNanley Chery2019-10-291-2/+6
| | | | | | | | | If a modifier specifies an aux, it must be created. Fixes: 75a3947af46 ("iris/resource: Fall back to no aux if creation fails") Reviewed-by: Sagar Ghuge <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]> (cherry picked from commit d298740a1c1c7798d21a0978d6fa5f72ee97b9fe)
* iris: Don't leak the resource for unsupported modifierNanley Chery2019-10-291-1/+1
| | | | | | | | | Make sure the res struct is free'd before returning. Fixes: 2dce0e94a3d ("iris: Initial commit of a new 'iris' driver for Intel Gen8+ GPUs.") Reviewed-by: Sagar Ghuge <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]> (cherry picked from commit f2fc5dece93019f0bab203247985cf350d541156)
* iris: Clear ::has_hiz when disabling auxNanley Chery2019-10-291-0/+1
| | | | | | Fixes: 2cddc953cd0 ("iris: some initial HiZ bits") Reviewed-by: Kenneth Graunke <[email protected]> (cherry picked from commit 6cd9731d96c4a48252b91881491aa43ba565bf95)
* intel/blorp: Disable depth testing for slow depth clearsNanley Chery2019-10-291-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We'll start doing slow depth clears more often on HIZ_CCS buffers in a future commit. Reduce the performance impact by making them use less bandwidth. From the Depth Test section of the BSpec: This function is enabled by the Depth Test Enable state variable. If enabled, the pixel's ("source") depth value is first computed. After computation the pixel's depth value is clamped to the range defined by Minimum Depth and Maximum Depth in the selected CC_VIEWPORT state. Then the current ("destination") depth buffer value for this pixel is read. and from the Depth Buffer Updates section of the BSpec: If depth testing is disabled or the depth test passed, the incoming pixel's depth value is written to the Depth Buffer. Taken together, it's clear that depth testing isn't necessary to perform a depth buffer clear. Mark Janes and I analyzed this patch with frameretrace and a depthrange piglit test. I disabled HiZ to ensure we'd get slow depth clears. We've observed the bandwidth consumption by the depth buffer access to be cut ~50% on BDW and SKL during depth clears. On a more graphically intensive workload, the Shadowmapping Sascha benchmark, I took the average of 3 runs on a BDW with a display resolution of about 1920x1200 (minus some desktop environment decorations). I measured a 22.61% FPS improvement when HiZ is disabled. v2. The BSpec doesn't mandate this behavior, update comment accordingly. (Ken) Fixes: bc4bb5a7e30 ("intel/blorp: Emit more complete DEPTH_STENCIL state") Reviewed-by: Jason Ekstrand <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]> (cherry picked from commit d5fb9cccdce2d44427582ca6d9201d5ec42fedb2)
* anv: Properly allocate aux-tracking space for CCS_ENanley Chery2019-10-292-3/+5
| | | | | | | | | | add_aux_state_tracking_buffer() actually checks the aux usage when determining how many dwords to allocate for state tracking. Move the function call to the point after the CCS_E aux usage is assigned. Fixes: de3be618016 ("anv/cmd_buffer: Rework aux tracking") Reviewed-by: Kenneth Graunke <[email protected]> (cherry picked from commit d0fcc2dd503f734f10f879ad666c27fd81c44262)
* glsl: Initialize all fields of ir_variable in constructorDanylo Piliaiev2019-10-281-0/+23
| | | | | | | | | | | | Better be safe, even if we could technically avoid this for some fields. Cc: <[email protected]> Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1999 Signed-off-by: Danylo Piliaiev <[email protected]> Tested-by: Witold Baryluk <[email protected]> Reviewed-by: Marek Olšák <[email protected]> (cherry picked from commit 8818e0df742120858b2460a2208fac57d242473a)
* i965: setup sized internalformat for MESA_FORMAT_R10G10B10A2_UNORMTapani Pälli2019-10-281-1/+9
| | | | | | | | | | | | | | | | Commit d2b60e433e5 introduced restrictions (as per GLES spec) on the internal format. We need to setup a sized format for the texture image so framebuffers created with that are considered complete. This change fixes following Android CTS test in AHardwareBufferNativeTests category: SingleLayer_ColorTest_GpuColorOutputAndSampledImage_R10G10B10A2_UNORM Signed-off-by: Tapani Pälli <[email protected]> Fixes: d2b60e433e5 ("mesa/main: R10G10B10_(A2) formats are not color renderable in ES") Reviewed-by: Kenneth Graunke <[email protected]> (cherry picked from commit 412badd059de6f55cbcab10a55d052986a74b4cd)
* bin/gen_release_notes.py: Add a warning if new features are introduced in a ↵Dylan Baker2019-10-281-2/+5
| | | | | | | | | point release Fixes: 86079447da1e00d49db0cbff9a102eb4e71e8702 ("scripts: Add a gen_release_notes.py script") Reviewed-by: Juan A. Suarez <[email protected]> (cherry picked from commit 8a4541aae22e0cdeb063e3fc25c84775d84f4077)
* bin/gen_release_notes.py: html escape all external dataDylan Baker2019-10-281-4/+7
| | | | | | | | | | | | All of these (bug titles, patch titles, features, and people's names) can contain characters that are not valid html. Just escape everything for safety. Fixes: 86079447da1e00d49db0cbff9a102eb4e71e8702 ("scripts: Add a gen_release_notes.py script") Reviewed-by: Eric Engestrom <[email protected]> Reviewed-by: Juan A. Suarez <[email protected]> (cherry picked from commit b153785370c7fa47961a69404448c05f7e3c166c)
* bin/post_release.py: Add .html to hrefsDylan Baker2019-10-281-2/+3
| | | | | | | | | | oops. Fixes: 3226b12a09bbcbd25526fd6da6257057d26ddb31 ("release: Add an update_release_calendar.py script") Reviewed-by: Eric Engestrom <[email protected]> Reviewed-by: Juan A. Suarez <[email protected]> (cherry picked from commit 7e4b87f987f0084f4d69454f274e2c5eb2d799da)
* bin/post_version.py: white space fixesDylan Baker2019-10-281-1/+1
| | | | | | | | Fixes: 3226b12a09bbcbd25526fd6da6257057d26ddb31 ("release: Add an update_release_calendar.py script") Reviewed-by: Eric Engestrom <[email protected]> Reviewed-by: Juan A. Suarez <[email protected]> (cherry picked from commit 5eef803625f3d522440e5dc8f47ba46e02a20c6f)
* bin/post_version.py: Pass version as an argumentDylan Baker2019-10-281-16/+10
| | | | | | | | | | | | I made a bad assumption; I assumed this would be run in the release branch. But we don't do that, we run in the master branch. As a result we need to pass the version as an argument. Fixes: 3226b12a09bbcbd25526fd6da6257057d26ddb31 ("release: Add an update_release_calendar.py script") Reviewed-by: Eric Engestrom <[email protected]> Reviewed-by: Juan A. Suarez <[email protected]> (cherry picked from commit abf9e7ac7bdb26ef203394ccdd5f0a43ceda1493)
* bin/gen_release_notes.py: Return "None" if there are no new featuresDylan Baker2019-10-281-0/+2
| | | | | | | | | | Which is very likely .Z > 0 releases. Fixes: 86079447da1e00d49db0cbff9a102eb4e71e8702 ("scripts: Add a gen_release_notes.py script") Reviewed-by: Eric Engestrom <[email protected]> Reviewed-by: Juan A. Suarez <[email protected]> (cherry picked from commit c6d41e7f0b0c998d9b6f4b1ff55eab9f6cd12ef4)
* bin/gen_release_notes.py: strip '#' from gitlab bugsDylan Baker2019-10-281-1/+1
| | | | | | | | | | If they use the `Fixes: #1` form. Fixes: 86079447da1e00d49db0cbff9a102eb4e71e8702 ("scripts: Add a gen_release_notes.py script") Reviewed-by: Eric Engestrom <[email protected]> Reviewed-by: Juan A. Suarez <[email protected]> (cherry picked from commit df3d4ad82da41c47f6adb2ec4309e873a8f7fd33)
* bin/gen_release_notes.py: fix conditional of bugfixDylan Baker2019-10-281-1/+1
| | | | | | | | | | | Previously this would result in the .0 warning be generated for .z > 0 and the .z == 0 would get the other message. Fixes: 86079447da1e00d49db0cbff9a102eb4e71e8702 ("scripts: Add a gen_release_notes.py script") Reviewed-by: Eric Engestrom <[email protected]> Reviewed-by: Juan A. Suarez <[email protected]> (cherry picked from commit 69f540c0172c0b2b43ba466adee7cfb8842250e2)
* Revert "mesa/main: Fix multisample texture initialize"Illia Iorin2019-10-281-25/+13
| | | | | | | | | | | This reverts commit a113a42e7369a4e43a1db1c9a7a35a3f7175615e. Per https://github.com/KhronosGroup/OpenGL-API/issues/45 it was a wrong way to fix the issue. Signed-off-by: Illia Iorin <[email protected]> Reviewed-by: Marek Olšák <[email protected]> (cherry picked from commit 71d4ece366d5cefe58f503429126a102e688ab42)
* rbug: Fix use of alloca() without #include "c99_alloca.h"Jon Turney2019-10-251-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | [12/60] Compiling C object 'src/gallium/auxiliary/eb820e8@@gallium@sta/rbug_rbug_texture.c.o'. FAILED: src/gallium/auxiliary/eb820e8@@gallium@sta/rbug_rbug_texture.c.o [...] ../src/gallium/auxiliary/rbug/rbug_texture.c: In function 'rbug_send_texture_info_reply': ../src/gallium/auxiliary/rbug/rbug_texture.c:302:21: error: implicit declaration of function 'alloca'; did you mean 'malloc'? [-Werror=implicit-function-declaration] uint32_t *height = alloca(sizeof(uint32_t) * height_len); ^~~~~~ malloc ../src/gallium/auxiliary/rbug/rbug_texture.c:302:21: warning: initialization makes pointer from integer without a cast [-Wint-conversion] ../src/gallium/auxiliary/rbug/rbug_texture.c:303:20: warning: initialization makes pointer from integer without a cast [-Wint-conversion] uint32_t *depth = alloca(sizeof(uint32_t) * height_len); ^~~~~~ cc1: some warnings being treated as errors Include c99_alloca.h to portably make the alloca() prototype available. See also: 498d9d0f, adfb9c5c, fc8139b1 Fixes: 6174cba7 ("rbug: fix transmitted texture sizes") Reviewed-by: Eric Engestrom <[email protected]> Reviewed-by: Christian Gmeiner <[email protected]> (cherry picked from commit 2649609ac540108eb567ddf36bd1ac5ec75691af)
* winsys/svga: Limit the maximum DMA hardware buffer sizeThomas Hellstrom2019-10-251-1/+4
| | | | | | | | | | | | | | | | | | | | The kernel total GMR/DMA size is limited, but it's definitely possible for the kernel to allow a larger buffer allocation to succeed, but command submission using that buffer as a GMR would fail typically causing an application crash. So have the winsys limit the size of GMR/DMA buffers. The pipe driver will then resort to allocating smaller buffers and perform the DMA transfer in multiple bands, also allowing for the pre-flush mechanism to kick in. This avoids the related application crashes. Fixes: e7843273fae ("winsys/svga: Update to vmwgfx kernel module 2.1") Signed-off-by: Thomas Hellstrom <[email protected]> Reviewed-by: Brian Paul <[email protected]> Reviewed-by: Charmaine Lee <[email protected]> Reviewed-by: Roland Scheidegger <[email protected]> (cherry picked from commit 91146c07967b1d531a38f724ad91e7a0fc0769ef)
* svga: Fix banded DMA upload unmapThomas Hellstrom2019-10-251-1/+1
| | | | | | | | | | | | | | | | | Even with banded DMA uploads, st->hwbuf is always non-NULL, but when we've allocated a software buffer to hold the full upload, unmapping of the hardware buffer has already been done before svga_texture_transfer_unmap_dma(), and the code was performing an unmap of an already mapped buffer. Fix this by testing for software buffer not present. Fixes: a9c4a861d5d ("svga: refactor svga_texture_transfer_map/unmap functions") Signed-off-by: Thomas Hellstrom <[email protected]> Reviewed-by: Brian Paul <[email protected]> Reviewed-by: Charmaine Lee <[email protected]> Reviewed-by: Roland Scheidegger <[email protected]> (cherry picked from commit 00db976905b7fcd615ccee0c13dcbf9dfe29f5ec)
* util/u_queue: skip util_queue_finish if num_threads is 0Marek Olšák2019-10-251-0/+7
| | | | | | | | This fixes a deadlock in pthread_barrier_destroy. Cc: 19.1 19.2 <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]> (cherry picked from commit c2efd2cbfb19808cd4bf5f2f0cf62455f80f1a2f)
* radv: fix vkUpdateDescriptorSets with inline uniform blocksSamuel Pitoiset2019-10-251-0/+8
| | | | | | | | | | | | | | | | descriptorCount is the number of bytes into the descriptor, so it shouldn't be used as an index. srcArrayElement/dstArrayElement specify the starting byte offset within the binding to copy from/to. This fixes new CTS tests: dEQP-VK.binding_model.descriptor_copy.*.inline_uniform_block_* dEQP-VK.binding_model.descriptor_copy.*.mix_3 dEQP-VK.binding_model.descriptor_copy.*.mix_array1 Fixes: 8d2654a4197 ("radv: Support VK_EXT_inline_uniform_block.") Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> (cherry picked from commit 7562a2cbe3e963247f32d6bd9d434036ad1a93dc)
* radv/gfx10: fix 3D imagesSamuel Pitoiset2019-10-253-17/+17
| | | | | | | | | | | | GFX10 does act like GFX9 actually. This fixes dEQP-VK.glsl.texture_functions.query.texturesize.*sampler3d_*. Cc: 19.2 <[email protected]> Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> (cherry picked from commit 9c92a21fe58a2da6193317f04958a82baa08908a)
* radv: do not emit rbplus if attachments are undefinedSamuel Pitoiset2019-10-251-0/+3
| | | | | | | | | | | | Fixes some crashes with dEQP-VK.geometry.layered.*.secondary_cmd_buffer on Raven and other chips that allow rbplus. This just prevents a crash and rbplus probaby needs more work. Cc: 19.2 <[email protected]> Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> (cherry picked from commit 956d825ed845dd239b7098eccd5f5a7b4fecad9c)
* radv: do not create meta pipelines with 16 samplesSamuel Pitoiset2019-10-252-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | The driver only supports up to 8 samples, so it's useless to create more pipelines than needed. This fixes a conditional jump reported by Valgrind on GFX10: ==194282== Conditional jump or move depends on uninitialised value(s) ==194282== at 0xDBF925A: radv_gfx10_compute_bin_size (radv_pipeline.c:3242) ==194282== by 0xDBF95A6: radv_pipeline_generate_binning_state (radv_pipeline.c:3334) ==194282== by 0xDBFC1A0: radv_pipeline_generate_pm4 (radv_pipeline.c:4440) ==194282== by 0xDBFD15E: radv_pipeline_init (radv_pipeline.c:4764) ==194282== by 0xDBFD23E: radv_graphics_pipeline_create (radv_pipeline.c:4788) ==194282== by 0xDBB95A3: create_pipeline (radv_meta_clear.c:114) ==194282== by 0xDBB9AC5: create_color_pipeline (radv_meta_clear.c:297) ==194282== by 0xDBBCF05: radv_device_init_meta_clear_state (radv_meta_clear.c:1277) ==194282== by 0xDB9ACD9: radv_device_init_meta (radv_meta.c:363) ==194282== by 0xDB7FE3A: radv_CreateDevice (radv_device.c:2080 This is caused by an out of bound access of 'fmask_array' (ie. index is 4 as for 16 samples). Cc: <[email protected]> Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> (cherry picked from commit f4ab58c1a07c58525018649573ffff92eb3ccf19)
* anv: fix unwind of vkCreateDevice failLionel Landwerlin2019-10-251-3/+3
| | | | | | | | | | | | | We're skipping the context destruction in some cases which is the grand scheme of thing is not that important because closing device->fd will destroy the associated context as well. Signed-off-by: Lionel Landwerlin <[email protected]> Reported-by: Jordan Justen <[email protected]> Reviewed-by: Jordan Justen <[email protected]> Cc: <[email protected]> Fixes: b30e01aef56 ("anv: fix memory leak on device destroy") (cherry picked from commit 0dfa643feb6e80f654fdc4efc71c22e751a53de3)
* Bump version for 19.2.2 releasemesa-19.2.2Dylan Baker2019-10-231-1/+1
|
* docs: Add release notes for 19.2.2Dylan Baker2019-10-231-0/+147
|
* radv: fix updating bound fast ds clear values with different aspectsSamuel Pitoiset2019-10-221-3/+13
| | | | | | | | | | | | | | | | On GFX9, the driver is able to do an optimized fast depth/stencil clear with only one aspect (ie. clear the stencil part of a depth/stencil image). When this happens, the driver should only update the clear values of the given aspect. Note that it's currently only supported on GFX9 but I have some local patches that extend this optimized path for other gens. Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1967 Cc: 19.2 <[email protected]> Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> (cherry picked from commit a13320370ef4b668ace96ecba7eb0f8591af6f79)
* radv: Fix single stage constant flush with merged shaders.Bas Nieuwenhuizen2019-10-221-5/+6
| | | | | | | | | | | | | | e.g. a VERTEX only flush with tess on Vega should look at the TCS to see which bits are needed. CC: <[email protected]> Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1953 Reviewed-by: Samuel Pitoiset <[email protected]> (cherry picked from commit fd21ee8b52fb9416b16c63fd34c699b1301ce30c) Conflicts resolved by Dylan Baker Conflicts: src/amd/vulkan/radv_cmd_buffer.c
* egl/android: Remove our own reference to buffers.Lepton Wu2019-10-211-3/+1
| | | | | | | | | | | | | | | | | | | | We currently doesn't maintain it correctly and the buffer gets leaked if surface is destroyed before calling swapping buffers. From Android frameworks/native/libs/nativewindow/include/system/window.h: The window holds a reference to the buffer between dequeueBuffer and either queueBuffer or cancelBuffer, so clients only need their own reference if they might use the buffer after queueing or canceling it. v2: Remove our own reference. Fixes: 0212db35040 ("egl/android: Cancel any outstanding ANativeBuffer in surface destructor") Reviewed-by: Chia-I Wu <[email protected]> (v1) Reviewed-By: Tapani Pälli <[email protected]> Signed-off-by: Lepton Wu <[email protected]> (cherry picked from commit f4ba31ff504489b7195c83fa8703ba091406d808)
* anv: fix memory leak on device destroyLionel Landwerlin2019-10-211-1/+11
| | | | | | | | | | v2: handle vma destruction if vkCreateDevice fails (Jordan) Signed-off-by: Lionel Landwerlin <[email protected]> Gitlab: https://gitlab.freedesktop.org/mesa/mesa/issues/1959 Cc: <[email protected]> Reviewed-by: Jordan Justen <[email protected]> (cherry picked from commit b30e01aef5692be890f3f6ab944129b84d998254)
* anv: fix vkUpdateDescriptorSets with inline uniform blocksLionel Landwerlin2019-10-211-3/+3
| | | | | | | | | | | | With inline uniform blocks descriptor, the meaning of descriptorCount is a number of bytes to copy into the descriptor. Don't try to use that size as an index into the descriptor table. Signed-off-by: Lionel Landwerlin <[email protected]> Fixes: 43f40dc7cb ("anv: Implement VK_EXT_inline_uniform_block") Gitlab: https://gitlab.freedesktop.org/mesa/mesa/issues/1195 Reviewed-by: Jason Ekstrand <[email protected]> (cherry picked from commit 3f8f52b241e3f8bf31344f52c2c8faa32b05e804)
* rbug: unwrap index buffer resourceLucas Stach2019-10-181-2/+7
| | | | | | | | | | All resources passed to the drivers below rbug need to be unwrapped before being passed down. We missed to do this for the index buffer resource when this was made part of the draw_info structure. Fixes: 330d0607ed60 (gallium: remove pipe_index_buffer and set_index_buffer) Signed-off-by: Lucas Stach <[email protected]> (cherry picked from commit a75eb888e0ceeaa61b3583668c05cc1f5f5786ce)
* rbug: fix transmitted texture sizesLucas Stach2019-10-181-2/+9
| | | | | | | | | | | | | The rbug wire format defines the texture size parameters to be uint32_t sized and uses memcpy to move the function parameters to the message structure. This caused totally wrong transmitted texture sizes since the height and depth paramterds have been changed to uint16_t in the gallium API. Fix this by doing an explicit conversion to the correct representation before packing into the wire message. Fixes: e6428092f5e1 (gallium: decrease the size of pipe_resource - 64 -> 48 bytes) Signed-off-by: Lucas Stach <[email protected]> (cherry picked from commit 6174cba748988d2187ea3ae682e7fc0c4a4b7d3e)
* intel/vec4: Don't try both sources as immediates for DPHIan Romanick2019-10-181-1/+1
| | | | | | | | | | | DPH isn't actually commutative, so this doesn't work. If the immediate in src0 would be a VF candidate, we could do better. *shrug* No shader-db changes on any Intel platform. Reviewed-by: Caio Marcelo de Oliveira Filho <[email protected]> Fixes: b04beaf41d2 ("intel/vec4: Try both sources as candidates for being immediates") (cherry picked from commit 92252219d384a9ffdf2619f8228449963cd81872)
* nir/search: Fix possible NULL dereference in is_fsignIan Romanick2019-10-181-1/+1
| | | | | | Reviewed-by: Caio Marcelo de Oliveira Filho <[email protected]> Fixes: 09705747d72 ("nir/algebraic: Reassociate fadd into fmul in DPH-like pattern") (cherry picked from commit 050e4e28bf7c86e2fc78b9e4dbaf285db1ed4b43)
* gallivm: Fix saturated signed psub/padd intrinsics on llvm 8Roland Scheidegger2019-10-171-18/+10
| | | | | | | | | | | | | LLVM 8 did remove both the signed and unsigned sse2/avx intrinsics in the end, and provide arch-independent llvm intrinsics instead. Fixes a crash when using snorm framebuffers (tested with piglit arb_color_buffer_float-render GL_RGBA8_SNORM -auto). Reviewed-by: Jose Fonseca <[email protected]> Reviewed-by: Dave Airlie <[email protected]> CC: <[email protected]> (cherry picked from commit 045f05a2f68c301c850a38a511c8e254080fce9a) Conflicts resolved by Dylan Baker
* radv: fix DCC fast clear code for intensity formats (correctly)Samuel Pitoiset2019-10-171-12/+9
| | | | | | | | | | | | | Previous fix was pretty bogus. This fixes a rendering regression with Nier (minimap too large). Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1943 Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1952 Fixes: ea92273cea8 ("radv: fix DCC fast clear code for intensity formats") Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> (cherry picked from commit c644644c651b5e852a2d7da3a89fbef1fa09669b)
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-02 05:02:36 +0000