aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* gv100/ir: set ftz bit on floating point operationsKarol Herbst2020-07-142-2/+8
| | | | | | | Fixes Unigine Heavens ambient occlusion Signed-off-by: Karol Herbst <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5881>
* meson: fix android vulkan buildEric Engestrom2020-07-145-5/+5
| | | | | | | | | | | | | | | | Android doesn't have `pthread_cancel()` and is unlikely to ever implement it [1], but `wsi_common_display.c` needs it (or an alternative). Let's just disable the platform on Android (as it used to be before 448eb19158f483d807ef). [1] https://android-review.googlesource.com/c/platform/bionic/+/1215779/1/docs/status.md Fixes: 448eb19158f483d807ef ("vulkan: automatically compile the `display` platform when available") Signed-off-by: Eric Engestrom <[email protected]> Acked-by: Nataraj Deshpande <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5860>
* gitlab-ci: Drop dependencies:Michel Dänzer2020-07-142-8/+0
| | | | | | | | | | | Artifacts from jobs listed in needs: are downloaded by default, so there's no need to list them in dependencies: as well (in fact, https://docs.gitlab.com/ce/ci/yaml/#artifact-downloads-with-needs says using dependencies: together with needs: is invalid, so we might have been getting lucky...). Reviewed-by: Tomeu Vizoso <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5845>
* gitlab-ci: Remove indirect dependencies from needs:Michel Dänzer2020-07-141-13/+0
| | | | | | | | | Tomeu discovered that GitLab 12.8 fixed the bug where jobs would spuriously run even though some of their dependency jobs were skipped. So we don't need to list indirect dependencies anymore. Reviewed-by: Tomeu Vizoso <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5845>
* tu: Don't invalidate irrelevant state when changing pipelineConnor Abbott2020-07-141-9/+1
| | | | | | | At least in the future this could let us avoid re-emitting gfx/cs constants when the other changes. This also matches what the blob does. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5877>
* freedreno/a6xx: Add some documentation for shared constsConnor Abbott2020-07-143-4/+24
| | | | | | | | I'm not convinced we'll actually want to use this, and there may be another enable bit in SP_UNKNOWN_AB00, but it's nice to at least write this down in case we want to try using it in the future. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5877>
* freedreno/a6xx: Rename and document HLSQ_UPDATE_CNTLConnor Abbott2020-07-149-22/+130
| | | | | | | | | | | | | It turns out that this clears CP_LOAD_STATE6 packets, including disabling any pending loads for SS6_INDIRECT/SS6_BINDLESS (these loads don't actually happen until the draw itself, and I'm not sure if they happen if the state is unused by the shader) and marking constants and UBO descriptors loaded with SS6_DIRECT as invalid. It's used very differently from HLSQ_UPDATE_CNTL on a4xx from whence the name came, and unlike on a4xx it's not readable, so this probably doesn't line up with HLSQ_UPDATE_CNTL on a4xx. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5877>
* clover: implements clEnqueueFillBufferSerge Martin2020-07-147-16/+60
| | | | | Reviewed-by: Francisco Jerez <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5897>
* clover: add more cl_mem_object_type to pipe_texture_target mappingSerge Martin2020-07-141-0/+7
| | | | | | | It avoid unnecessary CL_INVALID_VALUE return from clGetSupportedImageFormats Reviewed-by: Francisco Jerez <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5897>
* radv: add the custom border color BO to the list of buffersSamuel Pitoiset2020-07-141-0/+4
| | | | | | | | | | | | The buffer was never added to the list of buffers. This might lead to VM faults and GPU hangs. Found this by luck. Fixes: 57e796a12a8 ("radv: Implement VK_EXT_custom_border_color") Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5884>
* freedreno/registers: Rename SP_2D_SRC_FORMATKristian H. Kristensen2020-07-144-16/+13
| | | | | | | This register contains information about the destination format, so let's rename to SP_2D_DST_FORMAT. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Split clear and blit texture into different functionsKristian H. Kristensen2020-07-141-84/+98
| | | | | | | | Now that most of the state programming is in shareable helpers, we can split emit_blit_or_clear_texture into emit_blit_texture and fd6_clear_surface. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Don't take pipe_blit_info in emit_blit_dstKristian H. Kristensen2020-07-141-11/+11
| | | | | | | We only need a few fields and we'll want to use this in cases where we don't have a pipe_blit_info. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Program RB_UNKNOWN_8C01 in setup helperKristian H. Kristensen2020-07-141-6/+3
| | | | Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Move CP_SET_MARKER to setup helperKristian H. Kristensen2020-07-141-6/+3
| | | | Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Move REG_A6XX_SP_2D_SRC_FORMAT programming to helperKristian H. Kristensen2020-07-141-30/+27
| | | | | | Rename helper to emit_blit_setup(). Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Program A6XX_SP_2D_SRC_FORMAT_COLOR_FORMAT based on dst formatKristian H. Kristensen2020-07-141-9/+7
| | | | | | It's a badly named register... Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Make blit_control helper a little more helpfulKristian H. Kristensen2020-07-141-19/+16
| | | | Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Enable FMT6_10_10_10_2_UNORM blittingKristian H. Kristensen2020-07-141-3/+0
| | | | | | | | Now that we correctly program the _DEST version for the blit destination and use float16 internal format, these formats work with the blitter. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Separate stencil sysmem clear fixKristian H. Kristensen2020-07-141-0/+1
| | | | | | We need to clear with PIPE_FORMAT_S8_UINT. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Don't emit src state when clearingKristian H. Kristensen2020-07-141-11/+15
| | | | Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Consolidate computing blit_cntlKristian H. Kristensen2020-07-141-5/+5
| | | | | | | Compute the blit_cntl value in one place and group it with the register writes. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Program SP_2D_SRC_FORMAT outside blit loopKristian H. Kristensen2020-07-141-23/+23
| | | | Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Set src and dst rects outside blit loopKristian H. Kristensen2020-07-141-12/+12
| | | | Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Don't set unknown bit when tiling differsKristian H. Kristensen2020-07-141-7/+0
| | | | | | | | There is a bit here that's sometimes set, but it's generally not related to whether tiling differs between src and dst. Let's stop setting it until we know more. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Split out src and dst setup helpers for blitKristian H. Kristensen2020-07-141-86/+92
| | | | Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Move fd6_ifmt into fd6_blitter.cKristian H. Kristensen2020-07-142-68/+68
| | | | | | It's only used in this file. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* freedreno/a6xx: Don't blit with R2D_RAWKristian H. Kristensen2020-07-144-31/+9
| | | | | | | | | | | Map all formats to a valid ifmt. FMT6_10_10_10_2_UNORM_DEST still doesn't work on the blitter so keep that one on the u_blitter path. Fixes dEQP-GLES31.functional.draw_buffers_indexed.random.max_implementation_draw_buffers.* with FD_MESA_DEBUG=nogmem. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5717>
* turnip: drop GS clear pathJonathan Marek2020-07-143-98/+14
| | | | | | | | | | | We didn't know how to write layer id without GS, since that's the only way to do it through VK/GL, and the blob didn't implement this clear case (and failed cases where it was absolutely necessary). However now we know how to set it after some educated guesses and looking at tess/geom traces, so the GS path can be dropped. Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5790>
* turnip: clean up primitive output stateJonathan Marek2020-07-143-94/+85
| | | | | | | | | We only need to emit one set of primitive output registers. This may differ from the blob, because it seems to try to allow using the same pipeline with tess/geom enabled/disabled. Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5790>
* freedreno/regs: update primitive output related registersJonathan Marek2020-07-147-189/+144
| | | | | Signed-off-by: Jonathan Marek <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5790>
* freedreno/ir3: Fix uninit var warning.Eric Anholt2020-07-141-1/+1
| | | | | | | It's a decent bit of analysis to see that the initialization will always happen, and my compiler isn't doing so in at least one configuration. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5834>
* freedreno/ir3_cmdline: Fix an uninit var warning.Eric Anholt2020-07-141-8/+6
| | | | | | | You could only access entry through the initialized path, but we can clean up the compiler warning by not keeping the other var. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5834>
* turnip: implement VK_EXT_private_dataHyunjun Ko2020-07-142-0/+60
| | | | | | | Which is using base class's implementation. Signed-off-by: Hyunjun Ko <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5539>
* turnip: Use the common base object type and struct.Hyunjun Ko2020-07-1413-128/+175
| | | | | | | | | v2. Define new helper function to avoid duplicated a pair of function calls. v3. Move new helper functions to vk_object.h and call them. v4. Merge 2 commits to use commomn base object type and struct into one. Signed-off-by: Hyunjun Ko <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5539>
* tu: Fix wrong copies of sampler descriptor.Hyunjun Ko2020-07-141-2/+2
| | | | | | | | | | Found this with the following patch but it exists since adding ycbcr sampler to the struct. Fixes: d070a7ba0cfb11f1e01774b9dd3775ab7cd0c4ea Signed-off-by: Hyunjun Ko <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5539>
* vulkan: Adds helpers for vk_object (de)alloation and (de)initialization.Hyunjun Ko2020-07-142-0/+59
| | | | | Signed-off-by: Hyunjun Ko <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5539>
* gitlab-ci: reduce a630 runner loadRob Clark2020-07-131-7/+11
| | | | | | | | | They seem to be sometimes taking a while to boot, which is triggering CI timeouts. (Possibly tftp server in bad shape?) Cut out non-essential a630 CI jobs, and reduce the gles3/gles31 jobs to compensate. Signed-off-by: Rob Clark <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5893>
* meson/intel: add missing dep on git_sha1.hEric Engestrom2020-07-131-1/+1
| | | | | | | | Fixes: 805b32cab90547a576af ("intel: add identifier for debug purposes") Signed-off-by: Eric Engestrom <[email protected]> Reviewed-by: Dylan Baker <[email protected]> Acked-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5882>
* zink: use type of src[0] for ntv store and load opsMike Blumenkrantz2020-07-131-4/+2
| | | | | | | | | | | in some cases (e.g., gl_ClipDistance) the nir_variable type doesn't match the needed destination type, so we can simplify this code to just use the destination type fixes [email protected]@execution@interpolation@interpolation-none-gl_backcolor-smooth-vertex Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5852>
* zink: add lengthy comment and remove assert from discard_if ntv passMike Blumenkrantz2020-07-131-2/+43
| | | | | | | | | | | | as in the comment, while we may want to try verifying that discard will be the last instruction in a block, it's a bit problematic given that other nir passes we're doing may insert instructions after a discard as part of e.g., nir_opt_dead_cf in the process of removing another block fixes shaders@glsl-fs-discard-04 Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5852>
* zink: handle ntv case of nested loop instructions more permissivelyMike Blumenkrantz2020-07-131-1/+3
| | | | | | | | | | | | if the last instruction in a loop's body terminates a block, e.g., from a nested loop with a jump as its final instruction, then no block will have been started when returning to the original loop, and there's no need to emit a branch fixes shaders@glsl-vs-continue-in-switch-in-do-while Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5852>
* zink: use right vulkan type for GL_PRIMITIVES_GENERATED queriesMike Blumenkrantz2020-07-131-1/+1
| | | | | | | | | | | VK_QUERY_PIPELINE_STATISTIC_INPUT_ASSEMBLY_PRIMITIVES_BIT includes primitives which won't get drawn due to e.g., not enough vertices emitted by geometry shader fixes [email protected]@gs-emits-too-few-verts Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5533>
* zink: only reset query pool on query end if current batch isn't in renderpassMike Blumenkrantz2020-07-131-44/+65
| | | | | | | | | reset can't be performed during a renderpass, so we need to defer that until a time when we're definitely not in a renderpass, such as when we're starting a new query or resuming a query Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5533>
* zink: properly handle query pool overflowsMike Blumenkrantz2020-07-131-3/+12
| | | | | | | | | | | | | | | inline a query result value to each query object so we can stash the partial result just before we do a pool reset, which will always happen during the suspend/resume query mechanism that swaps active queries from a flushed batch to the next batch once (or if) the "real" call to fetch query results is called, we can dump the inlined value into the fetch value and return the full results fixes mesa/mesa#3000 Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5533>
* zink: only stall during query destroy for xfb queriesMike Blumenkrantz2020-07-131-7/+24
| | | | | | | | | | | | | xfb queries allocate vk buffer objects in the underlying driver which can be deallocated while an xfb query is in-flight if we attempt to defer it due to the way that gl xfb is translated to vk, so we need to continue forcing this behavior in that case for other query types, we can safely defer here until the current batch has finished rather than block Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5533>
* zink: use #define for number of queries per-poolMike Blumenkrantz2020-07-131-4/+6
| | | | | | | just to ensure we're consistent internally Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5533>
* zink: rework query handlingMike Blumenkrantz2020-07-138-81/+135
| | | | | | | | | | | | | | | | | this hooks up query objects to the batches that they're actively running on (and the related fence) in order to manage the lifetimes of queries more efficiently by calling vkCmdResetQueryPool only on init and when the query pool has been completely used up. additionally, this resolves some vk spec issues related to destroying pools with active queries note that any time a query pool is completely used up, results are lost, which is a very slight improvement on the previous abort() that was triggered in that scenario ref mesa/mesa#3000 Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5533>
* panfrost: Fix outmods on int to float conversionsItalo Nicola2020-07-131-1/+1
| | | | | | | | No shader-db changes (Alyssa). Signed-off-by: Italo Nicola <[email protected]> Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5883>
* docs/submittingpatches: add more than one `Cc: mesa-stable` example to the ↵Eric Engestrom2020-07-131-0/+2
| | | | | | | | | | examples list Starting with that very example :) Signed-off-by: Eric Engestrom <[email protected]> Acked-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5880>