aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* lima/gpir: add better lowering for ftruncVasily Khoruzhick2020-03-164-106/+11
| | | | | | | | | | | | GP doesn't support ftrunc natively and unfortunately one in generic opt_algebraic is not GP-friendly either. Introduce our own lowering that utilizes fsign() that GP supports: ftrunc(a) = fmul(fsign(a), ffloor(fmax(a, -a))) Tested-by: Andreas Baierl <[email protected]> Reviewed-by: Andreas Baierl <[email protected]> Signed-off-by: Vasily Khoruzhick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4126>
* lima/gpir: kill dead writes to regs in DCEVasily Khoruzhick2020-03-163-17/+28
| | | | | | | | | | | Writes to regs that are never read will confuse regalloc since they are never live and don't conflict with any regs. Kill them to prevent overwriting another live reg. Reviewed-by: Andreas Baierl <[email protected]> Signed-off-by: Vasily Khoruzhick <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4125> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4125>
* lima/gpir: Optimize nots created from branch loweringConnor Abbott2020-03-161-0/+67
| | | | | | | | | We also add a DCE pass to cleanup the result of this pass, which turns out to also be necessary to cleanup the result of nir->gpir in some cases that we didn't hit until the next commit. Reviewed-by: Vasily Khoruzhick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4125>
* lima/gpir: Optimize conditional break/continueConnor Abbott2020-03-164-0/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Optimize the result of a conditional break/continue. In NIR something like: loop { ... if (cond) continue; would get lowered to: block_0: ... block_1: branch_cond !cond block_3 block_2: branch_uncond block_0 block_3: ... We recognize the conditional branch skipping over the unconditional branch, and turn it into: block_0: ... block_1: branch_cond cond block_0 block_2: block_3: Reviewed-by: Vasily Khoruzhick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4125>
* lima/gpir: Make lima_gpir_node_insert_child() usefulConnor Abbott2020-03-161-1/+1
| | | | | | | | | | | | We weren't using this function before. The name is confusing, but it changes the child while also fixing up the dependence link, if you don't have access to it already. Or at least, I think that's what the intention is, and what we'll need to change the branch condition in the next commit. Adding a dependency between the new and old source doesn't make any sense for this, and we also need to change the actual source. Reviewed-by: Vasily Khoruzhick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4125>
* panfrost: Fix gnu-empty-initializer error.Vinson Lee2020-03-161-1/+1
| | | | | | | | | | | | ../src/gallium/drivers/panfrost/pan_cmdstream.c:1553:54: error: use of GNU empty initializer extension [-Werror,-Wgnu-empty-initializer] union mali_attr varyings[PIPE_MAX_ATTRIBS] = { }; ^ Fixes: 836686daf36c ("panfrost: Move panfrost_emit_varying_descriptor() to pan_cmdstream.c") Signed-off-by: Vinson Lee <[email protected]> Reviewed-by: Alyssa Rosenzweig <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4198> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4198>
* aco: fix operand order for LS VGPR init bug workaroundRhys Perry2020-03-161-3/+3
| | | | | | | | Fixes: a952bf3946 ('aco: Fix LS VGPR init bug on affected hardware.') Signed-off-by: Rhys Perry <[email protected]> Reviewed-By: Timur Kristóf <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4201> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4201>
* aco: fix instruction encoding for LS VGPR init bug workaroundRhys Perry2020-03-161-3/+3
| | | | | | | Fixes: a952bf3946 ('aco: Fix LS VGPR init bug on affected hardware.') Signed-off-by: Rhys Perry <[email protected]> Reviewed-By: Timur Kristóf <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4201>
* aco: set late kill for v_interp_p1_f32 for some APUsRhys Perry2020-03-163-2/+8
| | | | | | | | | | | | | | | | | | | | | | Apparently needed for Stoney Ridge, Kabini and Mullins APUs. gfx702 also has 16-bank LDS and https://llvm.org/docs/AMDGPUUsage.html lists some dGPUs under there. Those GPUs seem to be Hawaii actually (gfx701) and we don't seem to have gotten any interpolation related bugs reported with them so far. The late kill flag was tested by running pipeline-db with ACO_DEBUG=validatera while setting late kill for SMEM buffer loads, emit_vop2_instruction() and texture instructions. I also tested with just setting the flag for v_interp_p1_f32. As far as I know, the only other thing we have to consider for 16-bank LDS is something to do with 16-bit interpolation. We don't do that yet. Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3914> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3914>
* aco: add a late kill flagRhys Perry2020-03-165-25/+77
| | | | | | Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3914>
* aco: move some register demand helpers into aco_live_var_analysis.cppRhys Perry2020-03-164-45/+55
| | | | | | Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3914>
* radv/sqtt: handle thread trace capture in sqtt_QueuePresentKHR()Samuel Pitoiset2020-03-162-44/+49
| | | | | | | | | To avoid wasting CPU cycles when thread trace is not enabled. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4180> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4180>
* anv: Push UBO ranges relative to the start of the bindingJason Ekstrand2020-03-162-12/+16
| | | | | | | | | | | | | | | | | There was a disconnect between anv_nir_compute_push_layout and the code which sets up the push_ubo_sizes array. The NIR code we emit checks relative to the start of the bound UBO range so that, if we end up with a vector which straddles the start of the push range, we can perform the bounds check without risking overflow issues. The code which sets up the push_ubo_sizes, on the other hand, assumed it was relative to the start of the push range. Somehow, this didn't get get caught by any of the available tests. Fixes: e03f9652801 "anv: Bounds-check pushed UBOs when ..." Closes: #2623 Reviewed-by: Lionel Landwerlin <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4195> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4195>
* anv: Fix the comparison in an assertJason Ekstrand2020-03-161-1/+1
| | | | | | Fixes: e03f9652801 "anv: Bounds-check pushed UBOs when ..." Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4195>
* gitlab-ci: bump Vulkan CTS to 1.2.1.0Samuel Pitoiset2020-03-162-2/+2
| | | | | | | | | Vulkan CTS 1.1.6.0 is quite old. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4179> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4179>
* gitlab-ci: do not set the number of deqp-parallel jobs for RADV CTSSamuel Pitoiset2020-03-161-1/+0
| | | | | | | | Let's the runner uses the maximum number of jobs to speedup CTS. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4179>
* gitlab-ci: allow deqp-runner to use the maximum number of jobsSamuel Pitoiset2020-03-161-1/+5
| | | | | | | | | if $DEQP_PARALLEL is not set, it will use the maximum number of jobs instead of 1. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4179>
* gitlab-ci: remove useless 'patch' package in the VK test imageSamuel Pitoiset2020-03-161-2/+0
| | | | | | | | It was copied from the GL test image but it's actually unused. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4179>
* tu: Rewrite border color handlingConnor Abbott2020-03-165-159/+115
| | | | | | | | | | | | | | Emit a single table of all possible Vulkan border colors up front, and then index into it using the Vulkan enum directly. In fact this seems to be the entire point of separating out border colors in the first place. In addition to being simpler and having less CPU overhead, and fixing cases where more than one sampler uses border color, this paves the way for bindless samplers because the existing approach isn't great for bindless. Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4200> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4200>
* meson: Avoid duplicate symbols.Jose Fonseca2020-03-162-4/+13
| | | | | | | | | | | | | | | | All the stubs in src/compiler/glsl/glcpp/pp_standalone_scaffolding.c are duplicate symbols. They should only be used as replacement for Mesa functions when building glcpp and glsl standalone compilers, but in fact they are getting linked with Mesa. This change fixes this by moving the standalone stubs to a libglcpp_standalone target, that's only linked with the glcpp/glsl tools. Reviewed-by: Dylan Baker <[email protected]> Reviewed-by: Neha Bhende <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4186> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4186>
* Revert "ci: Remove T820 from CI temporarily"Neil Armstrong2020-03-161-1/+1
| | | | | | | | | | | | | This reverts commit 089c8f0b8da86a05bde8359c84085e0b795abf17. Our office changes are finished and power is now stable in our lab for T820 CI to run again. Cc: Daniel Stone <[email protected]> Cc: Tomeu Vizoso <[email protected]> Signed-off-by: Neil Armstrong <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4057> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4057>
* gitlab-ci/lava: fix handling of lava tagsNeil Armstrong2020-03-161-1/+2
| | | | | | | | | | | | | | | | | | | | | | | The lava tags was a python array not it's a gitlab CI string, slit the string with periods in the jinja2 template to avoid having the following tags : tags: - p - a - n - f - r - o - s - t instead of : tags: - panfrost Signed-off-by: Neil Armstrong <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4057>
* iris: allow compression conditionally for images on gen12Tapani Pälli2020-03-161-0/+18
| | | | | | | | | | | | | | With this change, amount of resolves happening with deqp-gles31 (--deqp-case=*load_store*) drops ~50%. v2: use iris_image_view_get_format to get the format, get devinfo from context instead of passing it (Nanley) Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4080> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4080>
* isl: allow compression for storage images on gen12+Tapani Pälli2020-03-161-1/+4
| | | | | | | | | This is done to be able to use ISL_AUX_USAGE_CCS_E with images. Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4080>
* iris: determine aux usage during predraw and state setupTapani Pälli2020-03-162-8/+18
| | | | | | | | | | | | | | | Patch changes surface state setup to alloc/fill states for all possible usages for image resource on gen12. Also predraw and binding table population is changed to determine correct aux usage with the new iris_image_view_aux_usage. v2: alloc always all states independent on current image aux state on gen >= 12 , code cleanups (Nanley) Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4080>
* iris: move existing image format fallback as a helper functionTapani Pälli2020-03-163-22/+32
| | | | | | | | | | | | Patch adds a helper function for determining image format and changes iris_set_shader_images to use it. v2: pass iris_context instead of pipe one, rename function, code cleanup (Nanley) Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4080>
* iris: provide dummy iris_image_view_aux_usageTapani Pälli2020-03-162-0/+13
| | | | | | | | | | | | | Similar to iris_resource_texture_aux_usage this function will determine proper aux_usage for image, now it will default to ISL_AUX_USAGE_NONE. v2: drop gen_device_info parameter, rename function (Nanley) Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4080>
* intel/compiler: detect if atomic load store operations are usedTapani Pälli2020-03-167-5/+16
| | | | | | | | | Patch adds a new arg and modifies existing calls from i965, anv pass NULL but iris stores this information for later use. Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4080>
* iris: use the images_used mask in resolve passTapani Pälli2020-03-161-3/+3
| | | | | | Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4080>
* nir/glsl: gather bitmask of images used by programTapani Pälli2020-03-163-0/+22
| | | | | | | In a similar fashion as commit f5c7df4dc95 does for textures. Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4080>
* st/mesa: Fix signed integer overflow when using util_throttle_memory_usageDanylo Piliaiev2020-03-161-3/+3
| | | | | | | | | | ../src/mesa/state_tracker/st_cb_texture.c:1719:57: runtime error: signed integer overflow: 203489280 * 16 cannot be represented in type 'int' Fixes: 21ca322e637291b89a445159fc45b8dbf638e6c9 Signed-off-by: Danylo Piliaiev <[email protected]> Reviewed-by: Marek Olšák <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4185> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4185>
* isl: Avoid EXPECT_DEATH in unit testsMatt Turner2020-03-134-46/+61
| | | | | | | | | | | | | | | | | | | | | EXPECT_DEATH works by forking the process and letting the forked process fail with an assertion. This process is evidently incredibly expensive, taking ~30 seconds to run the whole isl_aux_info_test on a 2.8GHz Skylake. Annoyingly all of the (expected) assertion failures also leaves lots of messages in dmesg and potentially generates lots of coredumps. Instead, avoid the expense of fork/exec by redefining assert() and unreachable() in the code we're testing to return a unit-test-only value. With this patch, the test takes ~1ms. Also, while modifying the EXPECT_EQ() calls, reverse the arguments so that the expected value comes first, as is intended. Otherwise gtest failure messages don't make much sense. Fixes: https://gitlab.freedesktop.org/mesa/mesa/issues/2567 Reviewed-by: Nanley Chery <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4174> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4174>
* gallium/swr: use ElementCount type arguments for getSplat()Jan Zielinski2020-03-134-17/+57
| | | | | | | | | | Reviewed-by: Alok Hota <[email protected]> In LLVM11, ConstantVector::getSplat() function definition has changed and the first function argument has now ElementCount type. Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4188> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4188>
* etnaviv: enable shareable shadersChristian Gmeiner2020-03-131-0/+1
| | | | | | | | | | We are not using any pctx reference in the shader so it seems fine to enable this cap. Signed-off-by: Christian Gmeiner <[email protected]> Reviewed-by: Lucas Stach <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4095> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4095>
* etnaviv: get rid of etna_spec in etna_contextChristian Gmeiner2020-03-1313-76/+98
| | | | | | | | | There is no need to have a complete copy of etna_spec - just reference the one and only from etna_screen. Signed-off-by: Christian Gmeiner <[email protected]> Reviewed-by: Lucas Stach <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4095>
* anv: Dump push ranges via VK_KHR_pipeline_executable_propertiesJason Ekstrand2020-03-131-0/+50
| | | | | | Reviewed-by: Lionel Landwerlin <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4173> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4173>
* aco: don't stop scheduling at exportsRhys Perry2020-03-131-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to move v_cvt_pkrtz_f16_f32 instructions upwards, improving schedules and (somewhat unintentionally) moving the exports slightly closer together. Totals from affected shaders: SGPRS: 1030224 -> 1030248 (0.00 %) VGPRS: 794080 -> 794392 (0.04 %) Spilled SGPRs: 127117 -> 127117 (0.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size: 89028152 -> 89032312 (0.00 %) bytes LDS: 0 -> 0 (0.00 %) blocks Max Waves: 65252 -> 65219 (-0.05 %) SMEM score: 843808.00 -> 843918.00 (0.01 %) VMEM score: 5331687.00 -> 5397802.00 (1.24 %) SMEM clauses: 567659 -> 567655 (-0.00 %) VMEM clauses: 290715 -> 290716 (0.00 %) Instructions: 17143219 -> 17144259 (0.01 %) Cycles: 1098442808 -> 1098446968 (0.00 %) Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3776> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3776>
* aco: allow barriers to be skipped during schedulingRhys Perry2020-03-131-17/+25
| | | | | | | | | | | | | | | | | | | | | | | | Much better scheduling apparently in 160 shaders Totals from affected shaders: SGPRS: 6272 -> 6344 (1.15 %) VGPRS: 4832 -> 4844 (0.25 %) Spilled SGPRs: 0 -> 0 (0.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size: 467192 -> 467428 (0.05 %) bytes LDS: 459 -> 459 (0.00 %) blocks Max Waves: 1407 -> 1409 (0.14 %) SMEM score: 9309.00 -> 11216.00 (20.49 %) VMEM score: 26679.00 -> 33652.00 (26.14 %) SMEM clauses: 1817 -> 1776 (-2.26 %) VMEM clauses: 2286 -> 2288 (0.09 %) Instructions: 86537 -> 86596 (0.07 %) Cycles: 676260 -> 676568 (0.05 %) Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3776>
* aco: add helpers for ensuring correct ordering while schedulingRhys Perry2020-03-132-193/+171
| | | | | | | | | | | | | | | | | | | | | | | | Pipeline-db changes in 721 shaders. Totals from affected shaders: SGPRS: 42336 -> 42656 (0.76 %) VGPRS: 38368 -> 38636 (0.70 %) Spilled SGPRs: 11967 -> 11967 (0.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size: 5268088 -> 5269840 (0.03 %) bytes LDS: 1069 -> 1069 (0.00 %) blocks Max Waves: 4473 -> 4447 (-0.58 %) SMEM score: 41155.00 -> 41826.00 (1.63 %) VMEM score: 146339.00 -> 147471.00 (0.77 %) SMEM clauses: 24434 -> 24535 (0.41 %) VMEM clauses: 16637 -> 16592 (-0.27 %) Instructions: 996037 -> 996388 (0.04 %) Cycles: 76476112 -> 75281416 (-1.56 %) Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3776>
* aco: add helpers for moving instructions for schedulingRhys Perry2020-03-131-364/+321
| | | | | | | | No pipeline-db changes Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3776>
* radv: add llvm_compiler_shader() helperSamuel Pitoiset2020-03-133-40/+44
| | | | | | | | | To match aco_compile_shader(). Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4163> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4163>
* radv: remove unnecessary LLVM includesSamuel Pitoiset2020-03-136-16/+0
| | | | | | | | They are already included from src/amd/llvm. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4163>
* radv: remove radv_shader_variant::aco_usedSamuel Pitoiset2020-03-133-3/+1
| | | | | | Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4163>
* radv: cleanup occurences of use_aco everywhereSamuel Pitoiset2020-03-133-31/+27
| | | | | | Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4163>
* glsl: do not crash if string literal is used outside of #include/#lineDanylo Piliaiev2020-03-131-0/+1
| | | | | | | | | Fixes: 67b32190f3c953c5b7091d76ddeff95c0cbfb439 Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2619 Signed-off-by: Danylo Piliaiev <[email protected]> Reviewed-by: Timothy Arceri <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4146> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4146>
* anv: Remove duplicate code in anv_cmd_buffer_bind_descriptor_setCaio Marcelo de Oliveira Filho2020-03-121-14/+20
| | | | | | | | Also use a single condition statement instead of two. Reviewed-by: Jason Ekstrand <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4040> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4040>
* anv: Reduce compute pipeline batch_data sizeCaio Marcelo de Oliveira Filho2020-03-123-5/+7
| | | | | | | | | The batch associated with the compute pipeline only needs room for a MEDIA_VFE_STATE. So this patch moves the batch_data to each pipeline struct and cap the one in compute pipeline. Reviewed-by: Jason Ekstrand <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4040>
* anv: Split graphics and compute bits from anv_pipelineCaio Marcelo de Oliveira Filho2020-03-127-236/+275
| | | | | | | | | Add two new structs that use the anv_pipeline as base. Changed all functions that work on a specific pipeline to use the corresponding struct. Reviewed-by: Jason Ekstrand <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4040>
* anv: Use a separate field in the pipeline for compute shaderCaio Marcelo de Oliveira Filho2020-03-125-20/+42
| | | | | | | | This is a preparation for splitting the compute and graphics pipelines into separate structs. Reviewed-by: Jason Ekstrand <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4040>
* anv: Decouple flush_descriptor_sets() from pipeline structCaio Marcelo de Oliveira Filho2020-03-121-23/+45
| | | | | | | | | | | | | Explicitly pass the active stages and the array (and size) of shaders to be processed. This will make easy to store only the shaders needed for each pipeline. The active stages can be identified by a non-NULL shader in the shaders array, so stop using it and keep track of the flushed stages as iteration happens. Reviewed-by: Jason Ekstrand <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4040>