diff options
Diffstat (limited to 'src/intel/genxml')
| -rw-r--r-- | src/intel/genxml/gen_bits_header.py | 1 | ||||
| -rw-r--r-- | src/intel/genxml/gen_pack_header.py | 29 | ||||
| -rw-r--r-- | src/intel/genxml/gen_zipped_file.py | 1 |
3 files changed, 14 insertions, 17 deletions
diff --git a/src/intel/genxml/gen_bits_header.py b/src/intel/genxml/gen_bits_header.py index dcd6ccb7d9e..ded2d2dcfcf 100644 --- a/src/intel/genxml/gen_bits_header.py +++ b/src/intel/genxml/gen_bits_header.py @@ -25,7 +25,6 @@ from __future__ import ( import argparse import os -import sys import xml.parsers.expat from mako.template import Template diff --git a/src/intel/genxml/gen_pack_header.py b/src/intel/genxml/gen_pack_header.py index c3d712c7a86..0bf838de8c6 100644 --- a/src/intel/genxml/gen_pack_header.py +++ b/src/intel/genxml/gen_pack_header.py @@ -219,9 +219,9 @@ def safe_name(name): def num_from_str(num_str): if num_str.lower().startswith('0x'): return int(num_str, base=16) - else: - assert not num_str.startswith('0'), 'octals numbers not allowed' - return int(num_str) + + assert not num_str.startswith('0'), 'octals numbers not allowed' + return int(num_str) class Field(object): ufixed_pattern = re.compile(r"u(\d+)\.(\d+)") @@ -306,7 +306,7 @@ class Field(object): print(" %-36s %s%s;" % (type, self.name, dim)) prefix = "" - if len(self.values) > 0 and self.default == None: + if self.values and self.default == None: if self.prefix: prefix = self.prefix + "_" @@ -340,7 +340,7 @@ class Group(object): def collect_dwords(self, dwords, start, dim): for field in self.fields: - if type(field) is Group: + if isinstance(field, Group): if field.count == 1: field.collect_dwords(dwords, start + field.start, dim) else: @@ -424,7 +424,7 @@ class Group(object): # to the dword for those fields. field_index = 0 for field in dw.fields: - if type(field) is Field and field.is_struct_type(): + if isinstance(field, Field) and field.is_struct_type(): name = field.name + field.dim print("") print(" uint32_t v%d_%d;" % (index, field_index)) @@ -490,7 +490,7 @@ class Group(object): non_address_fields.append("/* unhandled field %s, type %s */\n" % \ (name, field.type)) - if len(non_address_fields) > 0: + if non_address_fields: print(" |\n".join(" " + f for f in non_address_fields) + ";") if dw.size == 32: @@ -531,8 +531,7 @@ class Parser(object): def gen_prefix(self, name): if name[0] == "_": return 'GEN%s%s' % (self.gen, name) - else: - return 'GEN%s_%s' % (self.gen, name) + return 'GEN%s_%s' % (self.gen, name) def gen_guard(self): return self.gen_prefix("PACK_H") @@ -629,7 +628,7 @@ class Parser(object): def emit_instruction(self): name = self.instruction - if not self.length == None: + if not self.length is None: print('#define %-33s %6d' % (self.gen_prefix(name + "_length"), self.length)) print('#define %-33s %6d' % @@ -637,9 +636,9 @@ class Parser(object): default_fields = [] for field in self.group.fields: - if not type(field) is Field: + if not isinstance(field, Field): continue - if field.default == None: + if field.default is None: continue default_fields.append(" .%-35s = %6d" % (field.name, field.default)) @@ -654,11 +653,11 @@ class Parser(object): def emit_register(self): name = self.register - if not self.reg_num == None: + if not self.reg_num is None: print('#define %-33s 0x%04x' % (self.gen_prefix(name + "_num"), self.reg_num)) - if not self.length == None: + if not self.length is None: print('#define %-33s %6d' % (self.gen_prefix(name + "_length"), self.length)) @@ -667,7 +666,7 @@ class Parser(object): def emit_struct(self): name = self.struct - if not self.length == None: + if not self.length is None: print('#define %-33s %6d' % (self.gen_prefix(name + "_length"), self.length)) diff --git a/src/intel/genxml/gen_zipped_file.py b/src/intel/genxml/gen_zipped_file.py index 616409183f0..199f550419e 100644 --- a/src/intel/genxml/gen_zipped_file.py +++ b/src/intel/genxml/gen_zipped_file.py @@ -23,7 +23,6 @@ # from __future__ import print_function -import os import sys import zlib import xml.etree.cElementTree as et |