diff options
| -rw-r--r-- | docs/submittingpatches.html | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 39b615bc9af..d3e86f5b443 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -134,7 +134,7 @@ to check for regressions. <p> Patches should be sent to the mesa-dev mailing list for review: <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev"> [email protected]<a/>. [email protected]</a>. When submitting a patch make sure to use <a href="https://git-scm.com/docs/git-send-email">git send-email</a> rather than attaching patches to emails. Sending patches as @@ -161,6 +161,7 @@ state of your old patches to Superseded. <p> When you've reviewed a patch on the mailing list, please be unambiguous about your review. That is, state either +</p> <pre> Reviewed-by: Joe Hacker <[email protected]> </pre> @@ -168,14 +169,17 @@ or <pre> Acked-by: Joe Hacker <[email protected]> </pre> +<p> Rather than saying just "LGTM" or "Seems OK". </p> <p> If small changes are suggested, it's OK to say something like: +</p> <pre> With the above fixes, Reviewed-by: Joe Hacker <[email protected]> </pre> +<p> which tells the patch author that the patch can be committed, as long as the issues are resolved first. </p> |