diff options
| author | Tapani Pälli <[email protected]> | 2018-08-27 14:40:41 +0300 |
|---|---|---|
| committer | Tapani Pälli <[email protected]> | 2018-08-29 09:26:23 +0300 |
| commit | a72dbc461bdb7714656e62cd8f4b00a404c2e6e0 (patch) | |
| tree | c08c98c39f112b88585da0df2d06f4bf9679f45c /src | |
| parent | 5db981952ad65010dd140074ca15d4ee3d0686cc (diff) | |
mesa: allow GL_UNSIGNED_BYTE type for SNORM reads
OpenGL ES spec states:
"For normalized fixed-point rendering surfaces, the combination format
RGBA and type UNSIGNED_BYTE is accepted."
This fixes following failing VK-GL-CTS tests:
KHR-GLES3.packed_pixels.pbo_rectangle.rgba8_snorm
KHR-GLES3.packed_pixels.rectangle.rgba8_snorm
KHR-GLES3.packed_pixels.varied_rectangle.rgba8_snorm
Signed-off-by: Tapani Pälli <[email protected]>
https://bugs.freedesktop.org/show_bug.cgi?id=107658
Cc: [email protected]
Reviewed-by: Marek Olšák <[email protected]>
Tested-by: Andres Gomez <[email protected]>
Diffstat (limited to 'src')
| -rw-r--r-- | src/mesa/main/readpix.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 2cbb578a37f..556c860d393 100644 --- a/src/mesa/main/readpix.c +++ b/src/mesa/main/readpix.c @@ -958,6 +958,15 @@ read_pixels_es3_error_check(struct gl_context *ctx, GLenum format, GLenum type, return GL_NO_ERROR; } } + if (type == GL_UNSIGNED_BYTE) { + switch (internalFormat) { + case GL_R8_SNORM: + case GL_RG8_SNORM: + case GL_RGBA8_SNORM: + if (_mesa_has_EXT_render_snorm(ctx)) + return GL_NO_ERROR; + } + } break; case GL_BGRA: /* GL_EXT_read_format_bgra */ |