diff options
| author | Ian Romanick <[email protected]> | 2018-06-05 19:00:42 -0700 |
|---|---|---|
| committer | Ian Romanick <[email protected]> | 2018-06-15 17:36:51 -0700 |
| commit | 355868dbfc88313c0b0c59d3f038422ed6268255 (patch) | |
| tree | 1b57d1c53c5ea8ee7329722ed13bafdf1c0cdf0e /src | |
| parent | 4467040cb658529cb0e41be463b94e15f48f17a2 (diff) | |
nir: Document a couple instances of parent_instr
nir_ssa_def::parent_instr and nir_src::parent_instr have the same name,
but they mean really different things. I choose to save the next person
the hour+ that I just spent figuring that out. Even now that I know, I
doubt I'd notice in code review that someone typed foo->parent_instr
when they actually meant foo->ssa->parent_instr.
v2: Minor wording tweak in nir_ssa_def::parent_instr. Suggested by
Jason.
Signed-off-by: Ian Romanick <[email protected]>
Reviewed-by: Jason Ekstrand <[email protected]>
Diffstat (limited to 'src')
| -rw-r--r-- | src/compiler/nir/nir.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index bb477742dc6..2858e1f2880 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -490,6 +490,7 @@ typedef struct nir_ssa_def { /** Index into the live_in and live_out bitfields */ unsigned live_index; + /** Instruction which produces this SSA value. */ nir_instr *parent_instr; /** set of nir_instrs where this register is used (read from) */ @@ -529,6 +530,7 @@ struct nir_if; typedef struct nir_src { union { + /** Instruction that consumes this value as a source. */ nir_instr *parent_instr; struct nir_if *parent_if; }; |