diff options
| author | Lionel Landwerlin <[email protected]> | 2019-07-08 16:00:59 +0300 |
|---|---|---|
| committer | Lionel Landwerlin <[email protected]> | 2019-07-08 21:49:26 +0000 |
| commit | a72351cc763c75d57aee8a85a64859657c3ec7d8 (patch) | |
| tree | 2f6f089db95c9081abf2320e69ea1f50acb11aa3 /src | |
| parent | 6271d1632067d167c56dcc53756ef7303530f14b (diff) | |
vulkan/overlay: fix crash on freeing NULL command buffer
It is legal to call vkFreeCommandBuffers() on NULL command buffers.
This fix requires eb41ce1b012f24 ("util/hash_table: Properly handle
the NULL key in hash_table_u64").
Signed-off-by: Lionel Landwerlin <[email protected]>
Fixes: 4438188f492e1f ("vulkan/overlay: record stats in command buffers and accumulate on exec/submit")
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Diffstat (limited to 'src')
| -rw-r--r-- | src/vulkan/overlay-layer/overlay.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/vulkan/overlay-layer/overlay.cpp b/src/vulkan/overlay-layer/overlay.cpp index c4344f96aa4..a1fc30779f7 100644 --- a/src/vulkan/overlay-layer/overlay.cpp +++ b/src/vulkan/overlay-layer/overlay.cpp @@ -2026,6 +2026,10 @@ static void overlay_FreeCommandBuffers( for (uint32_t i = 0; i < commandBufferCount; i++) { struct command_buffer_data *cmd_buffer_data = FIND_CMD_BUFFER_DATA(pCommandBuffers[i]); + /* It is legal to free a NULL command buffer*/ + if (!cmd_buffer_data) + continue; + uint64_t count = (uintptr_t)find_object_data(HKEY(cmd_buffer_data->pipeline_query_pool)); if (count == 1) { unmap_object(HKEY(cmd_buffer_data->pipeline_query_pool)); |