diff options
| author | Rhys Perry <[email protected]> | 2018-12-06 12:11:00 +0000 |
|---|---|---|
| committer | Rhys Perry <[email protected]> | 2019-02-19 11:03:22 +0000 |
| commit | 0ca550e01ac55c67c2deef50f5cb750a0181352b (patch) | |
| tree | 2f04bf13906dfbb948e43dec7960d65d04aa04c8 /src | |
| parent | 64065aa504c4872a15f7b0894b6037a6b2bcae65 (diff) | |
radv: ensure export arguments are always float
So that the signature is correct and consistent, the inputs to a export
intrinsic should always be 32-bit floats.
This and the previous commit fixes a large amount crashes from
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_int_*
tests
Fixes: b722b29f10d ('radv: add support for 16bit input/output')
Signed-off-by: Rhys Perry <[email protected]>
Reviewed-by: Samuel Pitoiset <[email protected]>
Diffstat (limited to 'src')
| -rw-r--r-- | src/amd/vulkan/radv_nir_to_llvm.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index ba355fbf6d7..38ad9893644 100644 --- a/src/amd/vulkan/radv_nir_to_llvm.c +++ b/src/amd/vulkan/radv_nir_to_llvm.c @@ -2571,12 +2571,8 @@ si_llvm_init_export_args(struct radv_shader_context *ctx, } else memcpy(&args->out[0], values, sizeof(values[0]) * 4); - for (unsigned i = 0; i < 4; ++i) { - if (!(args->enabled_channels & (1 << i))) - continue; - + for (unsigned i = 0; i < 4; ++i) args->out[i] = ac_to_float(&ctx->ac, args->out[i]); - } } static void |