diff options
author | Brian Paul <[email protected]> | 2010-12-03 15:59:29 -0700 |
---|---|---|
committer | Brian Paul <[email protected]> | 2010-12-03 16:04:26 -0700 |
commit | 503983b09e86b2ea1bdc1268977e12eaea42293d (patch) | |
tree | b5eab40d3d886ed6ad57f93234cf0afe576fbd4d /src | |
parent | 40ee69b4f33288604f8d90a1d11a63dfde082952 (diff) |
mesa: make glGet*(GL_NONE) generate GL_INVALID_ENUM
In find_value() check if we've hit the 0th/invalid entry before checking
if the pname matches.
Fixes http://bugs.freedesktop.org/show_bug.cgi?id=31987
NOTE: This is a candidate for the 7.9 branch.
Diffstat (limited to 'src')
-rw-r--r-- | src/mesa/main/get.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 916b87d3134..5ae35b868e3 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -1759,16 +1759,18 @@ find_value(const char *func, GLenum pname, void **p, union value *v) hash = (pname * prime_factor); while (1) { d = &values[table[hash & mask]]; - if (likely(d->pname == pname)) - break; /* If the enum isn't valid, the hash walk ends with index 0, * which is the API mask entry at the beginning of values[]. */ - if (d->type == TYPE_API_MASK) { + if (unlikely(d->type == TYPE_API_MASK)) { _mesa_error(ctx, GL_INVALID_ENUM, "%s(pname=%s)", func, _mesa_lookup_enum_by_nr(pname)); return &error_value; } + + if (likely(d->pname == pname)) + break; + hash += prime_step; } |