summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorNicolai Hähnle <[email protected]>2016-11-07 17:49:24 +0100
committerNicolai Hähnle <[email protected]>2016-11-16 10:31:25 +0100
commit2fb4b5bdf6d10599d4b52bfca7095155a1437164 (patch)
tree966b46a95f9f66a3c159d46648142d5dcddc13b0 /src
parent3817a7a1d7434ae5ae069599013cea81cf809aa5 (diff)
st/mesa: fix ReadPixels into packed formats with PBO
When using the GPU download path, we bind the PBO as a buffer texture, so call is_format_supported accordingly. On radeonsi, this means that GPU downloads aren't used for UNSIGNED_SHORT_5_6_5 destinations, for example. Fixes parts of GL45-CTS.gtf32.GL3Tests.packed_pixels.packed_pixels_pbo. Reviewed-by: Marek Olšák <[email protected]> Reviewed-by: Edward O'Callaghan <[email protected]>
Diffstat (limited to 'src')
-rw-r--r--src/mesa/state_tracker/st_cb_readpixels.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/mesa/state_tracker/st_cb_readpixels.c b/src/mesa/state_tracker/st_cb_readpixels.c
index b79f1062a19..cab6abef323 100644
--- a/src/mesa/state_tracker/st_cb_readpixels.c
+++ b/src/mesa/state_tracker/st_cb_readpixels.c
@@ -112,8 +112,7 @@ try_pbo_readpixels(struct st_context *st, struct st_renderbuffer *strb,
if (texture->nr_samples > 1)
return false;
- if (!screen->is_format_supported(screen, dst_format, PIPE_TEXTURE_2D,
- texture->nr_samples,
+ if (!screen->is_format_supported(screen, dst_format, PIPE_BUFFER, 0,
PIPE_BIND_SHADER_IMAGE))
return false;