diff options
| author | Chuanbo Weng <[email protected]> | 2016-09-06 17:28:43 +0800 |
|---|---|---|
| committer | Emil Velikov <[email protected]> | 2016-09-12 16:52:55 +0100 |
| commit | 9a1eb5423722955bee5c5b5f48fb058f0884fab0 (patch) | |
| tree | 0fba8124ce362e3062e8a8144c5195938ced62ee /src | |
| parent | 63faf7de619be093c883318e90b5e317b9cb0eb1 (diff) | |
gbm: fix potential NULL deref of mapImage/unmapImage.
The mapImage/unmapImage functions of DRIimage extension can be NULL,
so we should add additional check for them.
Cc: <[email protected]>
Signed-off-by: Chuanbo Weng <[email protected]>
Reviewed-by: Emil Velikov <[email protected]>
Diffstat (limited to 'src')
| -rw-r--r-- | src/gbm/backends/dri/gbm_dri.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index c1f9d62d366..0ab67dad210 100644 --- a/src/gbm/backends/dri/gbm_dri.c +++ b/src/gbm/backends/dri/gbm_dri.c @@ -949,7 +949,7 @@ gbm_dri_bo_map(struct gbm_bo *_bo, return *map_data; } - if (!dri->image || dri->image->base.version < 12) { + if (!dri->image || dri->image->base.version < 12 || !dri->image->mapImage) { errno = ENOSYS; return NULL; } @@ -980,7 +980,8 @@ gbm_dri_bo_unmap(struct gbm_bo *_bo, void *map_data) return; } - if (!dri->context || !dri->image || dri->image->base.version < 12) + if (!dri->context || !dri->image || + dri->image->base.version < 12 || !dri->image->unmapImage) return; dri->image->unmapImage(dri->context, bo->image, map_data); |