aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorAlyssa Rosenzweig <[email protected]>2019-08-22 13:09:00 -0700
committerAlyssa Rosenzweig <[email protected]>2019-08-22 13:31:39 -0700
commitcaec0b32320de68c35a3f02dd2ef1e8f37de928c (patch)
tree55faa196f1424df2fec4872c769918d804e907c3 /src
parented464e05c88c941f61e79a1496b98c4a9f3d3324 (diff)
pan/decode: Remove size/stride divisibility check
The hardware doesn't care, and a lot of Panfrost code relies on an oversized buffer. The important part is that (stride * padded_num_vertices) is no greater than size, which we'll need to check once we validate instancing. Signed-off-by: Alyssa Rosenzweig <[email protected]>
Diffstat (limited to 'src')
-rw-r--r--src/panfrost/pandecode/decode.c10
1 files changed, 3 insertions, 7 deletions
diff --git a/src/panfrost/pandecode/decode.c b/src/panfrost/pandecode/decode.c
index 456d0fd15c8..2de376d4604 100644
--- a/src/panfrost/pandecode/decode.c
+++ b/src/panfrost/pandecode/decode.c
@@ -1276,13 +1276,9 @@ pandecode_attributes(const struct pandecode_mapped_memory *mem,
/* Print the stride and size */
pandecode_log_cont("<%u>[%u]", attr[i].stride, attr[i].size);
- /* Check: the size must be divisible by the stride */
- if (attr[i].size % attr[i].stride)
- pandecode_msg("XXX: size not divisible by stride\n");
-
- /* TODO: Sanity check the quotient itself -- it should equal
- * vertex count (or something computed from it for instanced)
- * which means we can check and elide */
+ /* TODO: Sanity check the quotient itself. It must be equal to
+ * (or be greater than, if the driver added padding) the padded
+ * vertex count. */
/* Finally, print the pointer */
mali_ptr raw_elements = attr[i].elements & ~7;