diff options
| author | Samuel Pitoiset <[email protected]> | 2020-06-24 09:15:47 +0200 |
|---|---|---|
| committer | Marge Bot <[email protected]> | 2020-06-25 12:09:08 +0000 |
| commit | a102896cff296fe305e4734be4a1774958d969d8 (patch) | |
| tree | a2284ef3bc63cdb9d06b200978add8069fbc54b6 /src | |
| parent | c84f11e7b67cfa3c01780210ca31665b658e5ebd (diff) | |
radv: lower 64-bit dfloor on GFX6 for fixing precision issues
GFX6 doesn't support v_floor_f64 and the precision of v_fract_f64
which is used to implement 64-bit floor is less than what Vulkan
requires.
Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-by: Daniel Schürmann <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5609>
Diffstat (limited to 'src')
| -rw-r--r-- | src/amd/compiler/aco_instruction_selection.cpp | 3 | ||||
| -rw-r--r-- | src/amd/vulkan/radv_shader.c | 8 |
2 files changed, 10 insertions, 1 deletions
diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp index 7f4da877068..de435ff7834 100644 --- a/src/amd/compiler/aco_instruction_selection.cpp +++ b/src/amd/compiler/aco_instruction_selection.cpp @@ -979,7 +979,8 @@ Temp emit_floor_f64(isel_context *ctx, Builder& bld, Definition dst, Temp val) if (ctx->options->chip_class >= GFX7) return bld.vop1(aco_opcode::v_floor_f64, Definition(dst), val); - /* GFX6 doesn't support V_FLOOR_F64, lower it. */ + /* GFX6 doesn't support V_FLOOR_F64, lower it (note that it's actually + * lowered at NIR level for precision reasons). */ Temp src0 = as_vgpr(ctx, val); Temp mask = bld.copy(bld.def(s1), Operand(3u)); /* isnan */ diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index a53100fd48b..1d653e786c5 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader.c @@ -478,6 +478,14 @@ radv_shader_compile_to_nir(struct radv_device *device, nir_lower_doubles_options lower_doubles = nir->options->lower_doubles_options; + if (device->physical_device->rad_info.chip_class == GFX6) { + /* GFX6 doesn't support v_floor_f64 and the precision + * of v_fract_f64 which is used to implement 64-bit + * floor is less than what Vulkan requires. + */ + lower_doubles |= nir_lower_dfloor; + } + NIR_PASS_V(nir, nir_lower_doubles, NULL, lower_doubles); } |