diff options
author | Duncan Hopkins <[email protected]> | 2020-03-12 16:45:39 +0000 |
---|---|---|
committer | Marge Bot <[email protected]> | 2020-03-17 13:04:30 +0000 |
commit | 4c35bc7e612f806d2e8a8a7126ddcdf45597806a (patch) | |
tree | be605d1d0732a257b49237d403e85e52c485f47f /src | |
parent | c923de68dd0ab10a5a5fb3196f539707d046d897 (diff) |
zink: zero out zink_render_pass_state
Since zink_render_pass_state is used as a hash-key, the entire struct gets
compared. This means we don't want any uninitialized padding in there, or
else we risk getting false negatives. This has led to issues on macOS builds.
So let's zero out the struct before we start filling it out.
Reviewed-by: Erik Faye-Lund <[email protected]>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4212>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4212>
Diffstat (limited to 'src')
-rw-r--r-- | src/gallium/drivers/zink/zink_context.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gallium/drivers/zink/zink_context.c b/src/gallium/drivers/zink/zink_context.c index 0580d234fec..e4343244894 100644 --- a/src/gallium/drivers/zink/zink_context.c +++ b/src/gallium/drivers/zink/zink_context.c @@ -484,7 +484,7 @@ get_render_pass(struct zink_context *ctx) { struct zink_screen *screen = zink_screen(ctx->base.screen); const struct pipe_framebuffer_state *fb = &ctx->fb_state; - struct zink_render_pass_state state; + struct zink_render_pass_state state = { 0 }; for (int i = 0; i < fb->nr_cbufs; i++) { struct pipe_resource *res = fb->cbufs[i]->texture; |