aboutsummaryrefslogtreecommitdiffstats
path: root/src/util
diff options
context:
space:
mode:
authorRoland Scheidegger <[email protected]>2017-12-13 03:33:21 +0100
committerRoland Scheidegger <[email protected]>2017-12-14 22:59:55 +0100
commita485ad0bcdcab865e14a54133a271198c86e41ab (patch)
treea5b33ec0f0c51ba2e9848b45b8e2ef52427e22c1 /src/util
parent4b8c9ea46bd83d9a2c7fa3b4edc10fe8c6403e3e (diff)
gallivm: fix an issue with NaNs with seamless cube filtering
Cube texture wrapping is a bit special since the values (post face projection) always are within [0,1], so we took advantage of that and omitted some clamps. However, we can still get NaNs (either because the coords already had NaNs, or the face projection generated them), and in fact we didn't handle them quite safely. I've seen -INT_MAX + 1 been propagated through as the final int coord value, albeit I didn't observe a crash. (Not quite a coincidence, since any stride mul with -INT_MAX or -INT_MAX+1 will turn up as a small positive number - nevertheless, I'd rather not try my luck, I'm not entirely sure it can't really turn up negative neither due to seamless coord swapping, plus ifloor of a NaN is not guaranteed to return -INT_MAX by any standard. And we kill off NaNs similarly with ordinary texture wrapping too.) So kill off the NaNs by using the common max against zero method. Reviewed-by: Brian Paul <[email protected]> Reviewed-by: Jose Fonseca <[email protected]>
Diffstat (limited to 'src/util')
0 files changed, 0 insertions, 0 deletions