diff options
| author | Alyssa Rosenzweig <[email protected]> | 2019-08-19 14:30:53 -0700 |
|---|---|---|
| committer | Alyssa Rosenzweig <[email protected]> | 2019-08-21 08:40:53 -0700 |
| commit | f5c293425fa457d91be8e689501619dfb16ccefe (patch) | |
| tree | c6a49b336ba069b299a38247b77e84088478fc66 /src/panfrost/pandecode | |
| parent | f6e41f30d00915e677737aca6d2b10b2c1c0eb3e (diff) | |
panfrost: Correct polygon size computations
While the algorithm for computing the header size has been correct for a
while, we used a major hack to conservatively guess the body size. Let's
scrap that and figure out the algorithm we actually need to use to be
bit-identical with what the hardware expects.
We do have to be careful to add the header size to total comptued BO
size.
It's not clear how big the polygon list needs to be in practice -- but
it has to be somewhat bigger than the polygon list itself. This needs
more investigation. If we size the polygon list exactly based on the
polygon_list_size field, we get faults like:
[ 1224.219886] panfrost ff9a0000.gpu: Unhandled Page fault in AS0 at VA 0x000000001BDE8000
Reason: TODO
raw fault status: 0x660003C3
decoded fault status: SLAVE FAULT
exception type 0xC3: TRANSLATION_FAULT_LEVEL3
access type 0x3: WRITE
source id 0x6600
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Diffstat (limited to 'src/panfrost/pandecode')
| -rw-r--r-- | src/panfrost/pandecode/decode.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/panfrost/pandecode/decode.c b/src/panfrost/pandecode/decode.c index 0af688f5729..476838d23fc 100644 --- a/src/panfrost/pandecode/decode.c +++ b/src/panfrost/pandecode/decode.c @@ -506,8 +506,7 @@ pandecode_midgard_tiler_descriptor( * ourselves for comparison */ unsigned ref_header = panfrost_tiler_header_size(width, height, t->hierarchy_mask); - unsigned ref_body = panfrost_tiler_body_size(width, height, t->hierarchy_mask); - unsigned ref_size = ref_header + ref_body; + unsigned ref_size = panfrost_tiler_full_size(width, height, t->hierarchy_mask); if (!((ref_header == body_offset) && (ref_size == t->polygon_list_size))) { pandecode_msg("XXX: bad polygon list size (expected %d / 0x%x)\n", |